Add intel_panel_fitter tool
PATCH 1/1 Add intel_panel_fitter tool
From: Paulo Zanoni <[email protected]>
The tool allows you to change the panel fitter settings, so you can change the size of the screen being displayed on your monitor without changing the real pixel size of your desktop. The biggest use case for this tool is to work around overscan done by TVs and some monitors in interlaced mode.
--- man/Makefile.am | 1 + man/intel_panel_fitter.man | 50 +++++++ tools/.gitignore | 1 + tools/Makefile.am | 1 + tools/intel_panel_fitter.c | 321 ++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 374 insertions(+), 0 deletions(-) create mode 100644 man/intel_panel_fitter.man create mode 100644 tools/intel_panel_fitter.c
man/Makefile.am +1 -0
@@ -7,6 +7,7 @@ appman_PRE = \ intel_gpu_top.man \ intel_gtt.man \ intel_lid.man \ + intel_panel_fitter.man \ intel_reg_dumper.man \ intel_reg_read.man \ intel_reg_write.man \
man/intel_panel_fitter.man new file +50 -0
50 lines not on this page · raw message
tools/.gitignore +1 -0
@@ -11,6 +11,7 @@ intel_gpu_time intel_gpu_top intel_gtt intel_lid +intel_panel_fitter intel_reg_checker intel_reg_dumper intel_reg_read
tools/Makefile.am +1 -0
@@ -8,6 +8,7 @@ bin_PROGRAMS = \ intel_gpu_top \ intel_gpu_time \ intel_gtt \ + intel_panel_fitter \ intel_stepping \ intel_reg_checker \ intel_reg_dumper \
tools/intel_panel_fitter.c new file +321 -0
321 lines not on this page · raw message
Signature · 6 lines
1.7.8.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
The tool allows you to change the panel fitter settings, so you can change the size of the screen being displayed on your monitor without changing the real pixel size of your desktop. The biggest use case for this tool is to work around overscan done by TVs and some monitors in interlaced mode.
I don't this should an installable tool for use by end-users. Direct register access from userspace to registers that the driver owns? I'm wary of installing even root-only tools that can screw us over in unpredictable ways.
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
2012/2/3 Chris Wilson <[email protected]>:
Quoted 5 lines
I don't this should an installable tool for use by end-users. Direct register access from userspace to registers that the driver owns? I'm wary of installing even root-only tools that can screw us over in unpredictable ways.
-Chris
My idea is to write a patch that adds kernel peroperties to solve this, but while people still don't have kernel 3.4, the tool would be useful.
If adding this tool to i-g-t is not a good idea, that's fine too: I still plan to write the kernel patches, so people wanting overscan compensation will have to use the kernel patch instead of the tool.
Quoted 3 lines
--
Chris Wilson, Intel Open Source Technology Centre
Signature · 1 line
Paulo Zanoni
Quoted 7 lines · Paulo Zanoni
2012/2/3 Chris Wilson<[email protected]>:
Quoted 5 lines
I don't this should an installable tool for use by end-users. Direct register access from userspace to registers that the driver owns? I'm wary of installing even root-only tools that can screw us over in unpredictable ways.
-Chris
Quoted 7 lines
My idea is to write a patch that adds kernel peroperties to solve this, but while people still don't have kernel 3.4, the tool would be useful.
If adding this tool to i-g-t is not a good idea, that's fine too: I still plan to write the kernel patches, so people wanting overscan compensation will have to use the kernel patch instead of the tool.
I didn't read that email from Chris as don't add it. I read it as, don't have it installed if they do make install or something. So I think he should clarify himself. If this benefits end users now - I'm all for it.
However it should somehow enforce that it is running as root. The most reusable way is to use the register_access_init functions designed for forcewake.
Ben
Quoted 12 lines · Ben Widawsky
Quoted 11 lines · Paulo Zanoni
2012/2/3 Chris Wilson<[email protected]>:
Quoted 5 lines
I don't this should an installable tool for use by end-users. Direct register access from userspace to registers that the driver owns? I'm wary of installing even root-only tools that can screw us over in unpredictable ways.
-ChrisMy idea is to write a patch that adds kernel peroperties to solve this, but while people still don't have kernel 3.4, the tool would be useful.
Quoted 8 lines
Quoted 3 lines
If adding this tool to i-g-t is not a good idea, that's fine too: I still plan to write the kernel patches, so people wanting overscan compensation will have to use the kernel patch instead of the tool.
I didn't read that email from Chris as don't add it. I read it as, don't have it installed if they do make install or something. So I think he should clarify himself. If this benefits end users now - I'm all for it.
As Ben said, I meant that I view this a debug/development tool and not the final end-user solution. I think it is useful to distribute such tools in i-g-t so that we can have testers, but I don't want it packaged by distributions and used as the preferred/correct mode of operation. -Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre