http://patchwork.ozlabs.org/patch/136415/ seems to break HUSH parser?
Hi,
Some time ago I have posted http://patchwork.ozlabs.org/patch/136368/
which adds HUSH parser to ED Mini V2. In itself, the change is only made of three CONFIG defines.
This patch has built cleanly and worked as expected until
http://patchwork.ozlabs.org/patch/136415/ was applied. Applying both patches causes edminiv2 build to fail with
uboot at lilith:~/src/u-boot-arm$ ./MAKEALL edminiv2 Configuring for edminiv2 board...common/libcommon.o: In function `cread_line':/home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to `get_ticks'/home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to `get_tbclk'/home/uboot/src/u-boot-arm/common/main.c:720: undefined reference to `get_ticks'
Heiko, can you look this up?
Amicalement,
Signature · 1 line
Albert.
Quoted 2 lines · Albert ARIBAUD
Hi,
Hi Albert,
Quoted 8 lines
Some time ago I have posted http://patchwork.ozlabs.org/patch/136368/
which adds HUSH parser to ED Mini V2. In itself, the change is only made of three CONFIG defines.This patch has built cleanly and worked as expected until
http://patchwork.ozlabs.org/patch/136415/ was applied. Applying both patches causes edminiv2 build to fail with
Quoted 9 lines
uboot at lilith:~/src/u-boot-arm$ ./MAKEALL edminiv2 Configuring for edminiv2 board...
common/libcommon.o: In function `cread_line':/home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to `get_ticks'/home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to `get_tbclk'/home/uboot/src/u-boot-arm/common/main.c:720: undefined reference to `get_ticks'
This is not a problem in your patch, but some SOCs have no implementation of the new and now accepted iunterface. I have sent patches for i.MX35/i.mx5/i.mx31:
http://patchwork.ozlabs.org/patch/139718/
I have seen that other SOCs have the same issue, while kirchwood has introduced an empty implementation for such functions. We should fix all remaining arch.
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
Hello Stefano,
Quoted 24 lines · Stefano Babic
Quoted 2 lines · Albert ARIBAUD
Hi,
Hi Albert,
Quoted 8 lines
Some time ago I have posted http://patchwork.ozlabs.org/patch/136368/
which adds HUSH parser to ED Mini V2. In itself, the change is only made of three CONFIG defines.This patch has built cleanly and worked as expected until
http://patchwork.ozlabs.org/patch/136415/ was applied. Applying both patches causes edminiv2 build to fail withQuoted 9 lines
uboot at lilith:~/src/u-boot-arm$ ./MAKEALL edminiv2 Configuring for edminiv2 board...
common/libcommon.o: In function `cread_line':/home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to `get_ticks'/home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to `get_tbclk'/home/uboot/src/u-boot-arm/common/main.c:720: undefined reference to `get_ticks'
Quoted 2 lines
This is not a problem in your patch, but some SOCs have no implementation of the new and now accepted iunterface. I have sent
Yep, exactly!
Quoted 2 lines
patches for i.MX35/i.mx5/i.mx31:
http://patchwork.ozlabs.org/patch/139718/
Thanks!
Quoted 3 lines
I have seen that other SOCs have the same issue, while kirchwood has introduced an empty implementation for such functions. We should fix all remaining arch.
Yes.
bye,
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Even I am facing this problem.
I have applied the patches to be mainlined to u-boot-marvell.git (tobe send for pull request) but my build is failing due to same issue.
Regards..
Prafulla . . .
Quoted 39 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot- bounces at lists.denx.de] On Behalf Of Albert ARIBAUD
Sent: 07 February 2012 04:13
To: Heiko Schocher
Cc: U-Boot
Subject: [U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems to break HUSH parser?Hi,
Some time ago I have posted http://patchwork.ozlabs.org/patch/136368/
which adds HUSH parser to ED Mini V2. In itself, the change is only made
of three CONFIG defines.This patch has built cleanly and worked as expected until
http://patchwork.ozlabs.org/patch/136415/ was applied. Applying both patches causes edminiv2 build to fail withuboot at lilith:~/src/u-boot-arm$ ./MAKEALL edminiv2 Configuring for edminiv2 board...
common/libcommon.o: In function `cread_line':/home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to `get_ticks'/home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to `get_tbclk'/home/uboot/src/u-boot-arm/common/main.c:720: undefined reference to `get_ticks'Heiko, can you look this up?
Amicalement,
--
Albert.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Hi Albert/Heiko
I have posted the patch for this fix for all ARM Marvell SoCs. Will include it and post the pull request.
Regards..
Prafulla . . .
Quoted 55 lines
-----Original Message-----
From: Prafulla Wadaskar
Sent: 08 February 2012 02:40
To: 'Albert ARIBAUD'; Heiko Schocher
Cc: U-Boot
Subject: RE: [U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems to break HUSH parser?Even I am facing this problem.
I have applied the patches to be mainlined to u-boot-marvell.git (tobe send for pull request) but my build is failing due to same issue.Regards..
Prafulla . . .Quoted 9 lines
-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot- bounces at lists.denx.de] On Behalf Of Albert ARIBAUD
Sent: 07 February 2012 04:13
To: Heiko Schocher
Cc: U-Boot
Subject: [U-Boot] http://patchwork.ozlabs.org/patch/136415/ seems to break HUSH parser?Quoted 3 lines
Hi,
Some time ago I have posted
http://patchwork.ozlabs.org/patch/136368/
Quoted 27 lines
which adds HUSH parser to ED Mini V2. In itself, the change is only made
of three CONFIG defines.This patch has built cleanly and worked as expected until
http://patchwork.ozlabs.org/patch/136415/ was applied. Applying both patches causes edminiv2 build to fail withuboot at lilith:~/src/u-boot-arm$ ./MAKEALL edminiv2 Configuring for edminiv2 board...
common/libcommon.o: In function `cread_line':/home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to `get_ticks'/home/uboot/src/u-boot-arm/common/main.c:717: undefined reference to `get_tbclk'/home/uboot/src/u-boot-arm/common/main.c:720: undefined reference to `get_ticks'Heiko, can you look this up?
Amicalement,
--
Albert.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot