Skip to contentSkip to conversation

ASoC: tlv320aic3x: Remove even more unused code

PATCH In review Mark Brown 3 participants 4 messages Feb 6, 2012 – Feb 7, 2012

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: tlv320aic3x: Remove even more unused code

Now that we're not implement GPIO or microphone support there's no users for the read() function any more.

---
 sound/soc/codecs/tlv320aic3x.c |   24 ------------------------
 1 files changed, 0 insertions(+), 24 deletions(-)
sound/soc/codecs/tlv320aic3x.c +0 -24
index 07efbed..8d20f6e 100644
@@ -121,30 +121,6 @@ static const u8 aic3x_reg[AIC3X_CACHEREGNUM] = {
 	0x00, 0x00, 0x02,	/* 100 */
 };
 
-/*
- * read from the aic3x register space. Only use for this function is if
- * wanting to read volatile bits from those registers that has both read-only
- * and read/write bits. All other cases should use snd_soc_read.
- */
-static int aic3x_read(struct snd_soc_codec *codec, unsigned int reg,
-		      u8 *value)
-{
-	u8 *cache = codec->reg_cache;
-
-	if (codec->cache_only)
-		return -EINVAL;
-	if (reg >= AIC3X_CACHEREGNUM)
-		return -1;
-
-	codec->cache_bypass = 1;
-	*value = snd_soc_read(codec, reg);
-	codec->cache_bypass = 0;
-
-	cache[reg] = *value;
-
-	return 0;
-}
-
 #define SOC_DAPM_SINGLE_AIC3X(xname, reg, shift, mask, invert) \
 {	.iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, \
 	.info = snd_soc_info_volsw, \
Signature · 1 line
1.7.9.rc1
author
#1 lore raw
Quoted 2 lines · Mark Brown

Now that we're not implement GPIO or microphone support there's no users for the read() function any more.

That's microphone detect, not plain microphone.

#2 lore raw
Quoted 5 lines · Mark Brown
Quoted 2 lines · Mark Brown

Now that we're not implement GPIO or microphone support there's no users for the read() function any more.

That's microphone detect, not plain microphone.

s/implement/implementing?

Signature · 1 line
Felipe Contreras
Acked-by
#3 lore raw
Quoted 10 lines · Felipe Contreras
Quoted 5 lines · Mark Brown
Quoted 2 lines · Mark Brown

Now that we're not implement GPIO or microphone support there's no users for the read() function any more.

That's microphone detect, not plain microphone.

s/implement/implementing?

You can have my ack here (I'd have acked Felipe's earlier cleanup too but noticed them only now). Support for gpio and detection were added almost 4 years ago according to log without seeing any users in mainline since then.