Skip to contentSkip to conversation

ext3: Update ctime in ext3_splice_branch() only when needed

PATCH In review Kazuya Mio 2 participants 2 messages Feb 8, 2012

lore
Share & tools
lore

Kazuya Mio

author
#0 lore raw

PATCH v2 1/1 ext3: Update ctime in ext3_splice_branch() only when needed

Currently ext3 updates ctime in ext3_splice_branch() which is called whenever we allocate one block. But it is wasteful because ext3 doesn't support nanosecond timestamp. This leads to a performance loss.

---
 fs/ext3/inode.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
fs/ext3/inode.c +1 -0
index 2d0afec..3c7fd63 100644
@@ -756,6 +756,7 @@ static int ext3_splice_branch(handle_t *handle, struct inode *inode,
 	struct ext3_block_alloc_info *block_i;
 	ext3_fsblk_t current_block;
 	struct ext3_inode_info *ei = EXT3_I(inode);
+	struct timespec now;
 
 	block_i = ei->i_block_alloc_info;
 	/*
@@ -795,9 +796,11 @@ static int ext3_splice_branch(handle_t *handle, struct inode *inode,
 	}
 
 	/* We are done with atomic stuff, now do the rest of housekeeping */
#1 lore raw
Quoted 5 lines · Kazuya Mio

Currently ext3 updates ctime in ext3_splice_branch() which is called whenever we allocate one block. But it is wasteful because ext3 doesn't support nanosecond timestamp. This leads to a performance loss.

Thanks. The patch looks good. I've added it to my tree.

Honza

Quoted 30 lines
---
 fs/ext3/inode.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
fs/ext3/inode.c +6 -3
index 2d0afec..3c7fd63 100644
@@ -756,6 +756,7 @@ static int ext3_splice_branch(handle_t *handle, struct inode *inode,
 	struct ext3_block_alloc_info *block_i;
 	ext3_fsblk_t current_block;
 	struct ext3_inode_info *ei = EXT3_I(inode);
+	struct timespec now;
 
 	block_i = ei->i_block_alloc_info;
 	/*
@@ -795,9 +796,11 @@ static int ext3_splice_branch(handle_t *handle, struct inode *inode,
 	}
 
 	/* We are done with atomic stuff, now do the rest of housekeeping */
-
-	inode->i_ctime = CURRENT_TIME_SEC;
-	ext3_mark_inode_dirty(handle, inode);
+	now = CURRENT_TIME_SEC;
+	if (!timespec_equal(&inode->i_ctime, &now) || !where->bh) {
+		inode->i_ctime = now;
+		ext3_mark_inode_dirty(handle, inode);
+	}
 	/* ext3_mark_inode_dirty already updated i_sync_tid */
 	atomic_set(&ei->i_datasync_tid, handle->h_transaction->t_tid);
 
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR