Skip to contentSkip to conversation

vpmu: Is CONFIG_SMP used anymore?

PATCH In review Dietmar Hahn 3 participants 4 messages Feb 8, 2012

lore
Share & tools
lore

Dietmar Hahn

author
#0 lore raw

PATCH 1/1 vpmu: Is CONFIG_SMP used anymore?

Hi,

while locking at the vpmu stuff I found the following stuff:

xen/arch/x86/oprofile/nmi_int.c +1 -1
diff -r a55e0f9c7b4e xen/arch/x86/oprofile/nmi_int.c
@@ -305,7 +305,7 @@ static int __init p4_init(char ** cpu_ty
 	}
 
 #ifndef CONFIG_SMP
-	*cpu_type = "i386/p4", XENOPROF_CPU_TYPE_SIZE);
+	*cpu_type = "i386/p4";
 	model = &op_p4_spec;
 	return 1;
 #else

Is CONFIG_SMP always switched on? It seems nobody tested without CONFIG_SMP. Thanks.

Dietmar.

Signature · 1 line
Company details: http://ts.fujitsu.com/imprint.html
#1 lore raw
Quoted 18 lines · Dietmar Hahn

Hi,

while locking at the vpmu stuff I found the following stuff:

diff -r a55e0f9c7b4e xen/arch/x86/oprofile/nmi_int.c

xen/arch/x86/oprofile/nmi_int.c Wed Feb 08 14:11:06 2012 +0100 renamed from xen/arch/x86/oprofile/nmi_int.c Wed Feb 08 12:28:47 2012 +0100 +1 -1
@@ -305,7 +305,7 @@ static int __init p4_init(char ** cpu_ty
 }
 
 #ifndef CONFIG_SMP
- *cpu_type = "i386/p4", XENOPROF_CPU_TYPE_SIZE);
+ *cpu_type = "i386/p4";
 model = &op_p4_spec;
 return 1;
 #else
Quoted 1 line

Is CONFIG_SMP always switched on? It seems nobody tested without CONFIG_SMP.

Correct. !CONFIG_SMP isn't configurable or supported.

-- Keir

Quoted 4 lines

Thanks.

Dietmar.

#2 lore raw
Quoted 20 lines · Keir Fraser
Quoted 18 lines · Dietmar Hahn

Hi,

while locking at the vpmu stuff I found the following stuff:

diff -r a55e0f9c7b4e xen/arch/x86/oprofile/nmi_int.c

xen/arch/x86/oprofile/nmi_int.c Wed Feb 08 14:11:06 2012 +0100 renamed from xen/arch/x86/oprofile/nmi_int.c Wed Feb 08 12:28:47 2012 +0100 +1 -1
@@ -305,7 +305,7 @@ static int __init p4_init(char ** cpu_ty
 }
 
 #ifndef CONFIG_SMP
- *cpu_type = "i386/p4", XENOPROF_CPU_TYPE_SIZE);
+ *cpu_type = "i386/p4";
 model = &op_p4_spec;
 return 1;
 #else
Quoted 4 lines
Quoted 1 line

Is CONFIG_SMP always switched on? It seems nobody tested without CONFIG_SMP.

Correct. !CONFIG_SMP isn't configurable or supported.

-- Keir

A naive test:

andrewcoop@andrewcoop:/local/xen-unstable.hg/xen$ rgrep "CONFIG_SMP" * |
wc -l
166

Seems there are quite a few bits to remove. If noone has done so, when I get round to gutting #ifdef __ia64__'s from the arch/x86 tree I shall do the same with CONFIG_SMP.

~Andrew

Quoted 10 lines
Quoted 4 lines

Thanks.

Dietmar.

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Signature · 2 lines
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
#3 lore raw
Quoted 7 lines · Andrew Cooper
Quoted 4 lines
Quoted 1 line

Is CONFIG_SMP always switched on? It seems nobody tested without CONFIG_SMP.

Correct. !CONFIG_SMP isn't configurable or supported.

-- Keir

A naive test:

Quoted 7 lines
andrewcoop@andrewcoop:/local/xen-unstable.hg/xen$ rgrep "CONFIG_SMP" * |
wc -l
166

Seems there are quite a few bits to remove. If noone has done so, when I get round to gutting #ifdef __ia64__'s from the arch/x86 tree I shall do the same with CONFIG_SMP.

Yeah we never actually went and deleted the !CONFIG_SMP bits we inherited from Linux. You can feel free to clean it up afaic.

-- Keir