mx31ads: Provide proper range for memtest

PATCH New Fabio Estevam 4 participants 15 messages Feb 12, 2012 – Mar 7, 2012 Arm i.MX and Layerscape

lore

Share & tools

lore

Fabio Estevam

author reviewer

2012-02-12 15:38 UTC #0 lore raw

PATCH 1/5 mx31ads: Provide proper range for memtest

memtest adresses should contain proper DRAM address range.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/mx31ads.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

include/configs/mx31ads.h +2 -2

index 87638a4..fe073ba 100644
@@ -146,8 +146,8 @@
 #define CONFIG_SYS_MAXARGS		16		/* max number of command args */
 #define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE	/* Boot Argument Buffer Size */
 
-#define CONFIG_SYS_MEMTEST_START	0		/* memtest works on */
-#define CONFIG_SYS_MEMTEST_END		0x10000
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
 
 #define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR

Signature · 1 line

1.7.1

Fabio Estevam

author reviewer

2012-02-12 15:38 UTC #1 lore raw

PATCH 2/5 mx35pdk: Provide proper range for memtest

From: Fabio Estevam <[email protected]>

memtest adresses should contain proper DRAM address range.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/mx35pdk.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

include/configs/mx35pdk.h +2 -2

index 0c62b9f..f2d4112 100644
@@ -156,8 +156,8 @@
 #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument Buffer Size */
 
-#define CONFIG_SYS_MEMTEST_START	0	/* memtest works on */
-#define CONFIG_SYS_MEMTEST_END		0x10000
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
 
 #undef	CONFIG_SYS_CLKS_IN_HZ	/* everything, incl board info, in Hz */

Signature · 1 line

1.7.1

Stefano Babic

2012-02-13 07:26 UTC #2 lore raw

PATCH 2/5 mx35pdk: Provide proper range for memtest

Quoted 14 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
memtest adresses should contain proper DRAM address range.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx35pdk.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/mx35pdk.h +0 -0
index 0c62b9f..f2d4112 100644

include/configs/mx35pdk.h line 163

Quoted 10 lines

include/configs/mx35pdk.h +2 -2

@@ -156,8 +156,8 @@
 #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument Buffer Size */
 
-#define CONFIG_SYS_MEMTEST_START	0	/* memtest works on */
-#define CONFIG_SYS_MEMTEST_END		0x10000
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
 
 #undef	CONFIG_SYS_CLKS_IN_HZ	/* everything, incl board info, in Hz */

Personally I do not like that the memory test runs taking automatically the input parameters - even if the test must run automatically, I think it is better to put the parameters inside a script else to compile them with U-Boot.

But if we want to change them, why to put the start address at the middle of RAM ? The mx35pdk can have two banks of RAM, and the second one will still not tested. What I mean is that it is quite arbitrary where to set CONFIG_SYS_MEMTEST_START and CONFIG_SYS_MEMTEST_END, and with the possibility on some boards to have different RAM configurations this setup should be not decided at compile time.

And setting the end of test at the end of RAM (but this can open a
debate: really the RAM size is computed at runtime with get_ram_size()) will overwrite U-Boot.

Stefano

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Stefano Babic

2012-03-07 10:10 UTC #3 lore raw

PATCH 2/5 mx35pdk: Provide proper range for memtest

In reply to Fabio Estevam

Quoted 14 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
memtest adresses should contain proper DRAM address range.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx35pdk.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/mx35pdk.h +0 -0
index 0c62b9f..f2d4112 100644

include/configs/mx35pdk.h line 163

Quoted 10 lines

include/configs/mx35pdk.h +2 -2

@@ -156,8 +156,8 @@
 #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument Buffer Size */
 
-#define CONFIG_SYS_MEMTEST_START	0	/* memtest works on */
-#define CONFIG_SYS_MEMTEST_END		0x10000
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
 
 #undef	CONFIG_SYS_CLKS_IN_HZ	/* everything, incl board info, in Hz */

Applied to u-boot-imx, thans.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Wolfgang Denk

2012-03-07 12:38 UTC #4 lore raw

PATCH 2/5 mx35pdk: Provide proper range for memtest

Dear Stefano Babic,

Quoted 8 lines · In message <[email protected]> you wrote:

include/configs/mx35pdk.h line 162
Quoted 6 lines
include/configs/mx35pdk.h +2 -0
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
 
 #undef	CONFIG_SYS_CLKS_IN_HZ	/* everything, incl board info, in Hz */
Applied to u-boot-imx, thans.

But this looks broken to me.

U-Boot will relocate itself to the end of RAM, and pout malloc arena and stack below. All this will be overwritten with this setup.

Has anybody actually tested this configuration?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Always borrow money from a pessimist; they don't expect to be paid back.

Stefano Babic

2012-03-07 13:08 UTC #5 lore raw

PATCH 2/5 mx35pdk: Provide proper range for memtest

Quoted 7 lines · Wolfgang Denk

Dear Stefano Babic,
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 4 lines
include/configs/mx35pdk.h +2 -0
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)

Quoted 6 lines

Quoted 4 lines
Quoted 2 lines
#undef CONFIG_SYS_CLKS_IN_HZ /* everything, incl board info, in Hz */
Applied to u-boot-imx, thans.
But this looks broken to me.

Me too. I have not applied this patch. Rather I sent the "applied" message to the wrong patchset.

Quoted 3 lines

U-Boot will relocate itself to the end of RAM, and pout malloc arena and stack below. All this will be overwritten with this setup.

This was stated also in the thread related this patchset. Sorry for the confusion, I have really applied another patchset by Fabio, as you can see on u-boot-imx:

mx31pdk: Fix CONFIG_SYS_MEMTEST_END
efikamx: Fix CONFIG_SYS_MEMTEST_END
mx53smd: Fix CONFIG_SYS_MEMTEST_END
mx53evk: Fix CONFIG_SYS_MEMTEST_END
mx51evk: Fix CONFIG_SYS_MEMTEST_END

In patchworks things are ok, only my e-mail was wrong (reply to wrong e-mail).

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Fabio Estevam

author reviewer

2012-02-12 15:38 UTC #6 lore raw

PATCH 3/5 flea3: Provide proper range for memtest

In reply to Fabio Estevam

memtest adresses should contain proper DRAM address range.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/flea3.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

include/configs/flea3.h +2 -2

index 649e272..748d2b4 100644
@@ -140,8 +140,8 @@
 #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument Buffer Size */
 
-#define CONFIG_SYS_MEMTEST_START	0	/* memtest works on */
-#define CONFIG_SYS_MEMTEST_END		0x10000
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
 
 #undef	CONFIG_SYS_CLKS_IN_HZ	/* everything, incl board info, in Hz */

Signature · 1 line

1.7.1

Stefano Babic

2012-03-07 10:10 UTC #7 lore raw

PATCH 3/5 flea3: Provide proper range for memtest

Quoted 12 lines · Fabio Estevam

memtest adresses should contain proper DRAM address range.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/flea3.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/flea3.h +0 -0
index 649e272..748d2b4 100644

include/configs/flea3.h line 147

Quoted 10 lines

include/configs/flea3.h +2 -2

@@ -140,8 +140,8 @@
 #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument Buffer Size */
 
-#define CONFIG_SYS_MEMTEST_START	0	/* memtest works on */
-#define CONFIG_SYS_MEMTEST_END		0x10000
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
 
 #undef	CONFIG_SYS_CLKS_IN_HZ	/* everything, incl board info, in Hz */

Applied to u-boot-imx, thans.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Wolfgang Denk

2012-03-07 12:39 UTC #8 lore raw

PATCH 3/5 flea3: Provide proper range for memtest

Dear Stefano Babic,

Quoted 8 lines · In message <[email protected]> you wrote:

include/configs/flea3.h line 146

Quoted 6 lines

include/configs/flea3.h +2 -0

+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
 
 #undef	CONFIG_SYS_CLKS_IN_HZ	/* everything, incl board info, in Hz */

Applied to u-boot-imx, thans.

Ditto - same for the other "Provide proper range for memtest" patches.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Business is like a wheelbarrow. Nothing ever happens until you  start
pushing.

Fabio Estevam

author reviewer

2012-02-12 15:38 UTC #9 lore raw

PATCH 4/5 imx31_litekit: Provide proper range for memtest

In reply to Fabio Estevam

memtest adresses should contain proper DRAM address range.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/imx31_litekit.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

include/configs/imx31_litekit.h +2 -2

index bbcbce1..fcbd4a5 100644
@@ -130,8 +130,8 @@
 #define CONFIG_SYS_MAXARGS		16          /* max number of command args */
 #define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE  /* Boot Argument Buffer Size */
 
-#define CONFIG_SYS_MEMTEST_START	0  /* memtest works on */
-#define CONFIG_SYS_MEMTEST_END		0x10000
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
 
 #define CONFIG_SYS_LOAD_ADDR		0 /* default load address */

Signature · 1 line

1.7.1

Stefano Babic

2012-03-07 10:10 UTC #10 lore raw

PATCH 4/5 imx31_litekit: Provide proper range for memtest

Quoted 12 lines · Fabio Estevam

memtest adresses should contain proper DRAM address range.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/imx31_litekit.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/imx31_litekit.h +0 -0
index bbcbce1..fcbd4a5 100644

include/configs/imx31_litekit.h line 137

Quoted 10 lines

include/configs/imx31_litekit.h +2 -2

@@ -130,8 +130,8 @@
 #define CONFIG_SYS_MAXARGS		16          /* max number of command args */
 #define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE  /* Boot Argument Buffer Size */
 
-#define CONFIG_SYS_MEMTEST_START	0  /* memtest works on */
-#define CONFIG_SYS_MEMTEST_END		0x10000
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
 
 #define CONFIG_SYS_LOAD_ADDR		0 /* default load address */

Applied to u-boot-imx, thans.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Fabio Estevam

author reviewer

2012-02-12 15:38 UTC #11 lore raw

PATCH 5/5 imx31_phycore: Provide proper range for memtest

In reply to Fabio Estevam

memtest adresses should contain proper DRAM address range.

Signed-off-by Fabio Estevam <[email protected]>

---
 include/configs/imx31_phycore.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

include/configs/imx31_phycore.h +2 -2

index 3153eb5..f0766d4 100644
@@ -134,8 +134,8 @@
 /* Boot Argument Buffer Size */
 #define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
 
-#define CONFIG_SYS_MEMTEST_START	0  /* memtest works on */
-#define CONFIG_SYS_MEMTEST_END		0x10000
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
 
 #define CONFIG_SYS_LOAD_ADDR		0 /* default load address */

Signature · 1 line

1.7.1

Stefano Babic

2012-03-07 10:11 UTC #12 lore raw

PATCH 5/5 imx31_phycore: Provide proper range for memtest

Quoted 12 lines · Fabio Estevam

memtest adresses should contain proper DRAM address range.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/imx31_phycore.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/imx31_phycore.h +0 -0
index 3153eb5..f0766d4 100644

include/configs/imx31_phycore.h line 141

Quoted 10 lines

include/configs/imx31_phycore.h +2 -2

@@ -134,8 +134,8 @@
 /* Boot Argument Buffer Size */
 #define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
 
-#define CONFIG_SYS_MEMTEST_START	0  /* memtest works on */
-#define CONFIG_SYS_MEMTEST_END		0x10000
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE)
 
 #define CONFIG_SYS_LOAD_ADDR		0 /* default load address */

Applied to u-boot-imx, thans.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Marek Vasut

2012-02-13 07:12 UTC #13 lore raw

PATCH 1/5 mx31ads: Provide proper range for memtest

In reply to Fabio Estevam

include/configs/mx31ads.h line 146

Quoted 13 lines

memtest adresses should contain proper DRAM address range.
Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx31ads.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/configs/mx31ads.h +0 -0
index 87638a4..fe073ba 100644
@@ -146,8 +146,8 @@
 #define CONFIG_SYS_MAXARGS		16		/* max number of command 

args */

include/configs/mx31ads.h line 147

Quoted 1 line

include/configs/mx31ads.h +0 -0

 #define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE	/* Boot Argument

Buffer

include/configs/mx31ads.h

Quoted 6 lines

Size */

include/configs/mx31ads.h +2 -2

-#define CONFIG_SYS_MEMTEST_START	0		/* memtest works on */
-#define CONFIG_SYS_MEMTEST_END		0x10000
+#define CONFIG_SYS_MEMTEST_START	(PHYS_SDRAM_1 + PHYS_SDRAM_1_SIZE/2)
+#define CONFIG_SYS_MEMTEST_END		(PHYS_SDRAM_1 +

PHYS_SDRAM_1_SIZE)

Won't this overwrite teh u-boot at the end of the RAM?

Quoted 2 lines

#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR

Stefano Babic

2012-03-07 10:11 UTC #14 lore raw

PATCH 1/5 mx31ads: Provide proper range for memtest

In reply to Fabio Estevam

Quoted 4 lines · Fabio Estevam

memtest adresses should contain proper DRAM address range.
Signed-off-by Fabio Estevam <[email protected]>
---

Applied to u-boot-imx, thans.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================