mmc: dw_mmc: shift with slot-id for CLKENA register

PATCH In review Jaehoon Chung 3 participants 3 messages Feb 14, 2012

Subsystems (2)

MMC, SD and SDIO Synopsys DesignWare MMC/SD/SDIO driver

lore

Share & tools

lore

Jaehoon Chung

author maintainer

2012-02-14 08:33 UTC #0 lore raw

PATCH 1/1 mmc: dw_mmc: shift with slot-id for CLKENA register

In CLKENA register, can support 16-SD card clocks. If support correctly, must shift with slot-id.

Signed-off-by Jaehoon Chung <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 drivers/mmc/host/dw_mmc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

drivers/mmc/host/dw_mmc.c +2 -2

index 7d6ad6c..f9457e5 100644
@@ -652,8 +652,8 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot)
 			     SDMMC_CMD_UPD_CLK | SDMMC_CMD_PRV_DAT_WAIT, 0);
 
 		/* enable clock */
-		mci_writel(host, CLKENA, SDMMC_CLKEN_ENABLE |
-			   SDMMC_CLKEN_LOW_PWR);
+		mci_writel(host, CLKENA, ((SDMMC_CLKEN_ENABLE |
+			   SDMMC_CLKEN_LOW_PWR) << slot->id));
 
 		/* inform CIU */
 		mci_send_cmd(slot,

Will Newton

Acked-by on v1 1/1

2012-02-14 10:30 UTC #1 lore raw

Quoted 5 lines · Jaehoon Chung

In CLKENA register, can support 16-SD card clocks. If support correctly, must shift with slot-id.
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

Looks good.

Acked-by Will Newton <[email protected]>

Chris Ball

2012-02-14 11:28 UTC #2 lore raw

Hi,

Quoted 10 lines · Will Newton

Quoted 5 lines · Jaehoon Chung
In CLKENA register, can support 16-SD card clocks. If support correctly, must shift with slot-id.
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Looks good.
Acked-by Will Newton <[email protected]>

Thanks, pushed to mmc-next for 3.4.

- Chris.

Signature · 2 lines

Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child