sh: i2c: Add support I2C controller of SH7734
PATCH v2 1/1 sh: i2c: Add support I2C controller of SH7734
Renesas SH7734 has two I2C interfaceis.
This supports these I2C.
---
V2: - Changed bit control to use the clr|set|clrsetbits_* functions.
- Fix wrong comment style.
- Add new line before for loop in i2c_read.
drivers/i2c/Makefile | 1 + drivers/i2c/sh_sh7734_i2c.c | 445 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 446 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/sh_sh7734_i2c.c
drivers/i2c/Makefile +1 -0
@@ -44,6 +44,7 @@ COBJS-$(CONFIG_SPEAR_I2C) += spr_i2c.o COBJS-$(CONFIG_TSI108_I2C) += tsi108_i2c.o COBJS-$(CONFIG_U8500_I2C) += u8500_i2c.o COBJS-$(CONFIG_SH_I2C) += sh_i2c.o +COBJS-$(CONFIG_SH_SH7734_I2C) += sh_sh7734_i2c.o COBJS := $(COBJS-y) SRCS := $(COBJS:.o=.c)
drivers/i2c/sh_sh7734_i2c.c new file +445 -0
445 lines not on this page · raw message
Signature · 1 line
1.7.7.3
PATCH v2 1/1 sh: i2c: Add support I2C controller of SH7734
Hello Nobuhiro,
Quoted 9 lines · Nobuhiro Iwamatsu
Renesas SH7734 has two I2C interfaceis.
This supports these I2C.Signed-off-by Nobuhiro Iwamatsu <[email protected]>---
V2: - Changed bit control to use the clr|set|clrsetbits_* functions.
- Fix wrong comment style.
- Add new line before for loop ini2c_read.
Quoted 4 lines
drivers/i2c/Makefile | 1 + drivers/i2c/sh_sh7734_i2c.c | 445 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 446 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/sh_sh7734_i2c.c
[hs at pollux u-boot]$ ./tools/checkpatch.pl index.html
ERROR: trailing whitespace
#238: FILE: drivers/i2c/sh_sh7734_i2c.c:193:
+^Isetbits_8(&base->iccr2, SH_I2C_ICCR2_IICRST);^I$
total: 1 errors, 0 warnings, 452 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
index.html has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. [hs at pollux u-boot]$
Beside of that, I Ack this patch only, so you can pick it up in your u-boot-sh.git tree, because it is dependend on the following patch from you:
sh: Add bit control functions
http://patchwork.ozlabs.org/patch/141259/
If this is Ok for you, please add my:
bye,
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH v2 1/1 sh: i2c: Add support I2C controller of SH7734
Hi, Heiko
2012/2/15 Heiko Schocher <[email protected]>:
Quoted 39 lines
Hello Nobuhiro,
Quoted 9 lines · Nobuhiro Iwamatsu
Renesas SH7734 has two I2C interfaceis.
This supports these I2C.Signed-off-by Nobuhiro Iwamatsu <[email protected]>---
V2: - Changed bit control to use the clr|set|clrsetbits_* functions. ? ? - Fix wrong comment style.
? ? ? - Add new line before for loop ini2c_read.Quoted 4 lines
?drivers/i2c/Makefile ? ? ? ?| ? ?1 +
?drivers/i2c/sh_sh7734_i2c.c | ?445 +++++++++++++++++++++++++++++++++++++++++++ ?2 files changed, 446 insertions(+), 0 deletions(-)
?create mode 100644drivers/i2c/sh_sh7734_i2c.c[hs at pollux u-boot]$
./tools/checkpatch.plindex.html
ERROR: trailing whitespace
#238: FILE:drivers/i2c/sh_sh7734_i2c.c:193:
+^Isetbits_8(&base->iccr2, SH_I2C_ICCR2_IICRST);^I$total: 1 errors, 0 warnings, 452 lines checked
NOTE: whitespace errors detected, you may wish to use
scripts/cleanpatchor ? ? ?scripts/cleanfileNOTE: Ignored message types:
COMPLEX_MACROCONSIDER_KSTRTOMINMAXMULTISTATEMENT_MACRO_USE_DO_WHILEindex.html has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in
MAINTAINERS. [hs at pollux u-boot]$Beside of that, I Ack this patch only, so you can pick it up in your u-boot-sh.git tree, because it is dependend on the following patch from you:
Quoted 7 lines
sh: Add bit control functions
http://patchwork.ozlabs.org/patch/141259/If this is Ok for you, please add my:
Acked-by Heiko Schocher <[email protected]>
Thanks for your review.
I resend revised patch with your Acked-by.
Best regards,
Nobuhiro
Signature · 1 line
Nobuhiro Iwamatsu