Skip to contentSkip to conversation

Makefile.am referenced a now non-existing config-win32.h

PATCH In review David Sommerseth 3 participants 4 messages Feb 17, 2012 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile.am referenced a now non-existing config-win32.h

This file was moved to win/config.h.in and is the template used by the Python build tools in win/. This happened in commit 4b312378e9e7084a0699ca6d4b895bdadb7540db

For all other autotools based environments, ./configure will take care of creating the proper config.h

---
 Makefile.am |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Makefile.am +0 -1
index ab86cc1..2029389 100644
@@ -85,7 +85,6 @@ openvpn_SOURCES = \
 	clinat.c clinat.h \
 	common.h \
 	compat.h compat.c \
-	config-win32.h \
 	crypto.c crypto.h crypto_backend.h \
 	crypto_openssl.c crypto_openssl.h \
 	crypto_polarssl.c crypto_polarssl.h \
Signature · 1 line
1.7.4.4
#1 lore raw

When did this file gone?
Anyway, this was required with compiling using MSVC...

Quoted 37 lines · David Sommerseth

This file was moved to win/config.h.in and is the template used by the Python build tools in win/.  This happened in commit 4b312378e9e7084a0699ca6d4b895bdadb7540db

For all other autotools based environments, ./configure will take care of creating the proper config.h

---
 Makefile.am |    1 -

 1 files changed, 0 insertions(+), 1 deletions(-)
Makefile.am +0 -2
index ab86cc1..2029389 100644
@@ -85,7 +85,6 @@ openvpn_SOURCES = \
        clinat.c clinat.h \
        common.h \
        compat.h compat.c \
-       config-win32.h \
        crypto.c crypto.h crypto_backend.h \
        crypto_openssl.c crypto_openssl.h \
        crypto_polarssl.c crypto_polarssl.h \
--

1.7.4.4

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Acked-by James Yonan
#2 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 2 lines · Alon Bar-Lev

When did this file gone? Anyway, this was required with compiling using MSVC...

This is the commit referenced:

commit 4b312378e9e7084a0699ca6d4b895bdadb7540db

Author: Samuli Seppänen <[email protected]...>
Date:   Tue Mar 15 16:37:41 2011 +0200

Replaced config-win32.h with win/config.h.in

The original config-win32.h - a static header file - has been superceded by both "domake-win" script and the new Python-based buildsystem. Transformed it into a template file, win/config.h.in, which obtains the most commonly used build parameters from win/settings.in.

Added support code to win/config.py and win/wb.py to preprocess win/config.h.in and copy it to config.h, from where source and header files can find it.

Removed all references to config-win32.h. Also removed obsolete PACKAGE_BUGREPORT and USE_PTHREAD variables from the win/config.h.in file.

kind regards,

David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk8+ONwACgkQDC186MBRfrociQCfTopQrINB9mjNUnqgPShF7hvA d7gAoJvf0XjI59upjzKdKdqDVqh7n3Eo
=vB7z
-----END PGP SIGNATURE-----

#3 lore raw
In reply to David Sommerseth

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 9 lines · David Sommerseth

This file was moved to win/config.h.in and is the template used by the Python build tools in win/. This happened in commit 4b312378e9e7084a0699ca6d4b895bdadb7540db

For all other autotools based environments, ./configure will take care of creating the proper config.h

1 - 1 files changed, 0 insertions(+), 1 deletions(-)

Applied to master branch on -testing and -stable trees.

commit ec3a7814d436076a442979ec656d3e8431d55d73

Author: David Sommerseth <[email protected]...>
Date:   Fri Feb 17 12:09:51 2012 +0100
    Makefile.am referenced a now non-existing config-win32.h

    Signed-off-by: David Sommerseth <[email protected]...>
    Acked-by: Gert Doering <[email protected]...>

kind regards,

David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk8+ScEACgkQDC186MBRfrog7wCdF8hRIHwbz/I4tvd0nSP3jB72 gvsAnAx39dBmgUStmzlm+FV2u+tqDU+k
=oCO7
-----END PGP SIGNATURE-----