ARM: omap3: temporary disable USB on TAM3517 boards
PATCH 1/1 ARM: omap3: temporary disable USB on TAM3517 boards
The TAM3517 boards require a patch for EHCI OMAP that does not yet find a way to mainline. The patch disables temporary USB until EHCI OMAP will be supported.
--- include/configs/tam3517-common.h | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)
include/configs/tam3517-common.h +5 -2
@@ -97,12 +97,16 @@#define CONFIG_DOS_PARTITION /* EHCI */ +#undef CONFIG_CMD_USB +#ifdef CONFIG_CMD_USB #define CONFIG_OMAP3_GPIO_5 #define CONFIG_USB_EHCI #define CONFIG_USB_EHCI_OMAP -#define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO 25#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3#define CONFIG_USB_STORAGE +#endif + +#define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO 25/* #define CONFIG_EHCI_DCACHE */
@@ -121,7 +125,6 @@#define CONFIG_CMD_NFS #define CONFIG_CMD_NAND /* NAND support */ #define CONFIG_CMD_PING -#define CONFIG_CMD_USB #undef CONFIG_CMD_FLASH/* only NAND on the SOM */ #undef CONFIG_CMD_IMLS
Signature · 1 line
1.7.5.4
PATCH 1/1 ARM: omap3: temporary disable USB on TAM3517 boards
Dear Stefano Babic,
include/configs/tam3517-common.h line 101
Quoted 3 lines · In message <[email protected]> you wrote:
include/configs/tam3517-common.h +2
-0+#undef CONFIG_CMD_USB +#ifdef CONFIG_CMD_USB
Please do not undef what is not defined in the first place.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Boss, n.: According to the Oxford English Dictionary, in the Middle Ages the words "boss" and "botch" were largely synonymous, except that boss, in addition to meaning "a supervisor of workers" also meant "an ornamental stud."
PATCH 1/1 ARM: omap3: temporary disable USB on TAM3517 boards
In reply to Stefano BabicQuoted 11 lines
The TAM3517 boards require a patch for EHCI OMAP that does not yet find a way to mainline. The patch disables temporary USB until EHCI OMAP will be supported.
Signed-off-by Stefano Babic <[email protected]>Cc Tom Rini <[email protected]>Cc Albert Aribaud <[email protected]>--- include/configs/tam3517-common.h | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)
Hi,
what's the status of this patch/patchset?
Thanks
M
PATCH 1/1 ARM: omap3: temporary disable USB on TAM3517 boards
Quoted 12 lines · Marek Vasut
Quoted 11 lines
The TAM3517 boards require a patch for EHCI OMAP that does not yet find a way to mainline. The patch disables temporary USB until EHCI OMAP will be supported.
Signed-off-by Stefano Babic <[email protected]>Cc Tom Rini <[email protected]>Cc Albert Aribaud <[email protected]>--- include/configs/tam3517-common.h | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)
Quoted 3 lines
Hi,
what's the status of this patch/patchset?
Superseded by:8c589d6f (OMAP3: TAM3517: update ehci interface)
Signature · 2 lines
Regards, Igor.
PATCH 1/1 ARM: omap3: temporary disable USB on TAM3517 boards
In reply to Marek VasutQuoted 12 lines · Marek Vasut
Quoted 11 lines
The TAM3517 boards require a patch for EHCI OMAP that does not yet find a way to mainline. The patch disables temporary USB until EHCI OMAP will be supported.
Signed-off-by Stefano Babic <[email protected]>Cc Tom Rini <[email protected]>Cc Albert Aribaud <[email protected]>--- include/configs/tam3517-common.h | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)
Quoted 3 lines
Hi,
what's the status of this patch/patchset?
The patch must be dropped - after I sent it, Govindraj's patches cleaned up the code adding OMAP4 support and these patches are now mainline. Everything is mainlined now, we need only to discharge this patch.
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH 1/1 ARM: omap3: temporary disable USB on TAM3517 boards
Quoted 15 lines · Marek Vasut
Quoted 14 lines
Quoted 11 lines
The TAM3517 boards require a patch for EHCI OMAP that does not yet find a way to mainline. The patch disables temporary USB until EHCI OMAP will be supported.
Signed-off-by Stefano Babic <[email protected]>Cc Tom Rini <[email protected]>Cc Albert Aribaud <[email protected]>---
include/configs/tam3517-common.h | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)Hi,
Quoted 7 lines
Quoted 1 line
what's the status of this patch/patchset?
The patch must be dropped - after I sent it, Govindraj's patches cleaned up the code adding OMAP4 support and these patches are now mainline. Everything is mainlined now, we need only to discharge this patch.
Stefano
Updated status in patchwork, Thanks!
M