ARM: Define change_bit routine

PATCH New Amit Virdi 2 participants 3 messages Feb 27, 2012 – Feb 29, 2012

Subsystems (2)

Arm (32-bit) Bitops API

lore

Share & tools

lore

Amit Virdi

author

2012-02-27 09:33 UTC #0 lore raw

PATCH 1/1 ARM: Define change_bit routine

From: Vipin KUMAR <[email protected]>

change_bit routine is left implementation dependent until now. This routine is now defined for arm platforms in asm-arm/bitops.h

The Flexible Static memory controller driver, placed in mtd/nand/fsmc_nand.c needs this routine. FSMC is a memory controller peripheral from ST. The new driver implements the NAND interface part of the peripheral.

Signed-off-by Vipin Kumar <[email protected]>

Signed-off-by Amit Virdi <[email protected]>

---
 arch/arm/include/asm/bitops.h |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

arch/arm/include/asm/bitops.h +9 -2

index 879e20e..8ce1405 100644
@@ -29,8 +29,6 @@ extern void set_bit(int nr, volatile void * addr);
 
 extern void clear_bit(int nr, volatile void * addr);
 
-extern void change_bit(int nr, volatile void * addr);
-
 static inline void __change_bit(int nr, volatile void *addr)
 {
 	unsigned long mask = BIT_MASK(nr);

@@ -39,6 +37,15 @@ static inline void __change_bit(int nr, volatile void *addr)
 	*p ^= mask;
 }
 
+static inline void change_bit(int nr, volatile void *addr)
+{
+	unsigned long flags;
+
+	local_irq_save(flags);
+	__change_bit(nr, addr);
+	local_irq_restore(flags);
+}
+
 static inline int __test_and_set_bit(int nr, volatile void *addr)
 {
 	unsigned long mask = BIT_MASK(nr);

Signature · 1 line

1.7.2.2

Albert ARIBAUD

2012-02-28 23:19 UTC #1 lore raw

PATCH 1/1 ARM: Define change_bit routine

Hi Amit,

Le 27/02/2012 10:33, Amit Virdi a ?crit :

Quoted 10 lines

From: Vipin KUMAR<[email protected]>
change_bit routine is left implementation dependent until now. This routine is now defined for arm platforms in asm-arm/bitops.h
The Flexible Static memory controller driver, placed in mtd/nand/fsmc_nand.c needs this routine. FSMC is a memory controller peripheral from ST. The new driver implements the NAND interface part of the peripheral.

Quoted 5 lines

Signed-off-by Vipin Kumar<[email protected]>
Signed-off-by Amit Virdi<[email protected]>
---
  arch/arm/include/asm/bitops.h |   11 +++++++++--
  1 files changed, 9 insertions(+), 2 deletions(-)

NAK as this is submitted as an isolated patch to dead code.

Provide it as a member of a patchset where some later patch uses it -- and justify that you really need this function.

Amicalement,

Signature · 1 line

Albert.

Amit Virdi

author

2012-02-29 05:21 UTC #2 lore raw

PATCH 1/1 ARM: Define change_bit routine

Hello Albert,

Quoted 19 lines · Albert ARIBAUD

Hi Amit,
Le 27/02/2012 10:33, Amit Virdi a ?crit :
Quoted 10 lines
From: Vipin KUMAR<[email protected]>
change_bit routine is left implementation dependent until now. This routine is now defined for arm platforms in asm-arm/bitops.h
The Flexible Static memory controller driver, placed in mtd/nand/fsmc_nand.c needs this routine. FSMC is a memory controller peripheral from ST. The new driver implements the NAND interface part of the peripheral.
Quoted 5 lines
Signed-off-by Vipin Kumar<[email protected]>
Signed-off-by Amit Virdi<[email protected]>
---
   arch/arm/include/asm/bitops.h |   11 +++++++++--
   1 files changed, 9 insertions(+), 2 deletions(-)

Quoted 5 lines

NAK as this is submitted as an isolated patch to dead code.
Provide it as a member of a patchset where some later patch uses it -- and justify that you really need this function.

Ok. change_bit routine is used by FSMC driver. I should be re-sending it as a part of FSMC driver patchset.

Regards
Amit Virdi