ARM: EXYNOS: Add USB HOST register definitions

PATCH Superseded Jingoo Han 2 participants 3 messages Feb 29, 2012 – Mar 1, 2012

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

lore

Share & tools

lore

Jingoo Han

author

2012-02-29 14:39 UTC #0 lore raw

PATCH 1/2 ARM: EXYNOS: Add USB HOST register definitions

This patch adds USB HOST register definitions. The definition for EHCI INSNREG00 regiser and corresponding bit field definitions are added.

Signed-off-by Jingoo Han <[email protected]>

---
 arch/arm/mach-exynos/include/mach/regs-usb-host.h |   23 +++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-exynos/include/mach/regs-usb-host.h

arch/arm/mach-exynos/include/mach/regs-usb-host.h new file +23 -0

new file mode 100644
index 0000000..1a60f27
@@ -0,0 +1,23 @@
+/*
+ * Copyright (C) 2012 Samsung Electronics Co.Ltd
+ *		http://www.samsung.com
+ *
+ * EXYNOS - USB HOST register definitions
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef __REGS_USB_HOST_H
+#define __REGS_USB_HOST_H __FILE__
+
+#define EHCI_INSNREG00(base)		(base + 0x90)
+#define EHCI_ENA_INCR16			(0x1 << 25)
+#define EHCI_ENA_INCR8			(0x1 << 24)
+#define EHCI_ENA_INCR4			(0x1 << 23)
+#define EHCI_ENA_INCRX_ALIGN		(0x1 << 22)
+#define EHCI_ENABLE_DMA_INCR		(EHCI_ENA_INCR16 | EHCI_ENA_INCR8| \
+					 EHCI_ENA_INCR4 | EHCI_ENA_INCRX_ALIGN)
+
+#endif /* __REGS_USB_HOST_H */

Signature · 1 line

1.7.1

Tushar Behera

2012-03-01 03:30 UTC #1 lore raw

PATCH 1/2 ARM: EXYNOS: Add USB HOST register definitions

Quoted 28 lines · Jingoo Han

This patch adds USB HOST register definitions. The definition for EHCI INSNREG00 regiser and corresponding bit field definitions are added.

Signed-off-by Jingoo Han <[email protected]>

---
 arch/arm/mach-exynos/include/mach/regs-usb-host.h |   23 +++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-exynos/include/mach/regs-usb-host.h

arch/arm/mach-exynos/include/mach/regs-usb-host.h new file +12 -0

new file mode 100644
index 0000000..1a60f27
@@ -0,0 +1,23 @@
+/*
+ * Copyright (C) 2012 Samsung Electronics Co.Ltd
+ *		http://www.samsung.com
+ *
+ * EXYNOS - USB HOST register definitions
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef __REGS_USB_HOST_H

arch/arm/mach-exynos/include/mach/regs-usb-host.h line 22

Quoted 10 lines

arch/arm/mach-exynos/include/mach/regs-usb-host.h new file +10 -0

+#define __REGS_USB_HOST_H __FILE__
+
+#define EHCI_INSNREG00(base)		(base + 0x90)
+#define EHCI_ENA_INCR16			(0x1 << 25)
+#define EHCI_ENA_INCR8			(0x1 << 24)
+#define EHCI_ENA_INCR4			(0x1 << 23)
+#define EHCI_ENA_INCRX_ALIGN		(0x1 << 22)
+#define EHCI_ENABLE_DMA_INCR		(EHCI_ENA_INCR16 | EHCI_ENA_INCR8| \
+					 EHCI_ENA_INCR4 | EHCI_ENA_INCRX_ALIGN)
+

As per the definition of bit-fields in other registers, it would be good to prepend the complete register name before the bit-field defines.

EHCI_INSNREG00_ENA_INCR16 ...

Considering the similarity of this patchset with the earlier patchset from Sangwook, IMO, it would be appropriate to give him due credit in both these patches.

Quoted 1 line

arch/arm/mach-exynos/include/mach/regs-usb-host.h new file +1 -0
+#endif /* __REGS_USB_HOST_H */

Signature · 1 line

Tushar Behera

Jingoo Han

author

2012-03-01 05:15 UTC #2 lore raw

PATCH 1/2 ARM: EXYNOS: Add USB HOST register definitions

Quoted 54 lines

-----Original Message-----
From: Tushar Behera [mailto:tushar.behera at linaro.org]
Sent: Thursday, March 01, 2012 12:30 PM
To: Jingoo Han
Cc: linux-usb at vger.kernel.org; 'Greg Kroah-Hartman'; linux-samsung-soc at vger.kernel.org; linux-arm- kernel at lists.infradead.org; 'Sangwook Lee'; 'Alan Stern'; 'Joonyoung Shim'; 'Kukjin Kim'; patches at linaro.org; linaro-dev at lists.linaro.org; 'Thomas Abraham'
Subject: Re: [PATCH 1/2] ARM: EXYNOS: Add USB HOST register definitions
arch/arm/mach-
Quoted 11 lines · Jingoo Han
This patch adds USB HOST register definitions. The definition for EHCI INSNREG00 regiser and corresponding bit field definitions are added.
Signed-off-by Jingoo Han <[email protected]>
---
 arch/arm/mach-exynos/include/mach/regs-usb-host.h |   23 +++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-exynos/include/mach/regs-usb-host.h
arch/arm/mach- renamed from arch/arm/mach-exynos/include/mach/regs-usb-host.h +0 -0
exynos/include/mach/regs-usb-host.h
Quoted 17 lines
new file mode 100644
index 0000000..1a60f27
arch/arm/mach-exynos/include/mach/regs-usb-host.h new file +12 -0
@@ -0,0 +1,23 @@
+/*
+ * Copyright (C) 2012 Samsung Electronics Co.Ltd
+ *		http://www.samsung.com
+ *
+ * EXYNOS - USB HOST register definitions
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef __REGS_USB_HOST_H
arch/arm/mach-exynos/include/mach/regs-usb-host.h line 22
Quoted 10 lines
arch/arm/mach-exynos/include/mach/regs-usb-host.h new file +10 -0
+#define __REGS_USB_HOST_H __FILE__
+
+#define EHCI_INSNREG00(base)		(base + 0x90)
+#define EHCI_ENA_INCR16			(0x1 << 25)
+#define EHCI_ENA_INCR8			(0x1 << 24)
+#define EHCI_ENA_INCR4			(0x1 << 23)
+#define EHCI_ENA_INCRX_ALIGN		(0x1 << 22)
+#define EHCI_ENABLE_DMA_INCR		(EHCI_ENA_INCR16 | EHCI_ENA_INCR8| \
+					 EHCI_ENA_INCR4 | EHCI_ENA_INCRX_ALIGN)
+
As per the definition of bit-fields in other registers, it would be good to prepend the complete register name before the bit-field defines.

Quoted 1 line

EHCI_INSNREG00_ENA_INCR16 ...

OK, I will change the definitions from EHCI_ENA_xxx to EHCI_INSNREG00_ENA_xxx.

Quoted 4 lines

Considering the similarity of this patchset with the earlier patchset from Sangwook, IMO, it would be appropriate to give him due credit in both these patches.

OK, I will give Sangwook Signed-off.

Quoted 5 lines

Quoted 1 line
Quoted 1 line
+#endif /* __REGS_USB_HOST_H */
--
Tushar Behera