libethumb: Fix automagic dependencies on libedbus and libexif
PATCH 1/1 libethumb: Fix automagic dependencies on libedbus and libexif
Hi,
Please review the attached patch. It fixes the libexif and libedbus automagic dependencies for libethumb
Signature · 5 lines
markos -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: 0001-libethumb-Fix-automagic-dependencies-on-libedbus-and.patch URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120305/c8be8a65/attachment.ksh>
PATCH 1/1 libethumb: Fix automagic dependencies on libedbus and libexif
From: Markos Chandras <[email protected]>
libethumb will determine during configuration phase whether to build the optional libexif and libedbus modules. It will enable this modules if libedbus or libexif are present on the target system. Therefore, we need to add these packages as optional dependencies to libethumb.
---
Arnout: Resending as in-line patch for easy review.
--- package/efl/libethumb/libethumb.mk | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
package/efl/libethumb/libethumb.mk +8 -0
@@ -13,4 +13,12 @@ LIBETHUMB_DEPENDENCIES = libeina libevas libecore libedje host-libedje LIBETHUMB_CONF_OPT = --with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc +ifeq ($(BR2_PACKAGE_LIBEXIF),y) +LIBETHUMB_DEPENDENCIES += libexif +endif + +ifeq ($(BR2_PACKAGE_LIBEDBUS),y) +LIBETHUMB_DEPENDENCIES += libedbus +endif + $(eval $(call AUTOTARGETS))
Signature · 1 line
1.7.9.1
PATCH 1/1 libethumb: Fix automagic dependencies on libedbus and libexif
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:
Arnout> From: Markos Chandras <[email protected]>
Arnout> libethumb will determine during configuration phase whether to Arnout> build the optional libexif and libedbus modules. It will enable Arnout> this modules if libedbus or libexif are present on the target Arnout> system. Therefore, we need to add these packages as optional Arnout> dependencies to libethumb.
Arnout> Signed-off-by: Markos Chandras <[email protected]> Arnout> ---
Arnout> Arnout: Resending as in-line patch for easy review. Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Committed, thanks - But your signed-off-by should go before the '---'
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 libethumb: Fix automagic dependencies on libedbus and libexif
Quoted 10 lines · On Tuesday 13 March 2012 13:12:41 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:
Arnout> From: Markos Chandras <[email protected]>
Arnout> libethumb will determine during configuration phase whether to Arnout> build the optional libexif and libedbus modules. It will enable Arnout> this modules if libedbus or libexif are present on the target Arnout> system. Therefore, we need to add these packages as optional Arnout> dependencies to libethumb.
Quoted 6 lines
Arnout> Signed-off-by: Markos Chandras <[email protected]> Arnout> ---
Arnout> Arnout: Resending as in-line patch for easy review. Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]>Committed, thanks - But your signed-off-by should go before the '---'
The sign-off was an accident (git send-email -s habit). Since it's
purely a resend without any modification, I didn't feel it warranted my signoff line. DCO isn't entirely clear on this, if you ask me.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F