GFS2: Add gfs2_lockgather script and man page

This is a backport of the gfs2_lockgather script and manpage from gfs2_utils upstream. This tool makes it easier to gather data on GFS2 hangs and performance issues rooted in locking overhead.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gfs2_lockgather.patch
Type: application/octet-stream
Size: 8316 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20120305/2dc80400/attachment.obj>
-------------- next part --------------

Hi,

Looks good to me,

Steve.

I have to NACK this backport for now.

I already explain to Adam what needs changing.

Fabio

Hi,

What is the issue?

Steve.

There are different ones.

The script is GPLv3 and we can't pull it in cluster.git (GPLv2+) without some re-licensing work.

Some parts of the script make use of /tmp in unsafe way that can cause security problems (mostly DoS in this case).

Execution of some cluster commands is not safe. If the cluster is hanging and you want to use this tool to gather data, the script won't work because it will hang as well, creating extra load on the cluster.

The script needs to handle shell errors correctly and AFAICT it doesn't. Basically it can give the impression to run correctly without collecting data (missing set -e or error handling per call).

(minor) the backport patch needs fixing for the Makefile or it will fail to build/install.

Fabio

Forgot to mention in the previous email:

since this is a long time (tar/ssh/scp..) running script, it needs to handle trap of signals and locking differently or if a user hits ctrl+c or the script is killed for whatever reason, it doesn't clean after itself. Leaking disk space and leaving the lock file around that would block the next run.

I didn't check all the paths it uses, but an update to selinux policies might be necessary too.

Fabio