mmc: sdhci-s3c: use the sdhci-pltfm.c and move the header file
Subsystems (2)
v3 cover mmc: sdhci-s3c: use the sdhci-pltfm.c and move the header file
This patchset is the purpose for using sdhci-pltfm.c and
removing the arch dependency.
The sdhci-s3c has too heavy arch dependency.
For example, if work for sdhci-s3c.c at mmc-tree, sometime need to change sdhci.h for Samsung-Soc. But now we need to work at both mmc-next tree and Samsung-SoC tree.
I think this is very inefficient and can conflict to merge.
So remained at least dependency and moved the header file to mmc folder.
And sdhci-s3c changed to use the sdhci-pltfm.c.
There is no reason that didn't use the sdhci-pltfm.c.
If we use the sdhci-pltfm.c,we can easily maintain the common part.
In future, i will work more removing the arch dependency.
This patchset based on mmc-next tree.
Changelog v3:
- Modify mmc/host/Makefile for sdhci-s3c.c
- remove unnecessary code
Changelog V2:
- modified driver/mmc/host/Kconfig
- Add the comments for s3c64xx
- based-on latest mmc-tree.
Jaehoon Chung (4):
mmc: sdhci-s3c: use the sdhci-pltfm for Samsung-SoC
ARM: SAMSUNG: move the sdhci header file to driver directory
mmc: sdhci-s3c: use the sdhci-s3c.h instead of regs-sdhci.h
ARM: SAMSUNG: move the mmc platdata header file into linux/mmc/
arch/arm/mach-exynos/setup-sdhci-gpio.c | 1 - arch/arm/mach-s5pc100/setup-sdhci-gpio.c | 1 - arch/arm/mach-s5pv210/setup-sdhci-gpio.c | 1 - arch/arm/plat-samsung/include/plat/regs-sdhci.h | 87 -------- arch/arm/plat-samsung/include/plat/sdhci.h | 53 +----- drivers/mmc/host/Kconfig | 20 +- drivers/mmc/host/Makefile | 2 +- drivers/mmc/host/sdhci-s3c.c | 265 ++++++++--------------- drivers/mmc/host/sdhci-s3c.h | 89 ++++++++ include/linux/mmc/sdhci-s3c.h | 84 +++++++ 10 files changed, 273 insertions(+), 330 deletions(-) delete mode 100644 arch/arm/plat-samsung/include/plat/regs-sdhci.h create mode 100644 drivers/mmc/host/sdhci-s3c.h create mode 100644 include/linux/mmc/sdhci-s3c.h
Quoted 4 lines · Jaehoon Chung
This patchset is the purpose for using
sdhci-pltfm.cand
removing the arch dependency.
The sdhci-s3c has too heavy arch dependency.
For example, if work forsdhci-s3c.cat mmc-tree, sometime need to changesdhci.hfor Samsung-Soc.
This series will break S3C64xx, you've not touched it at all in the update but it uses the same SDHCI controller.
Am Dienstag, 6. März 2012, 14:00:54 schrieb Mark Brown:
Quoted 9 lines · Jaehoon Chung
Quoted 5 lines
This patchset is the purpose for using
sdhci-pltfm.cand removing the arch dependency.
The sdhci-s3c has too heavy arch dependency.
For example, if work forsdhci-s3c.cat mmc-tree, sometime need to changesdhci.hfor Samsung-Soc.This series will break S3C64xx, you've not touched it at all in the update but it uses the same SDHCI controller.
This problem will probably also surface for the S3C2416 which also uses the same SDHCI controller.
Heiko
2012/3/6 Heiko Stübner <[email protected]>:
Quoted 8 lines
Am Dienstag, 6. März 2012, 14:00:54 schrieb Mark Brown:
Quoted 7 lines · Jaehoon Chung
Quoted 5 lines
This patchset is the purpose for using
sdhci-pltfm.cand removing the arch dependency.
The sdhci-s3c has too heavy arch dependency.
For example, if work forsdhci-s3c.cat mmc-tree, sometime need to changesdhci.hfor Samsung-Soc.
Quoted 5 lines
Quoted 2 lines
This series will break S3C64xx, you've not touched it at all in the update but it uses the same SDHCI controller.
This problem will probably also surface for the S3C2416 which also uses the same SDHCI controller.
i didn't know why will break on them. Could you explain to me? Are there codes which affect S3C64XX and S3C24XX?
If i miss out something, let me know.
Best Regards,
Jaehoon Chung
Quoted 6 lines
Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 6 lines · Jae hoon Chung
2012/3/6 Heiko Stübner <[email protected]>:
Quoted 4 lines
Am Dienstag, 6. März 2012, 14:00:54 schrieb Mark Brown:
Quoted 2 lines
This series will break S3C64xx, you've not touched it at all in the update but it uses the same SDHCI controller.
Quoted 6 lines
Quoted 2 lines
This problem will probably also surface for the S3C2416 which also uses the same SDHCI controller.
i didn't know why will break on them. Could you explain to me? Are there codes which affect S3C64XX and S3C24XX?
If i miss out something, let me know.
The same IP is present and used with the same driver on other Samsung SoCs.
Quoted 10 lines · Mark Brown
Quoted 8 lines · Jae hoon Chung
2012/3/6 Heiko Stübner <[email protected]>:
Quoted 7 lines
Am Dienstag, 6. März 2012, 14:00:54 schrieb Mark Brown:
Quoted 2 lines
This series will break S3C64xx, you've not touched it at all in the update but it uses the same SDHCI controller.
This problem will probably also surface for the S3C2416 which also uses the same SDHCI controller.
Quoted 6 lines
Quoted 3 lines
i didn't know why will break on them. Could you explain to me? Are there codes which affect S3C64XX and S3C24XX?
If i miss out something, let me know.The same IP is present and used with the same driver on other Samsung SoCs.
Hi Mark.
I know that used with the same driver on other Samsung-SoCs(S3C64XX/S3C24XX..etc) I just only used the interface in sdhci-pltfm.c. Nothing difference.. Why do you think that will break the other SoC?
Header file(/plat/regs-sdhci.h) also is only used in sdhci-s3c.c. And the least portion is moved into /linux/mmc/.
Then included "linux/mmc/sdhci-s3c.h" in plat/sdhci.h.
What's difference?
If you can explain the more detail, i can understand. But sorry, now i didn't accept your opinion.
Best Regards,
Jaehoon Chung
Quoted 9 lines · Jaehoon Chung
Quoted 2 lines · Mark Brown
The same IP is present and used with the same driver on other Samsung SoCs.
I know that used with the same driver on other Samsung-SoCs(S3C64XX/S3C24XX..etc) I just only used the interface in
sdhci-pltfm.c. Nothing difference.. Why do you think that will break the other SoC?
Quoted 7 lines
Header file(/plat/regs-sdhci.h) also is only used in
sdhci-s3c.c. And the least portion is moved into /linux/mmc/.
Then included "linux/mmc/sdhci-s3c.h" inplat/sdhci.h.What's difference?
If you can explain the more detail, i can understand. But sorry, now i didn't accept your opinion.
To be honest I didn't read the series, the diffstat looks so obviously problematic as you're touching the setup-gpio- files for only a subset of Samsung architectures - there's been quite regular issues with updates for newer SoCs breaking support for s3c64xx.
I also notice that this will conflict with the series I've previously posted for runtime PM support which would push us even further back from being able to use the lower power WFI modes in mainline :( Though hopefully that'll be easier to fix.
Hi Mark.
Quoted 14 lines · Mark Brown
Quoted 12 lines · Jaehoon Chung
Quoted 2 lines · Mark Brown
The same IP is present and used with the same driver on other Samsung SoCs.
I know that used with the same driver on other Samsung-SoCs(S3C64XX/S3C24XX..etc) I just only used the interface in
sdhci-pltfm.c. Nothing difference.. Why do you think that will break the other SoC?Header file(/plat/regs-sdhci.h) also is only used in
sdhci-s3c.c. And the least portion is moved into /linux/mmc/.
Then included "linux/mmc/sdhci-s3c.h" inplat/sdhci.h.
Quoted 8 lines
Quoted 3 lines
What's difference?
If you can explain the more detail, i can understand. But sorry, now i didn't accept your opinion.To be honest I didn't read the series, the diffstat looks so obviously problematic as you're touching the setup-gpio- files for only a subset of Samsung architectures - there's been quite regular issues with updates for newer SoCs breaking support for s3c64xx.
Is there problem that move the s3c_sdhci_platdata struct into linux/mmc/? In setup-gpio- files, you can see that included regs-sdhci.h.
But defined macro in regs-sdhci.h only used in sdhci-s3c.c.
So i think no problem that removed "#include <plat/regs-sdhci.h>". is it wrong? Just touching the setup-gpio- files is problem?
If i have moved the defined as "extern", it's problem.
But i didn't move them.
For example, When i want to add the second capability for sdhci-s3c, need to change code in samsung-soc and mmc stack.
if one of both didn't be merged, it's conflict or should not be work fine. (Now, in mmc-next tree, mmc for Samsung-SoC didn't work fine during long time.) There are reason that move the s3c_sdhci_platdata into linux/mmc/. Then we can work at only mmc-next repository for sdhci-s3c.c.
Quoted 5 lines
I also notice that this will conflict with the series I've previously posted for runtime PM support which would push us even further back from being able to use the lower power WFI modes in mainline :( Though hopefully that'll be easier to fix.
Right, it should be conflicted with your patch. but it will be fixed. It's not big problem.
Thanks for your opinion.
Best Regards,
Jaehoon Chung
Quoted 2 lines · Jaehoon Chung
So i think no problem that removed "#include <
plat/regs-sdhci.h>". is it wrong? Just touching the setup-gpio- files is problem?
It should be fine, like I say I didn't really read the patches in enough detail as the diffstat set off alarm bells.
Quoted 7 lines · Mark Brown
Quoted 2 lines · Jaehoon Chung
So i think no problem that removed "#include <
plat/regs-sdhci.h>". is it wrong? Just touching the setup-gpio- files is problem?It should be fine, like I say I didn't really read the patches in enough detail as the diffstat set off alarm bells.
If you have any opinions, let me know.
I believe that these patches can be maintain more efficiently for eMMC
Best Regards,
Jaehoon Chung
Quoted 7 lines · Jaehoon Chung
Quoted 2 lines · Mark Brown
It should be fine, like I say I didn't really read the patches in enough detail as the diffstat set off alarm bells.
If you have any opinions, let me know.
I believe that these patches can be maintain more efficiently for eMMC
Like I said I think it's fine. If it helps: