Skip to contentSkip to conversation

mmc: sh_mmcif: fix MMC_GEN_CMD setting

PATCH RESEND In review Shimoda, Yoshihiro 2 participants 2 messages Mar 7, 2012 – Mar 9, 2012

Subsystems (2)
MMC, SD and SDIO SuperH
lore
Share & tools
lore

Shimoda, Yoshihiro

author
#0 lore raw

PATCH RESEND 1/1 mmc: sh_mmcif: fix MMC_GEN_CMD setting

The MMC_GEN_CMD (CMD56) doesn't need to check busy signal. So, the patch fixes the setting.

Signed-off-by Yoshihiro Shimoda <[email protected]>
---
 drivers/mmc/host/sh_mmcif.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/sh_mmcif.c +0 -2
index 4a2c5b2..e8b70e3 100644
@@ -745,7 +745,6 @@ static u32 sh_mmcif_set_cmd(struct sh_mmcif_host *host,
 	case MMC_SET_WRITE_PROT:
 	case MMC_CLR_WRITE_PROT:
 	case MMC_ERASE:
-	case MMC_GEN_CMD:
 		tmp |= CMD_SET_RBSY;
 		break;
 	}

@@ -828,7 +827,6 @@ static void sh_mmcif_start_cmd(struct sh_mmcif_host *host,
 	case MMC_SET_WRITE_PROT:
 	case MMC_CLR_WRITE_PROT:
 	case MMC_ERASE:
-	case MMC_GEN_CMD:
 		mask = MASK_START_CMD | MASK_MRBSYE;
 		break;
 	default:
Signature · 1 line
1.7.1
#1 lore raw

Hi,

Quoted 21 lines · Yoshihiro

The MMC_GEN_CMD (CMD56) doesn't need to check busy signal. So, the patch fixes the setting.

Signed-off-by Yoshihiro Shimoda <[email protected]>
---
 drivers/mmc/host/sh_mmcif.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/sh_mmcif.c +0 -1
index 4a2c5b2..e8b70e3 100644
@@ -745,7 +745,6 @@ static u32 sh_mmcif_set_cmd(struct sh_mmcif_host *host,
 	case MMC_SET_WRITE_PROT:
 	case MMC_CLR_WRITE_PROT:
 	case MMC_ERASE:
-	case MMC_GEN_CMD:
 		tmp |= CMD_SET_RBSY;
 		break;
 	}

drivers/mmc/host/sh_mmcif.c static void sh_mmcif_start_cmd(struct sh_mmcif_host *host, · line 832

Quoted 7 lines
drivers/mmc/host/sh_mmcif.c +0 -1
@@ -828,7 +827,6 @@ static void sh_mmcif_start_cmd(struct sh_mmcif_host *host,
 	case MMC_SET_WRITE_PROT:
 	case MMC_CLR_WRITE_PROT:
 	case MMC_ERASE:
-	case MMC_GEN_CMD:
 		mask = MASK_START_CMD | MASK_MRBSYE;
 		break;
 	default:

Thanks, pushed to mmc-next for 3.4.

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child