Skip to contentSkip to conversation

iMX53 and MMC_CAP_SDIO_IRQ

DISCUSSION Michael Hunold 2 participants 4 messages Mar 12, 2012 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

Hi,

I am using a Freescale iMX53 Quick Start Board. The uSD card that comes with the device contains a Linux kernel labeled "Linux version 2.6.35.3-01129-g691c08a-dirty".

After some digging I found out that this corresponds to the "imx_2.6.35_11.09.01" tag in the Freescale Linux kernel that can be found at http://opensource.freescale.com/pub/scm/imx/linux-2.6-imx.git

I am experimenting with an SDIO card and that one works fine using that kernel. So far, so good.

Now I have tried to use a vanilla Git Linux kernel (3.3.0-rc6+) with mixed results.

The card is recognised correctly and mostly initialised, up to the point where an apparently an interrupt from the card is expected to happen. Because the SDHCI driver supports "real" interrupts (via MMC_CAP_SDIO_IRQ) the SDIO IRQ thread goes to sleep, but is never woken up in my case.

After about 2.5 seconds, I receive an error -110 (timeout) and the initialisation is aborted.

So my question is: is anybody using an iMX53 (or any other hardware using the SDHCI driver) together with "real" interrupts (via MMC_CAP_SDIO_IRQ), not polled interrupts?

The main problem is that the ancient Freescale 2.6.35 kernel is using the "mx_sdhci" driver, while in 3.3.0-rc6+ the generic "sdhci" driver is used, so it's not possible to simply compare the changes between the two versions. :-(

Does anybody know the difference between the "mx_sdhci" from Freescale 2.6.35 kernel and the the "sdhci" driver in 3.3.0-rc6+?

Probably this is a question for the Freescale people: why was the "mx_sdhci" necessary at all and why is it not necessary any more?

Any help, hints and historical informations are highly appreciated, before I start to look deeper into this problem.

CU
Michael.

#1 lore raw

Hi,

Quoted 4 lines

The main problem is that the ancient Freescale 2.6.35 kernel is using the "mx_sdhci" driver, while in 3.3.0-rc6+ the generic "sdhci" driver is used, so it's not possible to simply compare the changes between the two versions. :-(

Not via diff, but the structure of both drivers should still be somewhat similar.

Quoted 2 lines

Probably this is a question for the Freescale people: why was the "mx_sdhci" necessary at all

It probably was never necessary, it was just easier to hack on a forked driver, because you can't break other sdhci-users, I guess. Since large portions of the code are duplicated but issues have been fixed in a very, ahem, custom manner, this was never suitable for mainline. Back then, most vendors thought this is good enough. Luckily, times have changed a bit.

Quoted 1 line

and why is it not necessary any more?

Because I wanted SD support in mainline, so I had to take a different path.

Quoted 2 lines

Any help, hints and historical informations are highly appreciated, before I start to look deeper into this problem.

They don't have a common ancestor. Just dig into both, you will recognize patterns, I guess.

Regards,

Wolfram

Signature · 9 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120312/a3c71675/attachment-0001.sig>
#2 lore raw

Hello Wolfram,

thank you for your answer.

on 12.03.2012 11:10 Wolfram Sang said the following:

Quoted 9 lines
Quoted 2 lines

Probably this is a question for the Freescale people: why was the "mx_sdhci" necessary at all

It probably was never necessary, it was just easier to hack on a forked driver, because you can't break other sdhci-users, I guess. Since large portions of the code are duplicated but issues have been fixed in a very, ahem, custom manner, this was never suitable for mainline. Back then, most vendors thought this is good enough. Luckily, times have changed a bit.

Yes, I know that thinking.

Quoted 4 lines
Quoted 1 line

and why is it not necessary any more?

Because I wanted SD support in mainline, so I had to take a different path.

I understand.

Quoted 5 lines
Quoted 2 lines

Any help, hints and historical informations are highly appreciated, before I start to look deeper into this problem.

They don't have a common ancestor. Just dig into both, you will recognize patterns, I guess.

Ok, to sum this up:

SDIO IRQs are working in mx_sdhci in the Freescale tree because it was properly implemented and tested, obviously.

SDIO IRQs are working for sdhci in mainline probably for other non-freescale platforms.

You fixed the generic sdhci driver in mainline to work with iMX53 to get rid of the need for mx_sdhci, but probably never got the chance to test if SDIO IRQs are really working.

That means, the subtle difference between mx_sdhci and sdhci to get SDIO IRQS to work on sdhci with iMX53 has yet to be found.

Quoted 2 lines

Regards,
Wolfram

CU
Michael.

#3 lore raw
Quoted 5 lines

Ok, to sum this up:

SDIO IRQs are working in mx_sdhci in the Freescale tree because it was properly implemented and tested, obviously.

Not sure about "properly", but, yes ;)

Quoted 2 lines

SDIO IRQs are working for sdhci in mainline probably for other non-freescale platforms.

Probably, but I can't say 'yes' for sure. You'd need to find out.

Quoted 3 lines

You fixed the generic sdhci driver in mainline to work with iMX53 to get rid of the need for mx_sdhci, but probably never got the chance to test if SDIO IRQs are really working.

I worked mainly with MX25/35 back then, and a little bit with MX51. IIRC I only had an SDIO card for which no Linux drivers were available, so I only could test that the card was detected :(

Quoted 2 lines

That means, the subtle difference between mx_sdhci and sdhci to get SDIO IRQS to work on sdhci with iMX53 has yet to be found.

Yup. Try 'git log --follow sdhci-esdhc-imx.c' to find people who worked with MX53 or SDIO using that driver.

Regards,

Wolfram

Signature · 9 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120312/fa9e24dc/attachment-0001.sig>