Skip to contentSkip to conversation

readlink03: fix expected errno for kernel >=3.2

PATCH In review Jan Stancek 3 participants 5 messages Mar 14, 2012

lore
Share & tools
lore

Jan Stancek

author
#0 lore raw

PATCH 1/1 readlink03: fix expected errno for kernel >=3.2

This kernel commit restored original behavior:
commit 1fa1e7f615f4d3ae436fa319af6e4eebdd4026a8

Author: Andy Whitcroft <[email protected]>
Date:   Wed Nov 2 09:44:39 2011 +0100

readlinkat: ensure we return ENOENT for the empty pathname for
normal lookups

For kernel >= 3.2, ENOENT should be expected errno code.

Signed-off-by Jan Stancek <[email protected]>
---
 testcases/kernel/syscalls/readlink/readlink03.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
testcases/kernel/syscalls/readlink/readlink03.c +2 -1
index 370bf7d..85141f9 100644
@@ -174,7 +174,8 @@ int main(int ac, char **av)
 			}
 
 			if (strncmp(test_desc, "Symlink Pathname is empty", 25) == 0) {
-				if ((tst_kvercmp(2, 6, 39)) >= 0)
+				if (tst_kvercmp(2, 6, 39) >= 0
+					&& tst_kvercmp(3, 2, 0) < 0)
 					Test_cases[i].exp_errno = EINVAL;
 			}

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Jan Stancek

This kernel commit restored original behavior:
commit 1fa1e7f615f4d3ae436fa319af6e4eebdd4026a8

Author: Andy Whitcroft <[email protected]>
Date:   Wed Nov 2 09:44:39 2011 +0100

readlinkat: ensure we return ENOENT for the empty pathname for
normal lookups

For kernel >= 3.2, ENOENT should be expected errno code.

Signed-off-by Jan Stancek <[email protected]>

looks good to me.

Reviewed-by Caspar Zhang <[email protected]>

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw
In reply to Jan Stancek

Hi Jan,

Quoted 9 lines

This kernel commit restored original behavior:
commit 1fa1e7f615f4d3ae436fa319af6e4eebdd4026a8

Author: Andy Whitcroft <[email protected]>
Date:   Wed Nov 2 09:44:39 2011 +0100

readlinkat: ensure we return ENOENT for the empty pathname for
normal lookups

For kernel >= 3.2, ENOENT should be expected errno code.

I had posted a patch long time ago, you can see here
http://marc.info/?l=ltp-list&m=132063831228321&w=2

This is a kernel bug, and already fixed in 3.0 and 3.1 stable tree, so, just test the kernel version like this is not the best method.

What do you think?

Thanks,
Wanlong Gao

Quoted 18 lines
Signed-off-by Jan Stancek <[email protected]>
---
 testcases/kernel/syscalls/readlink/readlink03.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/

Quoted 4 lines

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#3 lore raw

----- Original Message -----

Quoted 19 lines

From: "Wanlong Gao" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected], "Jeffrey Burke" <[email protected]>
Sent: Wednesday, March 14, 2012 1:50:56 PM
Subject: Re: [LTP] [PATCH] readlink03: fix expected errno for kernel >=3.2

Hi Jan,

Quoted 9 lines

This kernel commit restored original behavior:
commit 1fa1e7f615f4d3ae436fa319af6e4eebdd4026a8

Author: Andy Whitcroft <[email protected]>
Date:   Wed Nov 2 09:44:39 2011 +0100

readlinkat: ensure we return ENOENT for the empty pathname for
normal lookups

For kernel >= 3.2, ENOENT should be expected errno code.

Quoted 8 lines

I had posted a patch long time ago, you can see here
http://marc.info/?l=ltp-list&m=132063831228321&w=2

This is a kernel bug, and already fixed in 3.0 and 3.1 stable tree, so, just test the kernel version like this is not the best method.

What do you think?

Agreed, version check doesn't make much sense.

I think if this patch was important enough to be backported to stable trees, we can be sure it's a bug and we can drop that version check entirely - which is what your patch does.

Regards,
Jan

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#4 lore raw
Quoted 29 lines · Jan Stancek

----- Original Message -----

Quoted 26 lines

From: "Wanlong Gao" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected], "Jeffrey Burke" <[email protected]>
Sent: Wednesday, March 14, 2012 1:50:56 PM
Subject: Re: [LTP] [PATCH] readlink03: fix expected errno for kernel >=3.2

Hi Jan,

Quoted 9 lines

This kernel commit restored original behavior:
commit 1fa1e7f615f4d3ae436fa319af6e4eebdd4026a8

Author: Andy Whitcroft <[email protected]>
Date:   Wed Nov 2 09:44:39 2011 +0100

readlinkat: ensure we return ENOENT for the empty pathname for
normal lookups

For kernel >= 3.2, ENOENT should be expected errno code.

I had posted a patch long time ago, you can see here
http://marc.info/?l=ltp-list&m=132063831228321&w=2

This is a kernel bug, and already fixed in 3.0 and 3.1 stable tree, so, just test the kernel version like this is not the best method.

Quoted 7 lines
Quoted 1 line

What do you think?

Agreed, version check doesn't make much sense.

I think if this patch was important enough to be backported to stable trees, we can be sure it's a bug and we can drop that version check entirely - which is what your patch does.

Yeah, so let me resend it with your Ack.

Thanks,
Wanlong Gao

Quoted 5 lines

Regards,
Jan

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list