Andreas Oberritter : qt4: fix deps in libQtWebkit.la and QtWebKit.pc

oe-commits Martin Jansa 3 participants 8 messages Mar 14, 2012 – Apr 30, 2012 1 message not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): 20120313114820.9572210335@opal

Martin Jansa

author

2012-03-14 07:16 UTC #1 lore raw

Quoted 8 lines · On Tue, Mar 13, 2012 at 11:48:20AM +0000, [email protected] wrote:

Module: openembedded-core.git
Branch: master
Commit: 4c41a3204ef72f53813ddc86fe525fa9c6714daa
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=4c41a3204ef72f53813ddc86fe525fa9c6714daa

Author: Andreas Oberritter <[email protected]>
Date:   Wed Mar  7 21:36:28 2012 +0100

Quoted 7 lines

qt4: fix deps in libQtWebkit.la and QtWebKit.pc
* Both files contain -L../../WebCore/release -L../../JavaScriptCore/release -lwebcore -ljscore
* These paths and libs don't get installed.
* When building a shared lib with libtool, that links
with libQtWebKit, libtool adds these unneeded parameters
to the linker command-line, thus linking fails.

BTW: here with bitbake having R/W to rootfs every qt4-x11-free build creates /include/WebCore/libdummy.prl (yes really in root) anynone seen this?
-rw-r--r-- 1 bitbake bitbake 680 Mar 14 01:13 /include/WebCore/libdummy.prl

Maybe it's sign of another small issue in qt4 build.

Cheers,

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Martin Jansa

author

2012-03-14 08:49 UTC #2 lore raw

Quoted 17 lines · Martin Jansa

Quoted 8 lines · On Tue, Mar 13, 2012 at 11:48:20AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 4c41a3204ef72f53813ddc86fe525fa9c6714daa
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=4c41a3204ef72f53813ddc86fe525fa9c6714daa
Author: Andreas Oberritter <[email protected]>
Date:   Wed Mar  7 21:36:28 2012 +0100
Quoted 7 lines
qt4: fix deps in libQtWebkit.la and QtWebKit.pc
* Both files contain -L../../WebCore/release -L../../JavaScriptCore/release -lwebcore -ljscore
* These paths and libs don't get installed.
* When building a shared lib with libtool, that links
with libQtWebKit, libtool adds these unneeded parameters
to the linker command-line, thus linking fails.

Quoted 6 lines

BTW: here with bitbake having R/W to rootfs every qt4-x11-free build creates /include/WebCore/libdummy.prl (yes really in root) anynone seen this?
-rw-r--r-- 1 bitbake bitbake 680 Mar 14 01:13 /include/WebCore/libdummy.prl
Maybe it's sign of another small issue in qt4 build.

It's created during do_configure and probably caused by ./qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/WebKit2/Makefile:all: Makefile /include/WebCore/libdummy.prl /include/WebCore/$(TARGET) ./qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/WebKit2/Makefile:/include/WebCore/libdummy.prl:

But in unpacked sources closest thing to libdummy.prl is ./Source/WebKit2/DerivedSources.pro:TARGET = dummy

Any idea if we really need that?

Cheers,

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Andreas Oberritter

2012-03-14 13:57 UTC #3 lore raw

Quoted 18 lines · Martin Jansa

Quoted 17 lines · Martin Jansa
Quoted 15 lines · On Tue, Mar 13, 2012 at 11:48:20AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 4c41a3204ef72f53813ddc86fe525fa9c6714daa
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=4c41a3204ef72f53813ddc86fe525fa9c6714daa
Author: Andreas Oberritter <[email protected]>
Date:   Wed Mar  7 21:36:28 2012 +0100
qt4: fix deps in libQtWebkit.la and QtWebKit.pc
* Both files contain -L../../WebCore/release -L../../JavaScriptCore/release -lwebcore -ljscore
* These paths and libs don't get installed.
* When building a shared lib with libtool, that links
with libQtWebKit, libtool adds these unneeded parameters
to the linker command-line, thus linking fails.

Quoted 4 lines

Quoted 4 lines
BTW: here with bitbake having R/W to rootfs every qt4-x11-free build creates /include/WebCore/libdummy.prl (yes really in root) anynone seen this?
-rw-r--r-- 1 bitbake bitbake 680 Mar 14 01:13 /include/WebCore/libdummy.prl

I'm only using qt4-embedded, with which I haven't noticed this file.

Quoted 8 lines

Quoted 1 line
Maybe it's sign of another small issue in qt4 build.
It's created during do_configure and probably caused by ./qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/WebKit2/Makefile:all: Makefile /include/WebCore/libdummy.prl /include/WebCore/$(TARGET) ./qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/WebKit2/Makefile:/include/WebCore/libdummy.prl:
But in unpacked sources closest thing to libdummy.prl is ./Source/WebKit2/DerivedSources.pro:TARGET = dummy

I thought that Qt 4.8 didn't use WebKit2 by default. Did you enable it manually?

Regards,
Andreas

Paul Eggleton

2012-03-14 14:11 UTC #4 lore raw

Quoted 2 lines · On Wednesday 14 March 2012 14:48:22 Andreas Oberritter wrote:

I thought that Qt 4.8 didn't use WebKit2 by default. Did you enable it manually?

FYI our Qt 4.8 recipes enable QtWebkit by default.

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

Andreas Oberritter

2012-03-14 14:17 UTC #5 lore raw

Quoted 5 lines · Paul Eggleton

Quoted 2 lines · On Wednesday 14 March 2012 14:48:22 Andreas Oberritter wrote:
I thought that Qt 4.8 didn't use WebKit2 by default. Did you enable it manually?
FYI our Qt 4.8 recipes enable QtWebkit by default.

Yes, but QtWebKit 2.2, which is included in Qt 4.8, uses WebKit, not WebKit2, right?

Regards,
Andreas

Paul Eggleton

2012-03-14 14:24 UTC #6 lore raw

Quoted 9 lines · On Wednesday 14 March 2012 15:08:45 Andreas Oberritter wrote:

Quoted 5 lines · Paul Eggleton
Quoted 2 lines · On Wednesday 14 March 2012 14:48:22 Andreas Oberritter wrote:
I thought that Qt 4.8 didn't use WebKit2 by default. Did you enable it manually?
FYI our Qt 4.8 recipes enable QtWebkit by default.
Yes, but QtWebKit 2.2, which is included in Qt 4.8, uses WebKit, not WebKit2, right?

Ah, sorry I missed what you were asking. I'm not sure I'm afraid.

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

Martin Jansa

author

2012-03-14 14:24 UTC #7 lore raw

In reply to Andreas Oberritter

Quoted 19 lines · Andreas Oberritter

Quoted 18 lines · Martin Jansa
Quoted 17 lines · Martin Jansa
Quoted 15 lines · On Tue, Mar 13, 2012 at 11:48:20AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 4c41a3204ef72f53813ddc86fe525fa9c6714daa
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=4c41a3204ef72f53813ddc86fe525fa9c6714daa
Author: Andreas Oberritter <[email protected]>
Date:   Wed Mar  7 21:36:28 2012 +0100
qt4: fix deps in libQtWebkit.la and QtWebKit.pc
* Both files contain -L../../WebCore/release -L../../JavaScriptCore/release -lwebcore -ljscore
* These paths and libs don't get installed.
* When building a shared lib with libtool, that links
with libQtWebKit, libtool adds these unneeded parameters
to the linker command-line, thus linking fails.

Quoted 6 lines

Quoted 4 lines
Quoted 4 lines
BTW: here with bitbake having R/W to rootfs every qt4-x11-free build creates /include/WebCore/libdummy.prl (yes really in root) anynone seen this?
-rw-r--r-- 1 bitbake bitbake 680 Mar 14 01:13 /include/WebCore/libdummy.prl
I'm only using qt4-embedded, with which I haven't noticed this file.

I guess it fails on most builders as user running bitbake doesn't have right to create it (my is special because it's minimal chroot environment owned by same user as who is running bitbake process).

Quoted 11 lines

Quoted 8 lines
Quoted 1 line
Maybe it's sign of another small issue in qt4 build.
It's created during do_configure and probably caused by ./qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/WebKit2/Makefile:all: Makefile /include/WebCore/libdummy.prl /include/WebCore/$(TARGET) ./qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/WebKit2/Makefile:/include/WebCore/libdummy.prl:
But in unpacked sources closest thing to libdummy.prl is ./Source/WebKit2/DerivedSources.pro:TARGET = dummy
I thought that Qt 4.8 didn't use WebKit2 by default. Did you enable it manually?

No everything default oe-core+meta-oe.

Cheers,

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Martin Jansa

author

2012-04-30 22:14 UTC #8 lore raw

Quoted 40 lines · Martin Jansa

Quoted 19 lines · Andreas Oberritter
Quoted 18 lines · Martin Jansa
Quoted 17 lines · Martin Jansa
Quoted 15 lines · On Tue, Mar 13, 2012 at 11:48:20AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: 4c41a3204ef72f53813ddc86fe525fa9c6714daa
URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=4c41a3204ef72f53813ddc86fe525fa9c6714daa
Author: Andreas Oberritter <[email protected]>
Date: Wed Mar 7 21:36:28 2012 +0100
qt4: fix deps in libQtWebkit.la and QtWebKit.pc
* Both files contain -L../../WebCore/release -L../../JavaScriptCore/release -lwebcore -ljscore
* These paths and libs don't get installed.
* When building a shared lib with libtool, that links
with libQtWebKit, libtool adds these unneeded parameters
to the linker command-line, thus linking fails.
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
BTW: here with bitbake having R/W to rootfs every qt4-x11-free build creates /include/WebCore/libdummy.prl (yes really in root) anynone seen this?
-rw-r--r-- 1 bitbake bitbake 680 Mar 14 01:13 /include/WebCore/libdummy.prl
I'm only using qt4-embedded, with which I haven't noticed this file.
I guess it fails on most builders as user running bitbake doesn't have right to create it (my is special because it's minimal chroot environment owned by same user as who is running bitbake process).
Quoted 9 lines
Quoted 8 lines
Quoted 1 line
Maybe it's sign of another small issue in qt4 build.
It's created during do_configure and probably caused by ./qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/WebKit2/Makefile:all: Makefile /include/WebCore/libdummy.prl /include/WebCore/$(TARGET) ./qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/WebKit2/Makefile:/include/WebCore/libdummy.prl:
But in unpacked sources closest thing to libdummy.prl is ./Source/WebKit2/DerivedSources.pro:TARGET = dummy

Quoted 6 lines

Quoted 2 lines
I thought that Qt 4.8 didn't use WebKit2 by default. Did you enable it manually?
No everything default oe-core+meta-oe.
Cheers,

with chmod 500 / I can clearly see in log.do_configure

for /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/qt4-x11-free/qt4-x11-free-4.8.1-r42.1/qt-everywhere-opensource-src-4.8.1/src/3rdparty/webkit/Source/WebKit2/DerivedSources.pro
(linux-gnueabi-oe-g++) /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/qt4-x11-free/qt4-x11-free-4.8.1-r42.1/qt-everywhere-opensource-src-4.8.1/bin/qmake
-spec /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/qt4-x11-free/qt4-x11-free-4.8.1-r42.1/qt-everywhere-opensource-src-4.8.1/mkspecs/linux-gnueabi-oe-g++ -o /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/qt4-x11-free/qt4-x11-free-4.8.1-r42.1/qt-everywhere-opensource-src-4.8.1/./src/3rdparty/webkit/Source/WebKit2 /OE/shr-core/tmp-eglibc/work/armv4t-oe-linux-gnueabi/qt4-x11-free/qt4-x11-free-4.8.1-r42.1/qt-everywhere-opensource-src-4.8.1/src/3rdparty/webkit/Source/WebKit2/DerivedSources.pro
WARNING: DESTDIR: Cannot access directory '/include/WebCore'

And in DerivedSources.pro there is
DESTDIR = $$OUTPUT_DIR/include/"WebCore"

So am I the only one seeing this or everybody just ingores this because it's just WARNING in log (when you don't have / writeable by user running bitbake?)

Cheers,