EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc

PATCH New Chander Kashyap 4 participants 6 messages Mar 14, 2012 – Mar 15, 2012

Subsystems (2)

Arm (32-bit) Arm Samsung Exynos

lore

Share & tools

lore

Chander Kashyap

author

2012-03-14 13:14 UTC #0 lore raw

PATCH 1/1 EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc

TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic usase of tzpc.

Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.

Signed-off-by Chander Kashyap <[email protected]>

---
 arch/arm/include/asm/arch-exynos/tzpc.h |    2 +-
 board/samsung/smdk5250/tzpc_init.c      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/include/asm/arch-exynos/tzpc.h +1 -1

index 2c9a07b..63736ae 100644
@@ -22,7 +22,7 @@
 #define __TZPC_H_
 
 #ifndef __ASSEMBLY__
-struct exynos5_tzpc {
+struct s5p_tzpc {
 	unsigned int r0size;
 	char res1[0x7FC];
 	unsigned int decprot0stat;

board/samsung/smdk5250/tzpc_init.c +1 -1

index c2ccef3..03e46bb 100644
@@ -28,7 +28,7 @@
 /* Setting TZPC[TrustZone Protection Controller] */
 void tzpc_init(void)
 {
-	struct exynos5_tzpc *tzpc;
+	struct s5p_tzpc *tzpc;
 	unsigned int addr;
 
 	for (addr = TZPC0_BASE; addr <= TZPC9_BASE; addr += TZPC_BASE_OFFSET) {

Signature · 1 line

1.7.5.4

Kyungmin Park

2012-03-14 13:32 UTC #1 lore raw

PATCH 1/1 EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc

Hi Chander,

Quoted 20 lines · Chander Kashyap

TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic usase of tzpc.
Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
Signed-off-by Chander Kashyap <[email protected]>
---
?arch/arm/include/asm/arch-exynos/tzpc.h | ? ?2 +- ?board/samsung/smdk5250/tzpc_init.c ? ? ?| ? ?2 +- ?2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/include/asm/arch-exynos/tzpc.h +0 -0
index 2c9a07b..63736ae 100644
@@ -22,7 +22,7 @@
?#define __TZPC_H_
?#ifndef __ASSEMBLY__

arch/arm/include/asm/arch-exynos/tzpc.h line 25

Quoted 2 lines

arch/arm/include/asm/arch-exynos/tzpc.h +1 -1
-struct exynos5_tzpc {
+struct s5p_tzpc {

I think 'exynos' is preferable. Even though each SOC has different number of tzpc. It can be covered one exynos_tzpc. or we can define it for each SoC.

Thank you,
Kyungmin Park

Quoted 24 lines

? ? ? ?unsigned int r0size;
? ? ? ?char res1[0x7FC];
? ? ? ?unsigned int decprot0stat;
board/samsung/smdk5250/tzpc_init.c +0 -0
index c2ccef3..03e46bb 100644
@@ -28,7 +28,7 @@
?/* Setting TZPC[TrustZone Protection Controller] */ ?void tzpc_init(void)
?{
- ? ? ? struct exynos5_tzpc *tzpc;
+ ? ? ? struct s5p_tzpc *tzpc;
? ? ? ?unsigned int addr;
? ? ? ?for (addr = TZPC0_BASE; addr <= TZPC9_BASE; addr += TZPC_BASE_OFFSET) { --
1.7.5.4
_______________________________________________
linaro-dev mailing list
linaro-dev at lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev

Chander Kashyap

author

2012-03-14 13:38 UTC #2 lore raw

PATCH 1/1 EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc

Hi Kyungmin Park,

Quoted 23 lines · Kyungmin Park

Hi Chander,
Quoted 19 lines · Chander Kashyap
TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic usase of tzpc.
Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
Signed-off-by Chander Kashyap <[email protected]>
---
?arch/arm/include/asm/arch-exynos/tzpc.h | ? ?2 +- ?board/samsung/smdk5250/tzpc_init.c ? ? ?| ? ?2 +- ?2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/include/asm/arch-exynos/tzpc.h +0 -0
index 2c9a07b..63736ae 100644
@@ -22,7 +22,7 @@
?#define __TZPC_H_

Quoted 4 lines

arch/arm/include/asm/arch-exynos/tzpc.h line 25
Quoted 3 lines
?#ifndef __ASSEMBLY__
arch/arm/include/asm/arch-exynos/tzpc.h +1 -1
-struct exynos5_tzpc {
+struct s5p_tzpc {
I think 'exynos' is preferable. Even though each SOC has different

I tried to carry forward old conventions as in case of watchdog. I will change it to exynos.

Quoted 2 lines

number of tzpc. It can be covered one exynos_tzpc. or ?we can define it for each SoC.

One structure is enough as fields are same.

Quoted 27 lines

Thank you,
Kyungmin Park
Quoted 24 lines
? ? ? ?unsigned int r0size;
? ? ? ?char res1[0x7FC];
? ? ? ?unsigned int decprot0stat;
board/samsung/smdk5250/tzpc_init.c +0 -0
index c2ccef3..03e46bb 100644
@@ -28,7 +28,7 @@
?/* Setting TZPC[TrustZone Protection Controller] */ ?void tzpc_init(void)
?{
- ? ? ? struct exynos5_tzpc *tzpc;
+ ? ? ? struct s5p_tzpc *tzpc;
? ? ? ?unsigned int addr;
? ? ? ?for (addr = TZPC0_BASE; addr <= TZPC9_BASE; addr += TZPC_BASE_OFFSET) { --
1.7.5.4
_______________________________________________
linaro-dev mailing list
linaro-dev at lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev

Signature · 2 lines

with warm regards,
Chander Kashyap

Minkyu Kang

2012-03-15 01:23 UTC #3 lore raw

PATCH 1/1 EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc

Dear Chander Kashyap,

Quoted 26 lines · Chander Kashyap

Hi Kyungmin Park,
Quoted 23 lines · Kyungmin Park
Hi Chander,
Quoted 19 lines · Chander Kashyap
TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic usase of tzpc.
Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
Signed-off-by Chander Kashyap <[email protected]>
---
?arch/arm/include/asm/arch-exynos/tzpc.h | ? ?2 +- ?board/samsung/smdk5250/tzpc_init.c ? ? ?| ? ?2 +- ?2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/include/asm/arch-exynos/tzpc.h +0 -0
index 2c9a07b..63736ae 100644
@@ -22,7 +22,7 @@
?#define __TZPC_H_

Quoted 6 lines

Quoted 4 lines
arch/arm/include/asm/arch-exynos/tzpc.h line 25
Quoted 3 lines
?#ifndef __ASSEMBLY__
arch/arm/include/asm/arch-exynos/tzpc.h +1 -1
-struct exynos5_tzpc {
+struct s5p_tzpc {
I think 'exynos' is preferable. Even though each SOC has different
I tried to carry forward old conventions as in case of watchdog. I will change it to exynos.

I agreed with Kyungmin.

Chander Kashyap

author

2012-03-15 03:30 UTC #4 lore raw

PATCH 1/1 EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc

Dear Minkyu,

Quoted 33 lines · Minkyu Kang

Dear Chander Kashyap,
Quoted 30 lines · Chander Kashyap
Hi Kyungmin Park,
Quoted 27 lines · Kyungmin Park
Hi Chander,
Quoted 20 lines · Chander Kashyap
TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic usase of tzpc.
Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
Signed-off-by Chander Kashyap <[email protected]>
---
?arch/arm/include/asm/arch-exynos/tzpc.h | ? ?2 +- ?board/samsung/smdk5250/tzpc_init.c ? ? ?| ? ?2 +- ?2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/include/asm/arch-exynos/tzpc.h +0 -0
index 2c9a07b..63736ae 100644
@@ -22,7 +22,7 @@
?#define __TZPC_H_
?#ifndef __ASSEMBLY__
arch/arm/include/asm/arch-exynos/tzpc.h line 25
Quoted 2 lines
arch/arm/include/asm/arch-exynos/tzpc.h +1 -1
-struct exynos5_tzpc {
+struct s5p_tzpc {
I think 'exynos' is preferable. Even though each SOC has different

Quoted 6 lines

Quoted 2 lines
I tried to carry forward old conventions as in case of watchdog. I will change it to exynos.
I agreed with Kyungmin.
From now, let's called "exynos" for common name including s5pc1xx and s5pc2xx and exynos4 and exynos5.. etc.

Thanks for the inputs. Let us follow the convention. I will resubmit the patch.

Quoted 12 lines

Quoted 6 lines
Quoted 4 lines
number of tzpc. It can be covered one exynos_tzpc. or ?we can define it for each SoC.
One structure is enough as fields are same.
Thanks
Minkyu Kang.
--
from. prom.
www.promsoft.net

Signature · 2 lines

with warm regards,
Chander Kashyap

Tushar Behera

2012-03-15 03:55 UTC #5 lore raw

PATCH 1/1 EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc

In reply to Minkyu Kang

Quoted 40 lines · Minkyu Kang

Dear Chander Kashyap,
Quoted 26 lines · Chander Kashyap
Hi Kyungmin Park,
Quoted 23 lines · Kyungmin Park
Hi Chander,
Quoted 19 lines · Chander Kashyap
TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic usase of tzpc.
Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
Signed-off-by Chander Kashyap <[email protected]>
---
 arch/arm/include/asm/arch-exynos/tzpc.h |    2 +-
 board/samsung/smdk5250/tzpc_init.c      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/include/asm/arch-exynos/tzpc.h +0 -0
index 2c9a07b..63736ae 100644
@@ -22,7 +22,7 @@
 #define __TZPC_H_
 
Quoted 6 lines
Quoted 4 lines
arch/arm/include/asm/arch-exynos/tzpc.h line 25
Quoted 3 lines
arch/arm/include/asm/arch-exynos/tzpc.h +1 -1
 #ifndef __ASSEMBLY__
-struct exynos5_tzpc {
+struct s5p_tzpc {
I think 'exynos' is preferable. Even though each SOC has different
I tried to carry forward old conventions as in case of watchdog. I will change it to exynos.
I agreed with Kyungmin.
From now, let's called "exynos" for common name including s5pc1xx and s5pc2xx and exynos4 and exynos5.. etc.