io_submit: uninitialized iocb may not return -EINVAL

PATCH In review Jan Stancek 3 participants 3 messages Mar 15, 2012

lore

Share & tools

lore

Jan Stancek

author

2012-03-15 09:16 UTC #0 lore raw

PATCH v2 1/1 io_submit: uninitialized iocb may not return -EINVAL

Testcase 1.3 - EINVAL: uninitialized iocb
is about submitting uninitialized iocb structure.

Test is expecting to get -EINVAL, but other values are also possible as uninitialized struct can contain any values.

For example following data fails with -EBADF:
--- snip ---

unsigned char bad_iocb[64] = {
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x84, 0xa5,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0x00, 0x00, 0x0f, 0xff, 0xe0, 0x10, 0x0c, 0x30,
    0x00, 0x00, 0x0f, 0xff, 0xe0, 0x10, 0x0c, 0x40,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };

memcpy(&iocb, bad_iocb, sizeof(iocb));
iocbs[0] = &iocb;
TEST(io_submit(ctx, 1, iocbs));
check_result(-EINVAL, TEST_RETURN);
--- snip ---

This patch accepts also few other errno codes as valid return value.

Signed-off-by Jan Stancek <[email protected]>

---
 testcases/kernel/syscalls/io_submit/io_submit01.c |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)

testcases/kernel/syscalls/io_submit/io_submit01.c +14 -1

index da15aa0..2494863 100644
@@ -126,7 +126,20 @@ int main(int argc, char *argv[])
 		/* 1.3 - EINVAL: uninitialized iocb */
 		iocbs[0] = &iocb;
 		TEST(io_submit(ctx, 1, iocbs));
-		check_result(-EINVAL, TEST_RETURN);
+		switch(TEST_RETURN) {
+		case -EINVAL:
+		case -EBADF:
+		case -EFAULT:
+			tst_resm(TPASS, "expected failure - "
+					"returned value = %ld : %s",
+					TEST_RETURN, strerror(-1 * TEST_RETURN));
+			break;
+		default:
+			tst_resm(TFAIL, "unexpected failure - "
+					"returned value = %ld : %s, "
+					"expected one of -EINVAL, -EBADF, -EFAULT",
+					TEST_RETURN, strerror(-1 * TEST_RETURN));
+		}
 
 		/* 2 - EFAULT: iocb points to invalid data */
 		TEST(io_submit(ctx, 1, (struct iocb **)-1));

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Caspar Zhang

Reviewed-by on v2 1/1

2012-03-15 09:24 UTC #1 lore raw

Quoted 24 lines · Jan Stancek

Testcase 1.3 - EINVAL: uninitialized iocb
is about submitting uninitialized iocb structure.
Test is expecting to get -EINVAL, but other values are also possible as uninitialized struct can contain any values.
For example following data fails with -EBADF:
--- snip ---
unsigned char bad_iocb[64] = {
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x84, 0xa5,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x0f, 0xff, 0xe0, 0x10, 0x0c, 0x30,
     0x00, 0x00, 0x0f, 0xff, 0xe0, 0x10, 0x0c, 0x40,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
memcpy(&iocb, bad_iocb, sizeof(iocb));
iocbs[0] = &iocb;
TEST(io_submit(ctx, 1, iocbs));
check_result(-EINVAL, TEST_RETURN);
--- snip ---

Quoted 3 lines

This patch accepts also few other errno codes as valid return value.
Signed-off-by Jan Stancek <[email protected]>

Reviewed-by Caspar Zhang <[email protected]>

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Wanlong Gao

Acked-by on v2 1/1

2012-03-15 09:29 UTC #2 lore raw

In reply to Jan Stancek

Quoted 24 lines · Jan Stancek

Testcase 1.3 - EINVAL: uninitialized iocb
is about submitting uninitialized iocb structure.
Test is expecting to get -EINVAL, but other values are also possible as uninitialized struct can contain any values.
For example following data fails with -EBADF:
--- snip ---
unsigned char bad_iocb[64] = {
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x84, 0xa5,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0x00, 0x00, 0x0f, 0xff, 0xe0, 0x10, 0x0c, 0x30,
    0x00, 0x00, 0x0f, 0xff, 0xe0, 0x10, 0x0c, 0x40,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
memcpy(&iocb, bad_iocb, sizeof(iocb));
iocbs[0] = &iocb;
TEST(io_submit(ctx, 1, iocbs));
check_result(-EINVAL, TEST_RETURN);
--- snip ---

Quoted 3 lines

This patch accepts also few other errno codes as valid return value.
Signed-off-by Jan Stancek <[email protected]>

Thanks Jan, I will take this.

Acked-by Wanlong Gao <[email protected]>

Quoted 14 lines

---
 testcases/kernel/syscalls/io_submit/io_submit01.c |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure

Quoted 4 lines

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list