Skip to contentSkip to conversation

pmic_i2c: Return error in case of invalid pmic_i2c_tx_num

PATCH New Fabio Estevam 4 participants 5 messages Mar 16, 2012 – Mar 19, 2012 Char and misc drivers

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 pmic_i2c: Return error in case of invalid pmic_i2c_tx_num

Return error in case of invalid pmic_i2c_tx_num.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/misc/pmic_i2c.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/misc/pmic_i2c.c +6 -0
index ad55d64..ebb124d 100644
@@ -47,6 +47,9 @@ int pmic_reg_write(struct pmic *p, u32 reg, u32 val)
 	case 1:
 		buf[0] = val & 0xff;
 		break;
+	default:
+		printf("%s: invalid tx_num: %d", __func__, pmic_i2c_tx_num);
+		return -1;
 	}
 
 	if (i2c_write(pmic_i2c_addr, reg, 1, buf, pmic_i2c_tx_num))

@@ -73,6 +76,9 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val)
 	case 1:
 		ret_val = buf[0];
 		break;
+	default:
+		printf("%s: invalid tx_num: %d", __func__, pmic_i2c_tx_num);
+		return -1;
 	}
 	memcpy(val, &ret_val, sizeof(ret_val));
Signature · 1 line
1.7.1
#2 lore raw

PATCH 1/1 pmic_i2c: Return error in case of invalid pmic_i2c_tx_num

In reply to Fabio Estevam
Quoted 24 lines · On Fri, 16 Mar 2012 18:32:09 -0300 Fabio Estevam <[email protected]> wrote:

Return error in case of invalid pmic_i2c_tx_num.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/misc/pmic_i2c.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/misc/pmic_i2c.c +3 -0
index ad55d64..ebb124d 100644
@@ -47,6 +47,9 @@ int pmic_reg_write(struct pmic *p, u32 reg, u32 val)
 	case 1:
 		buf[0] = val & 0xff;
 		break;
+	default:
+		printf("%s: invalid tx_num: %d", __func__,
 pmic_i2c_tx_num);
+		return -1;
 	}
drivers/misc/pmic_i2c.c +0 -0
 	if (i2c_write(pmic_i2c_addr, reg, 1, buf, pmic_i2c_tx_num))

drivers/misc/pmic_i2c.c int pmic_reg_read(struct pmic *p, u32 reg, u32 *val) · line 84

Quoted 9 lines
drivers/misc/pmic_i2c.c +3 -0
@@ -73,6 +76,9 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val)
 	case 1:
 		ret_val = buf[0];
 		break;
+	default:
+		printf("%s: invalid tx_num: %d", __func__,
 pmic_i2c_tx_num);
+		return -1;
 	}
 	memcpy(val, &ret_val, sizeof(ret_val));

Hi Fabio,

Looks ok, for me.

Acked-by Lukasz Majewski <[email protected]>
Signature · 6 lines
Best regards,

Lukasz Majewski

Samsung Poland R&D Center
Platform Group
#3 lore raw

PATCH 1/1 pmic_i2c: Return error in case of invalid pmic_i2c_tx_num

In reply to Fabio Estevam
Quoted 22 lines · Fabio Estevam

Return error in case of invalid pmic_i2c_tx_num.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/misc/pmic_i2c.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/misc/pmic_i2c.c +3 -0
index ad55d64..ebb124d 100644
@@ -47,6 +47,9 @@ int pmic_reg_write(struct pmic *p, u32 reg, u32 val)
 	case 1:
 		buf[0] = val & 0xff;
 		break;
+	default:
+		printf("%s: invalid tx_num: %d", __func__, pmic_i2c_tx_num);
+		return -1;
 	}
 
 	if (i2c_write(pmic_i2c_addr, reg, 1, buf, pmic_i2c_tx_num))

drivers/misc/pmic_i2c.c int pmic_reg_read(struct pmic *p, u32 reg, u32 *val) · line 83

Quoted 8 lines
drivers/misc/pmic_i2c.c +3 -0
@@ -73,6 +76,9 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val)
 	case 1:
 		ret_val = buf[0];
 		break;
+	default:
+		printf("%s: invalid tx_num: %d", __func__, pmic_i2c_tx_num);
+		return -1;
 	}
 	memcpy(val, &ret_val, sizeof(ret_val));
Acked-by Stefano Babic <[email protected]>

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
#4 lore raw

PATCH 1/1 pmic_i2c: Return error in case of invalid pmic_i2c_tx_num

In reply to Fabio Estevam
Quoted 4 lines · Fabio Estevam

Return error in case of invalid pmic_i2c_tx_num.

Signed-off-by Fabio Estevam <[email protected]>

---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================