Skip to contentSkip to conversation

part_dos: align disk buffers on cache line to enable DMA and cache

PATCH Superseded Eric Nelson 4 participants 4 messages Mar 3, 2012 – Apr 24, 2012

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 part_dos: align disk buffers on cache line to enable DMA and cache

---
 disk/part_dos.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
disk/part_dos.c +3 -3
index b5bcb37..c028aaf 100644
@@ -87,7 +87,7 @@ static int test_block_type(unsigned char *buffer)
 
 int test_part_dos (block_dev_desc_t *dev_desc)
 {
-	unsigned char buffer[dev_desc->blksz];
+	ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buffer, dev_desc->blksz);
 
 	if ((dev_desc->block_read(dev_desc->dev, 0, 1, (ulong *) buffer) != 1) ||
 	    (buffer[DOS_PART_MAGIC_OFFSET + 0] != 0x55) ||
@@ -102,7 +102,7 @@ int test_part_dos (block_dev_desc_t *dev_desc)
 static void print_partition_extended (block_dev_desc_t *dev_desc, int ext_part_sector, int relative,
 							   int part_num)
 {
-	unsigned char buffer[dev_desc->blksz];
+	ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buffer, dev_desc->blksz);
 	dos_partition_t *pt;
 	int i;
 
@@ -166,7 +166,7 @@ static int get_partition_info_extended (block_dev_desc_t *dev_desc, int ext_part
 				 int relative, int part_num,
 				 int which_part, disk_partition_t *info)
 {
-	unsigned char buffer[dev_desc->blksz];
+	ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buffer, dev_desc->blksz);
 	dos_partition_t *pt;
 	int i;
 
Signature · 1 line
1.7.9
#2 lore raw

PATCH 1/2 part_dos: align disk buffers on cache line to enable DMA and cache

In reply to Eric Nelson
Quoted 1 line · Eric Nelson

Anybody likes to comment/apply this patch?

Many thanks!

Dirk

Quoted 35 lines
---
  disk/part_dos.c |    6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)
disk/part_dos.c +3 -3
index b5bcb37..c028aaf 100644
@@ -87,7 +87,7 @@ static int test_block_type(unsigned char *buffer)
 
  int test_part_dos (block_dev_desc_t *dev_desc)
  {
-	unsigned char buffer[dev_desc->blksz];
+	ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buffer, dev_desc->blksz);
 
  	if ((dev_desc->block_read(dev_desc->dev, 0, 1, (ulong *) buffer) != 1) ||
  	    (buffer[DOS_PART_MAGIC_OFFSET + 0] != 0x55) ||
@@ -102,7 +102,7 @@ int test_part_dos (block_dev_desc_t *dev_desc)
  static void print_partition_extended (block_dev_desc_t *dev_desc, int ext_part_sector, int relative,
  							   int part_num)
  {
-	unsigned char buffer[dev_desc->blksz];
+	ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buffer, dev_desc->blksz);
  	dos_partition_t *pt;
  	int i;
 
@@ -166,7 +166,7 @@ static int get_partition_info_extended (block_dev_desc_t *dev_desc, int ext_part
  				 int relative, int part_num,
  				 int which_part, disk_partition_t *info)
  {
-	unsigned char buffer[dev_desc->blksz];
+	ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buffer, dev_desc->blksz);
  	dos_partition_t *pt;
  	int i;