net: fec_mxc: allow use with cache enabled
PATCH v4 1/1 net: fec_mxc: allow use with cache enabled
Hi Marek,
Have you had a chance to review this V4 patch for the fec_mxc driver?
http://lists.denx.de/pipermail/u-boot/2012-March/120205.html
Note that Stefano pointed out yesterday that PPC doesn't properly implement "invalidate_dcache_range".
http://lists.denx.de/pipermail/u-boot/2012-March/120918.html
I believe you mentioned previously that the fec_mxc driver was compatible with certain PPC SOCs, so this might temporarily block any such transition.
Please advise,
Eric
PATCH v4 1/1 net: fec_mxc: allow use with cache enabled
Dear Eric Nelson,
Quoted 5 lines
Hi Marek,
Have you had a chance to review this V4 patch for the
fec_mxcdriver?http://lists.denx.de/pipermail/u-boot/2012-March/120205.html
If I didn't review, I was probably fine with it as it was ;-) Though I think I acked it.
Quoted 6 lines
Note that Stefano pointed out yesterday that PPC doesn't properly implement "
invalidate_dcache_range".http://lists.denx.de/pipermail/u-boot/2012-March/120918.html
Quoted 8 lines
I believe you mentioned previously that the
fec_mxcdriver was compatible with certain PPC SOCs, so this might temporarily block any such transition.Please advise,
Eric
Best regards,
Marek Vasut
PATCH v4 1/1 net: fec_mxc: allow use with cache enabled
Quoted 11 lines · Marek Vasut
Dear Eric Nelson,
Quoted 5 lines
Hi Marek,
Have you had a chance to review this V4 patch for the
fec_mxcdriver?http://lists.denx.de/pipermail/u-boot/2012-March/120205.htmlIf I didn't review, I was probably fine with it as it was ;-) Though I think I acked it.
Thanks Marek,
I was trying to clean up my "Changes requested" items in patchwork to keep Graeme happy and it appears that this wasn't acked.
http://patchwork.ozlabs.org/patch/146658/
I think Mike also hinted at an ack of V3:
http://lists.denx.de/pipermail/u-boot/2012-March/120217.html
Regards,
Eric
PATCH v4 1/1 net: fec_mxc: allow use with cache enabled
In reply to Eric NelsonQuoted 2 lines · Eric Nelson
Hi Marek,
Hi Eric,
Quoted 3 lines
Have you had a chance to review this V4 patch for the
fec_mxcdriver?http://lists.denx.de/pipermail/u-boot/2012-March/120205.html
Marek has sent all cache relevant patches together in the same patchset. If I am not wrong, your V4 was sent as :
http://patchwork.ozlabs.org/patch/147143/
and he added his own Ack.
Quoted 8 lines
Note that Stefano pointed out yesterday that PPC doesn't properly implement "
invalidate_dcache_range".http://lists.denx.de/pipermail/u-boot/2012-March/120918.htmlI believe you mentioned previously that the
fec_mxcdriver was compatible with certain PPC SOCs, so this might temporarily block any such transition.
For FEC it is easier as for ESDHC. The controller on PowerPC has the same name, but it is different - and there is a different driver. The fec_mxc.c is only for i.MX SOCs, and we are sure we do not break other architectures, except i.MX. I know it breaks MX3x, I will check it.
The whole serie depends on the first patch:
http://patchwork.ozlabs.org/patch/147135/
This must be acked / merged by Albert, because it is for all arm926 SOCs.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v4 1/1 net: fec_mxc: allow use with cache enabled
Dear Stefano Babic,
Quoted 11 lines · Eric Nelson
Quoted 1 line
Hi Marek,
Hi Eric,
Quoted 3 lines
Have you had a chance to review this V4 patch for the
fec_mxcdriver?http://lists.denx.de/pipermail/u-boot/2012-March/120205.htmlMarek has sent all cache relevant patches together in the same patchset. If I am not wrong, your V4 was sent as :
That's true ... also, I'm afraid the arm926ejs stuff won't be Acked by AA since he's gone ... somewhere, noone knows where :-(
Quoted 19 lines
http://patchwork.ozlabs.org/patch/147143/
and he added his own Ack.
Quoted 8 lines
Note that Stefano pointed out yesterday that PPC doesn't properly implement "
invalidate_dcache_range".http://lists.denx.de/pipermail/u-boot/2012-March/120918.htmlI believe you mentioned previously that the
fec_mxcdriver was compatible with certain PPC SOCs, so this might temporarily block any such transition.For FEC it is easier as for ESDHC. The controller on PowerPC has the same name, but it is different - and there is a different driver. The
fec_mxc.cis only for i.MX SOCs, and we are sure we do not break other architectures, except i.MX. I know it breaks MX3x, I will check it.
Quoted 7 lines
The whole serie depends on the first patch:
http://patchwork.ozlabs.org/patch/147135/This must be acked / merged by Albert, because it is for all arm926 SOCs.
Best regards,
Stefano Babic
Best regards,
Marek Vasut