Skip to contentSkip to conversation

Status for 2012.03

U-Boot Albert ARIBAUD 4 participants 9 messages Mar 27, 2012 – Mar 31, 2012

lore
Share & tools
lore
#0 lore raw

Hi all,

I have been away from the list quite a few days, and will have a very tricky time catching up, so with my apologies, I ask people who need me to apply patches or pull requests for the upcoming release to please send me a private e-mail and point me to the list message that I should be acting upon.

Amicalement,

Signature · 1 line
Albert.
#1 lore raw

Le 27/03/2012 22:18, Albert ARIBAUD a ?crit :

Quoted 7 lines

Hi all,

I have been away from the list quite a few days, and will have a very tricky time catching up, so with my apologies, I ask people who need me to apply patches or pull requests for the upcoming release to please send me a private e-mail and point me to the list message that I should be acting upon.

All,

I should have fulfilled all pending pull requests and patches. I will be sending out the ARM pull request shortly; let me know if anything is wrong with it.

Amicalement,

Signature · 1 line
Albert.
#2 lore raw
In reply to Albert ARIBAUD

Le 27/03/2012 22:18, Albert ARIBAUD a ?crit :

Quoted 7 lines

Hi all,

I have been away from the list quite a few days, and will have a very tricky time catching up, so with my apologies, I ask people who need me to apply patches or pull requests for the upcoming release to please send me a private e-mail and point me to the list message that I should be acting upon.

FWIW, ./MAKEALL arm on current u-boot-arm/master with CS toolchain 2010q1 builds 277 boards, of which none has errors and 167 have warnings.

The total count of warnings is 248, distributed as:

4 post.c:503: warning: #warning "Not implemented yet"

79 mmc.c:132: warning: no return statement in function returning non-void

165 ohci-hcd.c:{1307,1310,1313}: warning: dereferencing pointer
'pretmp.NNN' does break strict-aliasing rules

(the last one is actually 3 * 51 warnings)

The first one is obvious and should be dealt with, but I consider it not to be a blocker, for only 4 boards.

The second one seems straightforward to fix today, if not already submitted.

The third one may be an issue, but it could also be a zealous warning from the specific CS toolchain version I am using. Anyway, it does not seem ARM related as such.

Therefore I will issue the ARM pull request right away.

Amicalement,

Signature · 1 line
Albert.
#3 lore raw

+Marek

Hi Albert,

Quoted 17 lines · Albert ARIBAUD

Le 27/03/2012 22:18, Albert ARIBAUD a ?crit :

Quoted 9 lines

Hi all,

I have been away from the list quite a few days, and will have a very tricky time catching up, so with my apologies, I ask people who need me to apply patches or pull requests for the upcoming release to please send me a private e-mail and point me to the list message that I should be acting upon.

FWIW, ./MAKEALL arm on current u-boot-arm/master with CS toolchain 2010q1 builds 277 boards, of which none has errors and 167 have warnings.

The total count of warnings is 248, distributed as:

Quoted 7 lines

4 ? ? ? post.c:503: warning: #warning "Not implemented yet"

79 ? ? ?mmc.c:132: warning: no return statement in function returning non-void

165 ? ? ohci-hcd.c:{1307,1310,1313}: warning: dereferencing pointer 'pretmp.NNN' does break strict-aliasing rules

I did create a patch for this - it is marked delegated to Marek.

http://patchwork.ozlabs.org/patch/134600/

Quoted 11 lines

(the last one is actually 3 * 51 warnings)

The first one is obvious and should be dealt with, but I consider it not to be a blocker, for only 4 boards.

The second one seems straightforward to fix today, if not already submitted.

The third one may be an issue, but it could also be a zealous warning from the specific CS toolchain version I am using. Anyway, it does not seem ARM related as such.

Would be nice to get rid of it, but I think it is specific to some toolchains.

Quoted 11 lines

Therefore I will issue the ARM pull request right away.

Amicalement,
--
Albert.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Regards,
Simon

#4 lore raw

Dear Simon Glass,

Quoted 27 lines

+Marek

Hi Albert,

On Fri, Mar 30, 2012 at 12:08 AM, Albert ARIBAUD

Quoted 20 lines · <[email protected]> wrote:

Le 27/03/2012 22:18, Albert ARIBAUD a ?crit :

Quoted 8 lines

Hi all,

I have been away from the list quite a few days, and will have a very tricky time catching up, so with my apologies, I ask people who need me to apply patches or pull requests for the upcoming release to please send me a private e-mail and point me to the list message that I should be acting upon.

FWIW, ./MAKEALL arm on current u-boot-arm/master with CS toolchain 2010q1 builds 277 boards, of which none has errors and 167 have warnings.

The total count of warnings is 248, distributed as:

4 post.c:503: warning: #warning "Not implemented yet"

79 mmc.c:132: warning: no return statement in function returning
non-void

Quoted 6 lines
Quoted 2 lines

165 ohci-hcd.c:{1307,1310,1313}: warning: dereferencing pointer
'pretmp.NNN' does break strict-aliasing rules

I did create a patch for this - it is marked delegated to Marek.

http://patchwork.ozlabs.org/patch/134600/

And stupid maintainer didn't look into it ... bad, bad maintainer. Accept my apology. But wasn't it decided with Mike that this was indeed a toolchain issue and not all toolchains choke on it?

Quoted 27 lines
Quoted 6 lines

(the last one is actually 3 * 51 warnings)

The first one is obvious and should be dealt with, but I consider it not to be a blocker, for only 4 boards.

Quoted 6 lines

The second one seems straightforward to fix today, if not already submitted.

The third one may be an issue, but it could also be a zealous warning from the specific CS toolchain version I am using. Anyway, it does not seem ARM related as such.

Would be nice to get rid of it, but I think it is specific to some toolchains.

Quoted 10 lines

Therefore I will issue the ARM pull request right away.

Amicalement,
--
Albert.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Quoted 2 lines

Regards,
Simon

Best regards,
Marek Vasut

#5 lore raw

Hi Marek,

Quoted 32 lines · Marek Vasut

Dear Simon Glass,

Quoted 30 lines

+Marek

Hi Albert,

On Fri, Mar 30, 2012 at 12:08 AM, Albert ARIBAUD

Quoted 22 lines · <[email protected]> wrote:

Le 27/03/2012 22:18, Albert ARIBAUD a ?crit :

Quoted 8 lines

Hi all,

I have been away from the list quite a few days, and will have a very tricky time catching up, so with my apologies, I ask people who need me to apply patches or pull requests for the upcoming release to please send me a private e-mail and point me to the list message that I should be acting upon.

FWIW, ./MAKEALL arm on current u-boot-arm/master with CS toolchain 2010q1 builds 277 boards, of which none has errors and 167 have warnings.

The total count of warnings is 248, distributed as:

4 ? ? ? post.c:503: warning: #warning "Not implemented yet"

79 ? ? ?mmc.c:132: warning: no return statement in function returning non-void

165 ? ? ohci-hcd.c:{1307,1310,1313}: warning: dereferencing pointer 'pretmp.NNN' does break strict-aliasing rules

Quoted 7 lines
Quoted 3 lines

I did create a patch for this - it is marked delegated to Marek.

http://patchwork.ozlabs.org/patch/134600/

And stupid maintainer didn't look into it ... bad, bad maintainer. Accept my apology. But wasn't it decided with Mike that this was indeed a toolchain issue and not all toolchains choke on it?

:-)

Yes. It does feel like a broken toolchain (I felt that the original code should be warning free, even when I wrote my patch) but it seems that Albert gets this warning as well. Maybe we should fix it?

Quoted 28 lines
Quoted 28 lines
Quoted 7 lines

(the last one is actually 3 * 51 warnings)

The first one is obvious and should be dealt with, but I consider it not to be a blocker, for only 4 boards.

Quoted 6 lines

The second one seems straightforward to fix today, if not already submitted.

The third one may be an issue, but it could also be a zealous warning from the specific CS toolchain version I am using. Anyway, it does not seem ARM related as such.

Would be nice to get rid of it, but I think it is specific to some toolchains.

Quoted 10 lines

Therefore I will issue the ARM pull request right away.

Amicalement,
--
Albert.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Quoted 5 lines
Quoted 2 lines

Regards,
Simon

Best regards,
Marek Vasut

Regards,
Simon

#6 lore raw

Dear Simon Glass,

Quoted 43 lines

Hi Marek,

Quoted 33 lines · Marek Vasut

Dear Simon Glass,

Quoted 31 lines

+Marek

Hi Albert,

On Fri, Mar 30, 2012 at 12:08 AM, Albert ARIBAUD

Quoted 23 lines · <[email protected]> wrote:

Le 27/03/2012 22:18, Albert ARIBAUD a ?crit :

Quoted 8 lines

Hi all,

I have been away from the list quite a few days, and will have a very tricky time catching up, so with my apologies, I ask people who need me to apply patches or pull requests for the upcoming release to please send me a private e-mail and point me to the list message that I should be acting upon.

FWIW, ./MAKEALL arm on current u-boot-arm/master with CS toolchain 2010q1 builds 277 boards, of which none has errors and 167 have warnings.

The total count of warnings is 248, distributed as:

4 post.c:503: warning: #warning "Not implemented yet"

79 mmc.c:132: warning: no return statement in function returning
non-void

165 ohci-hcd.c:{1307,1310,1313}: warning: dereferencing pointer
'pretmp.NNN' does break strict-aliasing rules

Quoted 7 lines
Quoted 3 lines

I did create a patch for this - it is marked delegated to Marek.

http://patchwork.ozlabs.org/patch/134600/

And stupid maintainer didn't look into it ... bad, bad maintainer. Accept my apology. But wasn't it decided with Mike that this was indeed a toolchain issue and not all toolchains choke on it?

Quoted 6 lines

:
:-)

Yes. It does feel like a broken toolchain (I felt that the original code should be warning free, even when I wrote my patch) but it seems that Albert gets this warning as well. Maybe we should fix it?

I don't see this with ELDK 4.2 or 5.0 or 5.1 ;-)

Maybe fundamental rewrite of that code might help instead of adding bandaids ;-)

Quoted 34 lines
Quoted 26 lines
Quoted 26 lines
Quoted 11 lines

(the last one is actually 3 * 51 warnings)

The first one is obvious and should be dealt with, but I consider it not to be a blocker, for only 4 boards.

The second one seems straightforward to fix today, if not already submitted.

The third one may be an issue, but it could also be a zealous warning from the specific CS toolchain version I am using. Anyway, it does not seem ARM related as such.

Would be nice to get rid of it, but I think it is specific to some toolchains.

Quoted 10 lines

Therefore I will issue the ARM pull request right away.

Amicalement,
--
Albert.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Quoted 5 lines
Quoted 2 lines

Regards,
Simon

Best regards,
Marek Vasut

Regards,
Simon

#7 lore raw

Hi Marek,

Quoted 45 lines · Marek Vasut

Dear Simon Glass,

Quoted 43 lines

Hi Marek,

Quoted 40 lines · Marek Vasut

Dear Simon Glass,

Quoted 28 lines

+Marek

Hi Albert,

On Fri, Mar 30, 2012 at 12:08 AM, Albert ARIBAUD

Quoted 21 lines · <[email protected]> wrote:

Le 27/03/2012 22:18, Albert ARIBAUD a ?crit :

Quoted 8 lines

Hi all,

I have been away from the list quite a few days, and will have a very tricky time catching up, so with my apologies, I ask people who need me to apply patches or pull requests for the upcoming release to please send me a private e-mail and point me to the list message that I should be acting upon.

FWIW, ./MAKEALL arm on current u-boot-arm/master with CS toolchain 2010q1 builds 277 boards, of which none has errors and 167 have warnings.

The total count of warnings is 248, distributed as:

4 ? ? ? post.c:503: warning: #warning "Not implemented yet"

79 ? ? ?mmc.c:132: warning: no return statement in function returning non-void

Quoted 6 lines
Quoted 2 lines

165 ? ? ohci-hcd.c:{1307,1310,1313}: warning: dereferencing pointer 'pretmp.NNN' does break strict-aliasing rules

I did create a patch for this - it is marked delegated to Marek.

http://patchwork.ozlabs.org/patch/134600/

And stupid maintainer didn't look into it ... bad, bad maintainer. Accept my apology. But wasn't it decided with Mike that this was indeed a toolchain issue and not all toolchains choke on it?

Quoted 8 lines
Quoted 6 lines

:
:-)

Yes. It does feel like a broken toolchain (I felt that the original code should be warning free, even when I wrote my patch) but it seems that Albert gets this warning as well. Maybe we should fix it?

I don't see this with ELDK 4.2 or 5.0 or 5.1 ;-)

Nope. It only happens with some toolchains. That said, it blights my MAKEALL at present.

Quoted 2 lines

Maybe fundamental rewrite of that code might help instead of adding bandaids ;-)

Yes I'm sure, or even getting rid of the 3 separate versions of this file in U-Boot. Hope springs eternal.

Regards,
Simon

Quoted 35 lines
Quoted 35 lines
Quoted 27 lines
Quoted 27 lines
Quoted 6 lines

(the last one is actually 3 * 51 warnings)

The first one is obvious and should be dealt with, but I consider it not to be a blocker, for only 4 boards.

Quoted 6 lines

The second one seems straightforward to fix today, if not already submitted.

The third one may be an issue, but it could also be a zealous warning from the specific CS toolchain version I am using. Anyway, it does not seem ARM related as such.

Would be nice to get rid of it, but I think it is specific to some toolchains.

Quoted 10 lines

Therefore I will issue the ARM pull request right away.

Amicalement,
--
Albert.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Quoted 5 lines
Quoted 2 lines

Regards,
Simon

Best regards,
Marek Vasut

Regards,
Simon

#8 lore raw
In reply to Albert ARIBAUD

Hi Albert,

Quoted 9 lines · Albert ARIBAUD

Le 27/03/2012 22:18, Albert ARIBAUD a ?crit :

Quoted 7 lines

Hi all,

I have been away from the list quite a few days, and will have a very tricky time catching up, so with my apologies, I ask people who need me to apply patches or pull requests for the upcoming release to please send me a private e-mail and point me to the list message that I should be acting upon.

Quoted 6 lines

FWIW, ./MAKEALL arm on current u-boot-arm/master with CS toolchain 2010q1 builds 277 boards, of which none has errors and 167 have warnings.

The total count of warnings is 248, distributed as:

4 post.c:503: warning: #warning "Not implemented yet"

The 4 warnings come from our boards (Keymile ARM boards).

Quoted 3 lines

The first one is obvious and should be dealt with, but I consider it not to be a blocker, for only 4 boards.

I have just sent a patch that corrects this warning.

Regards

Valentin