Skip to contentSkip to conversation

ARM: include linux/bug.h in insn.c

PATCH New Joachim Eastwood 4 participants 4 messages Mar 30, 2012 – Mar 31, 2012 Arm (32-bit)

lore
Share & tools
lore

Joachim Eastwood

author
#0 lore raw

PATCH 1/1 ARM: include linux/bug.h in insn.c

After commit d82227cf8 building the kernel fails with:
arch/arm/kernel/insn.c: In function '__arm_gen_branch_thumb2':
arch/arm/kernel/insn.c:13: error: implicit declaration of function 'WARN_ON_ONCE' make[1]: *** [arch/arm/kernel/insn.o] Error 1
make: *** [arch/arm/kernel] Error 2

insn.c uses WARN_ON_ONCE so lets include bug.h.

Signed-off-by Joachim Eastwood <[email protected]>
---
 arch/arm/kernel/insn.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/kernel/insn.c +1 -0
index ab312e5..080fc70 100644
@@ -1,4 +1,5 @@
 #include <linux/kernel.h>
+#include <linux/bug.h>
 #include <asm/opcodes.h>
 
 static unsigned long
Signature · 1 line
1.7.9.2
#1 lore raw

PATCH 1/1 ARM: include linux/bug.h in insn.c

Quoted 1 line · Joachim Eastwood

After commit d82227cf8 building the kernel fails with:

Please also list the shortlog when giving a commit ID, i.e.

"ARM: 7331/1: extract out insn generation code from ftrace"

Thanks,
Paul.

Quoted 30 lines

?arch/arm/kernel/insn.c: In function '__arm_gen_branch_thumb2':
?arch/arm/kernel/insn.c:13: error: implicit declaration of function 'WARN_ON_ONCE' ?make[1]: *** [arch/arm/kernel/insn.o] Error 1
?make: *** [arch/arm/kernel] Error 2

insn.c uses WARN_ON_ONCE so lets include bug.h.

Signed-off-by Joachim Eastwood <[email protected]>

---
?arch/arm/kernel/insn.c | ? ?1 +
?1 file changed, 1 insertion(+)

arch/arm/kernel/insn.c +0 -0
index ab312e5..080fc70 100644
@@ -1,4 +1,5 @@

?#include <linux/kernel.h>
+#include <linux/bug.h>
?#include <asm/opcodes.h>

?static unsigned long
--
1.7.9.2

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw

PATCH 1/1 ARM: include linux/bug.h in insn.c

In reply to Joachim Eastwood
Quoted 7 lines · Joachim Eastwood

After commit d82227cf8 building the kernel fails with:
arch/arm/kernel/insn.c: In function '__arm_gen_branch_thumb2':
arch/arm/kernel/insn.c:13: error: implicit declaration of function 'WARN_ON_ONCE' make[1]: *** [arch/arm/kernel/insn.o] Error 1
make: *** [arch/arm/kernel] Error 2

insn.c uses WARN_ON_ONCE so lets include bug.h.

I already have this in my tree.

#3 lore raw

PATCH 1/1 ARM: include linux/bug.h in insn.c

In reply to Joachim Eastwood

Hello.

Quoted 1 line · Joachim Eastwood

After commit d82227cf8 building the kernel fails with:

Please also specify that commit summary in parens.

Quoted 6 lines

arch/arm/kernel/insn.c: In function '__arm_gen_branch_thumb2':

   arch/arm/kernel/insn.c:13: error: implicit declaration of function 'WARN_ON_ONCE'
   make[1]: *** [arch/arm/kernel/insn.o] Error 1
   make: *** [arch/arm/kernel] Error 2

insn.c uses WARN_ON_ONCE so lets include bug.h.

    Let's.
Quoted 1 line
Signed-off-by Joachim Eastwood<[email protected]>

WBR, Sergei