Skip to contentSkip to conversation

use: fix bit test

PATCH In review Lai Jiangshan 2 participants 3 messages Apr 2, 2012 – Apr 3, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 use: fix bit test

use & instead of the wrong &&

---

hw/usb/hcd-xhci.c +1 -1
index 73b0c7f..89c2406 100644
@@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci)
     int level = 0;
 
     if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE &&
-        xhci->usbcmd && USBCMD_INTE) {
+        xhci->usbcmd & USBCMD_INTE) {
         level = 1;
     }
 
#1 lore raw

Am 02.04.2012 08:35, schrieb Lai Jiangshan:

Quoted 4 lines

use & instead of the wrong &&

Patch looks okay but the subject should probably be fixed to say "usb:" when applying. :)

Andreas

Quoted 14 lines

---

hw/usb/hcd-xhci.c +1 -1
index 73b0c7f..89c2406 100644
@@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci)
     int level = 0;
 
     if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE &&
-        xhci->usbcmd && USBCMD_INTE) {
+        xhci->usbcmd & USBCMD_INTE) {
         level = 1;
     }
 
Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
#2 lore raw
Quoted 9 lines · Andreas Färber

Am 02.04.2012 08:35, schrieb Lai Jiangshan:

Quoted 4 lines

use & instead of the wrong &&

Patch looks okay but the subject should probably be fixed to say "usb:" when applying. :)

Thank you!!

Hi, Gerd,

Does this patch have any problem?
could you merge it with "use:"->"usb:" in the title. (I think it is not good to send another patch for this)

Thanks
Lai

Quoted 16 lines
Quoted 15 lines

---

hw/usb/hcd-xhci.c +1 -1
index 73b0c7f..89c2406 100644
@@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci)
     int level = 0;
 
     if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE &&
-        xhci->usbcmd && USBCMD_INTE) {
+        xhci->usbcmd & USBCMD_INTE) {
         level = 1;
     }