Skip to contentSkip to conversation

ARM: S3C24XX: fix missing common.h in mach-s3c24xx/

PATCH New Kukjin Kim 3 participants 5 messages Mar 29, 2012 – Apr 5, 2012

Subsystems (4)
lore
Share & tools
lore

Kukjin Kim

author
#0 lore raw

PATCH 1/1 ARM: S3C24XX: fix missing common.h in mach-s3c24xx/

This patch fixes missing mach-s3c24xx/common.h which has been lost when regarding s3c24xx directories merged.

---
 arch/arm/mach-s3c24xx/common.h |   23 +++++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-s3c24xx/common.h
arch/arm/mach-s3c24xx/common.h new file +23 -0
new file mode 100644
index 0000000..a7cd62f
@@ -0,0 +1,23 @@
+/*
+ * Copyright (c) 2012 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com
+ *
+ * Common Header for S3C24XX SoCs
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef __ARCH_ARM_MACH_S3C24XX_COMMON_H
+#define __ARCH_ARM_MACH_S3C24XX_COMMON_H
+
+#ifdef CONFIG_CPU_S3C2410
+void s3c2410_restart(char mode, const char *cmd);
+#endif
+
+#ifdef CONFIG_CPU_S3C244X
+void s3c244x_restart(char mode, const char *cmd);
+#endif
+
+#endif /* __ARCH_ARM_MACH_S3C24XX_COMMON_H */
Signature · 1 line
1.7.2.3
#1 lore raw

PATCH 1/1 ARM: S3C24XX: fix missing common.h in mach-s3c24xx/

Hello.

Quoted 26 lines · Kukjin Kim

This patch fixes missing mach-s3c24xx/common.h which has been lost when regarding s3c24xx directories merged.

---
  arch/arm/mach-s3c24xx/common.h |   23 +++++++++++++++++++++++
  1 files changed, 23 insertions(+), 0 deletions(-)

create mode 100644 arch/arm/mach-s3c24xx/common.h

arch/arm/mach-s3c24xx/common.h new file +11 -0
new file mode 100644
index 0000000..a7cd62f
@@ -0,0 +1,23 @@
+/*
+ * Copyright (c) 2012 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com
+ *
+ * Common Header for S3C24XX SoCs
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+

arch/arm/mach-s3c24xx/common.h line 21

Quoted 10 lines
arch/arm/mach-s3c24xx/common.h new file +10 -0
+#ifndef __ARCH_ARM_MACH_S3C24XX_COMMON_H
+#define __ARCH_ARM_MACH_S3C24XX_COMMON_H
+
+#ifdef CONFIG_CPU_S3C2410
+void s3c2410_restart(char mode, const char *cmd);
+#endif
+
+#ifdef CONFIG_CPU_S3C244X
+void s3c244x_restart(char mode, const char *cmd);
+#endif

Those #ifdef's around function prototypes are not necessary.

arch/arm/mach-s3c24xx/common.h line 23

Quoted 2 lines
arch/arm/mach-s3c24xx/common.h new file +2 -0
+
+#endif /* __ARCH_ARM_MACH_S3C24XX_COMMON_H */

WBR, Sergei

author
#2 lore raw

PATCH 1/1 ARM: S3C24XX: fix missing common.h in mach-s3c24xx/

Quoted 4 lines · Sergei Shtylyov

Hello.

On 29-03-2012 4:14, Kukjin Kim wrote:

[...]

Quoted 10 lines

arch/arm/mach-s3c24xx/common.h line 21

Quoted 7 lines
arch/arm/mach-s3c24xx/common.h new file +7 -0
+#ifdef CONFIG_CPU_S3C2410
+void s3c2410_restart(char mode, const char *cmd);
+#endif
+
+#ifdef CONFIG_CPU_S3C244X
+void s3c244x_restart(char mode, const char *cmd);
+#endif

Those #ifdef's around function prototypes are not necessary.

OK, thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#3 lore raw

PATCH 1/1 ARM: S3C24XX: fix missing common.h in mach-s3c24xx/

In reply to Kukjin Kim

Hi,

Quoted 2 lines · Kukjin Kim

This patch fixes missing mach-s3c24xx/common.h which has been lost when regarding s3c24xx directories merged.

Just checking that the updated version of this patch is headed in for 3.4 -- we are still seeing the failure in linux-next builds and it would be nice to close out the build regressions in there as quickly as possible, since they tend to mask other regressions from being seen.

Thanks,
Paul.
--

Quoted 44 lines

---
?arch/arm/mach-s3c24xx/common.h | ? 23 +++++++++++++++++++++++ ?1 files changed, 23 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/mach-s3c24xx/common.h

arch/arm/mach-s3c24xx/common.h new file +23 -1
new file mode 100644
index 0000000..a7cd62f
@@ -0,0 +1,23 @@
+/*
+ * Copyright (c) 2012 Samsung Electronics Co., Ltd.
+ * ? ? ? ? ? ? http://www.samsung.com
+ *
+ * Common Header for S3C24XX SoCs
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef __ARCH_ARM_MACH_S3C24XX_COMMON_H
+#define __ARCH_ARM_MACH_S3C24XX_COMMON_H
+
+#ifdef CONFIG_CPU_S3C2410
+void s3c2410_restart(char mode, const char *cmd);
+#endif
+
+#ifdef CONFIG_CPU_S3C244X
+void s3c244x_restart(char mode, const char *cmd);
+#endif
+
+#endif /* __ARCH_ARM_MACH_S3C24XX_COMMON_H */
--

1.7.2.3

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author
#4 lore raw

PATCH 1/1 ARM: S3C24XX: fix missing common.h in mach-s3c24xx/

Quoted 12 lines · Paul Gortmaker

Hi,

Quoted 2 lines · Kukjin Kim

This patch fixes missing mach-s3c24xx/common.h which has been lost when regarding s3c24xx directories merged.

Just checking that the updated version of this patch is headed in for 3.4 -- we are still seeing the failure in linux-next builds and it would be nice to close out the build regressions in there as quickly as possible, since they tend to mask other regressions from being seen.

Hi Paul,

Yeah right and I updated it in my -next.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.