Skip to contentSkip to conversation

make mce-test a submodule

RFC Wanlong Gao 5 participants 20 messages Mar 9, 2012 – May 31, 2012 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Wanlong Gao

author
#1 lore raw
Quoted 9 lines · Caspar Zhang

Hi Garrett, Andi, and all:

When I looked into current LTP tree, I found it a little messy due to some mce-test stuff, such as

- mce-test docs goes to $TOPDIR/README, and
- some mce-test files still lying under testcase/mce-test/.

I think we need a cleanup for it.

yes, I think so.

Quoted 3 lines

Also an idea comes to my mind, that we can try to make mce-test a submodule of LTP.

Not a bad idea.

Quoted 9 lines

I am also thinking about the pros and cons:

pro(s):
- easier for code maintenance, no need to sync periodically from
maintainer side

con(s):
- two extra steps added for LTP users, they have to do:

Quoted 8 lines
    $ git submodule init
    $ git submodule update
to enable using mce-test.

mce-test could no longer be found at kernel.org, so I cloned it from Andi's github repo, not sure if it is the right place:

git://github.com/andikleen/mce-test.git

The tree seems just a few update every month now, I wonder why intel guys didn't sync the commits to LTP ?

Quoted 4 lines

I have made this change to my personal LTP fork, you can review it here:

    https://github.com/casparant/ltp/commit/5cca17f633

The patch loooks good.

Thanks,
Wanlong Gao

Quoted 5 lines

Any comments are welcomed.

Thanks,
Caspar

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw

Hi all, I'll merge this change to master if I don't hear any objections from you by today.

Quoted 45 lines · Wanlong Gao
Quoted 9 lines · Caspar Zhang

Hi Garrett, Andi, and all:

When I looked into current LTP tree, I found it a little messy due to some mce-test stuff, such as

- mce-test docs goes to $TOPDIR/README, and
- some mce-test files still lying under testcase/mce-test/.

I think we need a cleanup for it.

yes, I think so.

Quoted 3 lines

Also an idea comes to my mind, that we can try to make mce-test a submodule of LTP.

Not a bad idea.

Quoted 9 lines

I am also thinking about the pros and cons:

pro(s):
- easier for code maintenance, no need to sync periodically from
maintainer side

con(s):
- two extra steps added for LTP users, they have to do:

Quoted 8 lines
    $ git submodule init
    $ git submodule update
to enable using mce-test.

mce-test could no longer be found at kernel.org, so I cloned it from Andi's github repo, not sure if it is the right place:

git://github.com/andikleen/mce-test.git

The tree seems just a few update every month now, I wonder why intel guys didn't sync the commits to LTP ?

Quoted 1 line
Quoted 6 lines
Quoted 3 lines

I have made this change to my personal LTP fork, you can review it here:

    https://github.com/casparant/ltp/commit/5cca17f633

The patch loooks good.

Wanlong, thanks for review.

Thanks,
Caspar

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#3 lore raw
Quoted 50 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections from you by today.

Quoted 45 lines · Wanlong Gao
Quoted 9 lines · Caspar Zhang

Hi Garrett, Andi, and all:

When I looked into current LTP tree, I found it a little messy due to some mce-test stuff, such as

- mce-test docs goes to $TOPDIR/README, and
- some mce-test files still lying under testcase/mce-test/.

I think we need a cleanup for it.

yes, I think so.

Quoted 3 lines

Also an idea comes to my mind, that we can try to make mce-test a submodule of LTP.

Not a bad idea.

Quoted 9 lines

I am also thinking about the pros and cons:

pro(s):
- easier for code maintenance, no need to sync periodically from
maintainer side

con(s):
- two extra steps added for LTP users, they have to do:

Quoted 8 lines
   $ git submodule init
   $ git submodule update
to enable using mce-test.

mce-test could no longer be found at kernel.org, so I cloned it from Andi's github repo, not sure if it is the right place:

git://github.com/andikleen/mce-test.git

The tree seems just a few update every month now, I wonder why intel guys didn't sync the commits to LTP ?

Quoted 1 line
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

I have made this change to my personal LTP fork, you can review it here:

   https://github.com/casparant/ltp/commit/5cca17f633

The patch loooks good.

Wanlong, thanks for review.

The goals for the patch are good and what I briefly looked over looked ok too. Can you pull certain versions of the mce-test submodule, or is it always HEAD?

Thanks!
-Garrett
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#4 lore raw
Quoted 54 lines · Garrett Cooper
Quoted 52 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections from you by today.

Quoted 47 lines · Wanlong Gao
Quoted 9 lines · Caspar Zhang

Hi Garrett, Andi, and all:

When I looked into current LTP tree, I found it a little messy due to some mce-test stuff, such as

- mce-test docs goes to $TOPDIR/README, and
- some mce-test files still lying under testcase/mce-test/.

I think we need a cleanup for it.

yes, I think so.

Quoted 3 lines

Also an idea comes to my mind, that we can try to make mce-test a submodule of LTP.

Not a bad idea.

Quoted 9 lines

I am also thinking about the pros and cons:

pro(s):
- easier for code maintenance, no need to sync periodically from
maintainer side

con(s):
- two extra steps added for LTP users, they have to do:

Quoted 8 lines
   $ git submodule init
   $ git submodule update
to enable using mce-test.

mce-test could no longer be found at kernel.org, so I cloned it from Andi's github repo, not sure if it is the right place:

git://github.com/andikleen/mce-test.git

The tree seems just a few update every month now, I wonder why intel guys didn't sync the commits to LTP ?

Quoted 3 lines

I have made this change to my personal LTP fork, you can review it here:

Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
   https://github.com/casparant/ltp/commit/5cca17f633

The patch loooks good.

Wanlong, thanks for review.

The goals for the patch are good and what I briefly looked over looked ok too. Can you pull certain versions of the mce-test submodule, or is it always HEAD?

I think the submodule head should be pulled by hand every time the mce tree updated.

Thanks,
Wanlong Gao

Quoted 2 lines

Thanks!
-Garrett

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#5 lore raw
In reply to Garrett Cooper
Quoted 54 lines · Garrett Cooper
Quoted 52 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections from you by today.

Quoted 47 lines · Wanlong Gao
Quoted 9 lines · Caspar Zhang

Hi Garrett, Andi, and all:

When I looked into current LTP tree, I found it a little messy due to some mce-test stuff, such as

- mce-test docs goes to $TOPDIR/README, and
- some mce-test files still lying under testcase/mce-test/.

I think we need a cleanup for it.

yes, I think so.

Quoted 3 lines

Also an idea comes to my mind, that we can try to make mce-test a submodule of LTP.

Not a bad idea.

Quoted 9 lines

I am also thinking about the pros and cons:

pro(s):
- easier for code maintenance, no need to sync periodically from
maintainer side

con(s):
- two extra steps added for LTP users, they have to do:

Quoted 8 lines
   $ git submodule init
   $ git submodule update
to enable using mce-test.

mce-test could no longer be found at kernel.org, so I cloned it from Andi's github repo, not sure if it is the right place:

git://github.com/andikleen/mce-test.git

The tree seems just a few update every month now, I wonder why intel guys didn't sync the commits to LTP ?

Quoted 3 lines

I have made this change to my personal LTP fork, you can review it here:

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
   https://github.com/casparant/ltp/commit/5cca17f633

The patch loooks good.

Wanlong, thanks for review.

The goals for the patch are good and what I briefly looked over looked ok too. Can you pull certain versions of the mce-test submodule, or is it always HEAD?

After git submodule update, it's always HEAD of mce-test.git

Actually, we don't store any files in LTP tree if mce-test becomes a submodule. A user need to execute "git submodule init && git submodule update" manually after cloning LTP if he wants to see mce-test sources inside LTP tree. If he needs to run mce-test with certain version, he can just do git checkout <mce-test-commit> insides testcases/kernel/mce-test/;

This would be a problem when doing release, git archive cannot include submodules, so we need to manually move mce-test sources into released package.

Thanks,
Caspar

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#6 lore raw
In reply to Caspar Zhang
Quoted 2 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections from you by today.

Fine for me. Copying Gong Chen who did most of the mce-test work recently too.

-Andi

Quoted 53 lines · Wanlong Gao
Quoted 50 lines · Caspar Zhang
Quoted 10 lines

Hi Garrett, Andi, and all:

When I looked into current LTP tree, I found it a little messy due to some mce-test stuff, such as

- mce-test docs goes to $TOPDIR/README, and
- some mce-test files still lying under testcase/mce-test/.

I think we need a cleanup for it.

yes, I think so.

Quoted 3 lines

Also an idea comes to my mind, that we can try to make mce-test a submodule of LTP.

Not a bad idea.

Quoted 9 lines

I am also thinking about the pros and cons:

pro(s):
- easier for code maintenance, no need to sync periodically from
maintainer side

con(s):
- two extra steps added for LTP users, they have to do:

Quoted 8 lines
    $ git submodule init
    $ git submodule update
to enable using mce-test.

mce-test could no longer be found at kernel.org, so I cloned it from Andi's github repo, not sure if it is the right place:

git://github.com/andikleen/mce-test.git

The tree seems just a few update every month now, I wonder why intel guys didn't sync the commits to LTP ?

Quoted 4 lines

I have made this change to my personal LTP fork, you can review it here:

    https://github.com/casparant/ltp/commit/5cca17f633
Quoted 9 lines
Quoted 1 line

The patch loooks good.

Wanlong, thanks for review.

Thanks,
Caspar

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#7 lore raw
Quoted 61 lines · Andi Kleen
Quoted 2 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections from you by today.

Fine for me. Copying Gong Chen who did most of the mce-test work recently too.

-Andi

Quoted 53 lines · Wanlong Gao
Quoted 36 lines · Caspar Zhang
Quoted 10 lines

Hi Garrett, Andi, and all:

When I looked into current LTP tree, I found it a little messy due to some mce-test stuff, such as

- mce-test docs goes to $TOPDIR/README, and
- some mce-test files still lying under testcase/mce-test/.

I think we need a cleanup for it.

yes, I think so.

Quoted 2 lines

Also an idea comes to my mind, that we can try to make mce-test a submodule of LTP.

Not a bad idea.

Quoted 8 lines

I am also thinking about the pros and cons:

pro(s):
- easier for code maintenance, no need to sync periodically from
maintainer side

con(s):
- two extra steps added for LTP users, they have to do:

Quoted 8 lines
     $ git submodule init
     $ git submodule update
to enable using mce-test.

mce-test could no longer be found at kernel.org, so I cloned it from Andi's github repo, not sure if it is the right place:

git://github.com/andikleen/mce-test.git

Quoted 8 lines

The tree seems just a few update every month now, I wonder why intel guys didn't sync the commits to LTP ?

Quoted 3 lines

I have made this change to my personal LTP fork, you can review it here:

     https://github.com/casparant/ltp/commit/5cca17f633

The patch loooks good.

Wanlong, thanks for review.

Thanks,
Caspar

Oh, yes. Recently I make a big change on mce-test project and old structure will be reorganized.
And I ever looked through the mce-test part in LTP. Unfortunately it is very old and can't run on
newer kernel. I hope you can keep current disabled status in LTP and wait my new work is merged.
We can talk at that time. Is it OK to you?

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#8 lore raw
Quoted 7 lines · Chen Gong
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections from you by today.

Fine for me. Copying Gong Chen who did most of the mce-test work recently too.

Quoted 8 lines
Quoted 1 line

-Andi

Oh, yes. Recently I make a big change on mce-test project and old structure will be reorganized.
And I ever looked through the mce-test part in LTP. Unfortunately it is very old and can't run on
newer kernel. I hope you can keep current disabled status in LTP and wait my new work is merged.
We can talk at that time. Is it OK to you?

Hi Chen Gong, sorry for late reply, we're planning to remove old static coded mce-test from LTP, and use it as a submodule, which means, mce-test won't be static-coded any more, it's always synced up with your upstream version, we just need to do some manual ``submodule update`` operations to checkout your version when doing a LTP release. So I'll merge this patch in, remove all current out-of-date codes, and wait for your notice of mce-test's next version, so that we can include it in our next LTP stable release.

Thanks,
Caspar

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#9 lore raw
Quoted 25 lines · Caspar Zhang
Quoted 7 lines · Chen Gong
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections from you by today.

Fine for me. Copying Gong Chen who did most of the mce-test work recently too.

Quoted 8 lines
Quoted 1 line

-Andi

Oh, yes. Recently I make a big change on mce-test project and old structure will be reorganized.
And I ever looked through the mce-test part in LTP. Unfortunately it is very old and can't run on
newer kernel. I hope you can keep current disabled status in LTP and wait my new work is merged.
We can talk at that time. Is it OK to you?

Hi Chen Gong, sorry for late reply, we're planning to remove old static coded mce-test from LTP, and use it as a submodule, which means, mce-test won't be static-coded any more, it's always synced up with your upstream version, we just need to do some manual ``submodule update`` operations to checkout your version when doing a LTP release. So I'll merge this patch in, remove all current out-of-date codes, and wait for your notice of mce-test's next version, so that we can include it in our next LTP stable release.

Quoted 3 lines

Thanks,
Caspar

It's fine to me. So do you want to get a notice from me after the codes are merged or you
monitor the upstream status by yourself?

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#10 lore raw
Quoted 26 lines · Chen Gong
Quoted 25 lines · Caspar Zhang
Quoted 7 lines · Chen Gong
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections from you by today.

Fine for me. Copying Gong Chen who did most of the mce-test work recently too.

Quoted 8 lines
Quoted 1 line

-Andi

Oh, yes. Recently I make a big change on mce-test project and old structure will be reorganized.
And I ever looked through the mce-test part in LTP. Unfortunately it is very old and can't run on
newer kernel. I hope you can keep current disabled status in LTP and wait my new work is merged.
We can talk at that time. Is it OK to you?

Hi Chen Gong, sorry for late reply, we're planning to remove old static coded mce-test from LTP, and use it as a submodule, which means, mce-test won't be static-coded any more, it's always synced up with your upstream version, we just need to do some manual ``submodule update`` operations to checkout your version when doing a LTP release. So I'll merge this patch in, remove all current out-of-date codes, and wait for your notice of mce-test's next version, so that we can include it in our next LTP stable release.

Quoted 6 lines
Quoted 3 lines

Thanks,
Caspar

It's fine to me. So do you want to get a notice from me after the codes are merged or you
monitor the upstream status by yourself?

I'd appreciate it if you can send me a mail when the codes get merged, but I'll check upstream status as well from time to time.

Thanks,
Caspar

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#11 lore raw
Quoted 30 lines · Caspar Zhang
Quoted 29 lines · Chen Gong
Quoted 28 lines · Caspar Zhang
Quoted 7 lines · Chen Gong
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections from you by today.

Fine for me. Copying Gong Chen who did most of the mce-test work recently too.

Quoted 8 lines
Quoted 1 line

-Andi

Oh, yes. Recently I make a big change on mce-test project and old structure will be reorganized.
And I ever looked through the mce-test part in LTP. Unfortunately it is very old and can't run on
newer kernel. I hope you can keep current disabled status in LTP and wait my new work is merged.
We can talk at that time. Is it OK to you?

Hi Chen Gong, sorry for late reply, we're planning to remove old static coded mce-test from LTP, and use it as a submodule, which means, mce-test won't be static-coded any more, it's always synced up with your upstream version, we just need to do some manual ``submodule update`` operations to checkout your version when doing a LTP release. So I'll merge this patch in, remove all current out-of-date codes, and wait for your notice of mce-test's next version, so that we can include it in our next LTP stable release.

Thanks,
Caspar

Quoted 9 lines
Quoted 3 lines

It's fine to me. So do you want to get a notice from me after the codes are merged or you
monitor the upstream status by yourself?

I'd appreciate it if you can send me a mail when the codes get merged, but I'll check upstream status as well from time to time.

Thanks,
Caspar

OK, I will. Now patch is in the review status, so I will tell you ASAP after merged.

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#12 lore raw
Quoted 34 lines · Chen Gong
Quoted 33 lines · Caspar Zhang
Quoted 32 lines · Chen Gong
Quoted 25 lines · Caspar Zhang
Quoted 7 lines · Chen Gong
Quoted 6 lines · Andi Kleen
Quoted 2 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections from you by today.

Fine for me. Copying Gong Chen who did most of the mce-test work recently too.

Quoted 8 lines
Quoted 1 line

-Andi

Oh, yes. Recently I make a big change on mce-test project and old structure will be reorganized.
And I ever looked through the mce-test part in LTP. Unfortunately it is very old and can't run on
newer kernel. I hope you can keep current disabled status in LTP and wait my new work is merged.
We can talk at that time. Is it OK to you?

Hi Chen Gong, sorry for late reply, we're planning to remove old static coded mce-test from LTP, and use it as a submodule, which means, mce-test won't be static-coded any more, it's always synced up with your upstream version, we just need to do some manual ``submodule update`` operations to checkout your version when doing a LTP release. So I'll merge this patch in, remove all current out-of-date codes, and wait for your notice of mce-test's next version, so that we can include it in our next LTP stable release.

Quoted 3 lines

Thanks,
Caspar

It's fine to me. So do you want to get a notice from me after the codes are merged or you
monitor the upstream status by yourself?

Quoted 7 lines
Quoted 6 lines

I'd appreciate it if you can send me a mail when the codes get merged, but I'll check upstream status as well from time to time.

Thanks,
Caspar

OK, I will. Now patch is in the review status, so I will tell you ASAP after merged.

Great, thanks Chen,

Wanlong Gao

Quoted 1 line

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#13 lore raw
In reply to Chen Gong
Quoted 11 lines · Chen Gong
Quoted 9 lines
Quoted 3 lines

It's fine to me. So do you want to get a notice from me after the codes are merged or you
monitor the upstream status by yourself?

I'd appreciate it if you can send me a mail when the codes get merged, but I'll check upstream status as well from time to time.

Thanks,
Caspar

OK, I will. Now patch is in the review status, so I will tell you ASAP after merged.

Thanks very much!

Caspar

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#14 lore raw
In reply to Chen Gong
Quoted 41 lines · Chen Gong
Quoted 40 lines · Caspar Zhang
Quoted 39 lines · Chen Gong
Quoted 32 lines · Caspar Zhang
Quoted 10 lines · Chen Gong
Quoted 9 lines · Andi Kleen
Quoted 3 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections
from you by today.

Fine for me. Copying Gong Chen who did most of the mce-test work recently
too.

-Andi

Quoted 8 lines

Oh, yes. Recently I make a big change on mce-test project and old structure will be reorganized.
And I ever looked through the mce-test part in LTP. Unfortunately it is
very old and can't run on
newer kernel. I hope you can keep current disabled status in LTP and wait my new work is merged.
We can talk at that time. Is it OK to you?

Hi Chen Gong, sorry for late reply, we're planning to remove old static
coded mce-test from LTP, and use it as a submodule, which means, mce-test won't be static-coded any more, it's always synced up with your
upstream version, we just need to do some manual ``submodule update`` operations to checkout your version when doing a LTP release. So I'll merge this patch in, remove all current out-of-date codes, and wait for
your notice of mce-test's next version, so that we can include it in our
next LTP stable release.

Quoted 3 lines

Thanks,
Caspar

It's fine to me. So do you want to get a notice from me after the codes are merged or you
monitor the upstream status by yourself?

Quoted 8 lines
Quoted 6 lines

I'd appreciate it if you can send me a mail when the codes get merged, but I'll check upstream status as well from time to time.

Thanks,
Caspar

OK, I will. Now patch is in the review status, so I will tell you ASAP after merged.

The new patch for mce-test has been merged, but it looks a little bit wrong during the merge procedure (all shell scripts execution right are missed). I'm pushing Andi to fix it, so please don't add mce-test at current stage. I will tell you when it is ready.

------------------------------------------------------------------------------
Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
_______________________________________________
Ltp-list mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#15 lore raw
Quoted 48 lines · Chen Gong
Quoted 47 lines · Chen Gong
Quoted 46 lines · Caspar Zhang
Quoted 33 lines · Chen Gong
Quoted 32 lines · Caspar Zhang
Quoted 10 lines · Chen Gong
Quoted 9 lines · Andi Kleen
Quoted 3 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections
from you by today.

Fine for me. Copying Gong Chen who did most of the mce-test work recently
too.

-Andi

Quoted 8 lines

Oh, yes. Recently I make a big change on mce-test project and old structure will be reorganized.
And I ever looked through the mce-test part in LTP. Unfortunately it is
very old and can't run on
newer kernel. I hope you can keep current disabled status in LTP and wait my new work is merged.
We can talk at that time. Is it OK to you?

Hi Chen Gong, sorry for late reply, we're planning to remove old static
coded mce-test from LTP, and use it as a submodule, which means, mce-test won't be static-coded any more, it's always synced up with your
upstream version, we just need to do some manual ``submodule update`` operations to checkout your version when doing a LTP release. So I'll merge this patch in, remove all current out-of-date codes, and wait for
your notice of mce-test's next version, so that we can include it in our
next LTP stable release.

Quoted 6 lines
Quoted 3 lines

Thanks,
Caspar

It's fine to me. So do you want to get a notice from me after the codes are merged or you
monitor the upstream status by yourself?

I'd appreciate it if you can send me a mail when the codes get merged, but I'll check upstream status as well from time to time.

Thanks,
Caspar

Quoted 6 lines
Quoted 2 lines

OK, I will. Now patch is in the review status, so I will tell you ASAP after merged.

The new patch for mce-test has been merged, but it looks a little bit wrong during the merge procedure (all shell scripts execution right are missed). I'm pushing Andi to fix it, so please don't add mce-test at current stage. I will tell you when it is ready.

Noted. Thanks for the update.

Thanks,
Caspar

------------------------------------------------------------------------------
Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
_______________________________________________
Ltp-list mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#16 lore raw
Quoted 46 lines · Caspar Zhang
Quoted 45 lines · Chen Gong
Quoted 44 lines · Chen Gong
Quoted 32 lines · Caspar Zhang
Quoted 31 lines · Chen Gong
Quoted 30 lines · Caspar Zhang
Quoted 8 lines · Chen Gong
Quoted 7 lines · Andi Kleen
Quoted 2 lines · Caspar Zhang

Hi all, I'll merge this change to master if I don't hear any objections from you by today.

Fine for me. Copying Gong Chen who did most of the mce-test work recently too.

Quoted 8 lines
Quoted 1 line

-Andi

Oh, yes. Recently I make a big change on mce-test project and old structure will be reorganized. And I ever looked through the mce-test part in LTP. Unfortunately it is very old and can't run on newer kernel. I hope you can keep current disabled status in LTP and wait my new work is merged. We can talk at that time. Is it OK to you?

Hi Chen Gong, sorry for late reply, we're planning to remove old static coded mce-test from LTP, and use it as a submodule, which means, mce-test won't be static-coded any more, it's always synced up with your upstream version, we just need to do some manual ``submodule update`` operations to checkout your version when doing a LTP release. So I'll merge this patch in, remove all current out-of-date codes, and wait for your notice of mce-test's next version, so that we can include it in our next LTP stable release.

Thanks, Caspar

Quoted 9 lines
Quoted 3 lines

It's fine to me. So do you want to get a notice from me after the codes are merged or you monitor the upstream status by yourself?

I'd appreciate it if you can send me a mail when the codes get merged, but I'll check upstream status as well from time to time.

Thanks, Caspar

OK, I will. Now patch is in the review status, so I will tell you ASAP after merged.

Quoted 9 lines
Quoted 4 lines

The new patch for mce-test has been merged, but it looks a little bit wrong during the merge procedure (all shell scripts execution right are missed). I'm pushing Andi to fix it, so please don't add mce-test at current stage. I will tell you when it is ready.

Noted. Thanks for the update.

Thanks, Caspar

Now I've gotten the account on lkml and create a project by my own. So now we can begin the merge work. If you have any suggestion, just let me know. The new project is under

git://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/mce-test.git
http://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/mce-test.git
https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/mce-test.git

The current status is ready to be merged.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#17 lore raw
Quoted 55 lines · Chen Gong
Quoted 54 lines · Caspar Zhang
Quoted 43 lines · Chen Gong
Quoted 42 lines · Chen Gong
Quoted 41 lines · Caspar Zhang
Quoted 29 lines · Chen Gong
Quoted 28 lines · Caspar Zhang
Quoted 8 lines · Chen Gong
Quoted 7 lines · Andi Kleen
Quoted 2 lines · Caspar Zhang

Hi all, I'll merge this change to master if I
don't hear any objections from you by today.

Fine for me. Copying Gong Chen who did most of the mce-test work recently too.

Quoted 8 lines
Quoted 1 line

-Andi

Oh, yes. Recently I make a big change on mce-test project and old structure will be reorganized. And I ever looked through the mce-test part in LTP. Unfortunately it is very old and can't run on newer kernel. I hope you can keep current disabled status in LTP and wait my new work is merged. We can talk at that time. Is it OK to you?

Hi Chen Gong, sorry for late reply, we're planning to remove old static coded mce-test from LTP, and use it as a submodule, which means, mce-test won't be static-coded any more, it's always synced up with your upstream version, we just need to do some manual ``submodule update`` operations to checkout your version when doing a LTP release. So I'll merge this patch in, remove all current out-of-date codes, and wait for your notice of mce-test's next version, so that we can include it in our next LTP stable release.

Quoted 5 lines
Quoted 2 lines

Thanks, Caspar

It's fine to me. So do you want to get a notice from me after the codes are merged or you monitor the upstream status by yourself?

I'd appreciate it if you can send me a mail when the codes get merged, but I'll check upstream status as well from time to time.

Thanks, Caspar

Quoted 7 lines
Quoted 2 lines

OK, I will. Now patch is in the review status, so I will tell you ASAP after merged.

The new patch for mce-test has been merged, but it looks a little bit wrong during the merge procedure (all shell scripts execution right are missed). I'm pushing Andi to fix it, so please don't add mce-test at current stage. I will tell you when it is ready.

Noted. Thanks for the update.

Quoted 9 lines
Quoted 2 lines

Thanks, Caspar

Now I've gotten the account on lkml and create a project by my own. So now we can begin the merge work. If you have any suggestion, just let me know. The new project is under

git://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/mce-test.git

http://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/mce-test.git

Quoted 4 lines

https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/mce-test.git

The current status is ready to be merged.

ping again

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#18 lore raw
Quoted 8 lines · Chen Gong

http://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/mce-test.git

Quoted 4 lines
Quoted 4 lines

https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/mce-test.git

The current status is ready to be merged.

ping again

Sorry for delaying. Thanks for the update! I'll update git URL soon.

Just an FYI, we won't merge the actual codes to our git repo, we will only do one-time pull & update when do a LTP release.

Thanks,
Caspar

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#19 lore raw
Quoted 4 lines · Caspar Zhang
Quoted 3 lines · Chen Gong

http://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/mce-test.git

Quoted 1 line
Quoted 1 line

https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/mce-test.git

Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines

The current status is ready to be merged.

ping again

Quoted 8 lines

Sorry for delaying. Thanks for the update! I'll update git URL soon.

Just an FYI, we won't merge the actual codes to our git repo, we will only do one-time pull & update when do a LTP release.

Thanks, Caspar

OK, thx a lot!

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#20 lore raw
In reply to a message not in the archive
Quoted 30 lines · Caspar Zhang

Hi Garrett, Andi, and all:

When I looked into current LTP tree, I found it a little messy due to some mce-test stuff, such as

- mce-test docs goes to $TOPDIR/README, and
- some mce-test files still lying under testcase/mce-test/.

I think we need a cleanup for it.

Also an idea comes to my mind, that we can try to make mce-test a submodule of LTP.

I am also thinking about the pros and cons:

pro(s):
- easier for code maintenance, no need to sync periodically from
maintainer side

con(s):
- two extra steps added for LTP users, they have to do:

    $ git submodule init
    $ git submodule update
to enable using mce-test.

mce-test could no longer be found at kernel.org, so I cloned it from Andi's github repo, not sure if it is the right place:

git://github.com/andikleen/mce-test.git

Quoted 8 lines

I have made this change to my personal LTP fork, you can review it here:

    https://github.com/casparant/ltp/commit/5cca17f633

Any comments are welcomed.

Thanks,
Caspar

Thanks all for reviewing this change. Patch merged.

Caspar

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list