Skip to contentSkip to conversation

fence_scsi_test: increment error count when reservation fails

PATCH New Ryan O'Hara 2 participants 2 messages Apr 9, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fence_scsi_test: increment error count when reservation fails

If the do_action_on subroutine fails to create a reservation, the error count should be incremented not set to zero.

Resolves: rhbz#809481

---
  fence/agents/scsi/fence_scsi_test.pl |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/fence/agents/scsi/fence_scsi_test.pl
index 5c2302c..c012a12 100755

fence/agents/scsi/fence_scsi_test.pl +1 -1
@@ -44,7 +44,7 @@ sub do_action_on (\@$$)
       if (scalar (get_keys_reserve ($dev)) == 0) {
  	if (do_reserve ($dev, $node_key) != 0) {
-	    $err = 0;
+	    $err++;
  	}
      }
  -- 1.7.1
 

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Attached Message Part
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20120409/aebee3f2/attachment.ksh>

#1 lore raw

PATCH 1/1 fence_scsi_test: increment error count when reservation fails

Quoted 4 lines · Ryan O'Hara

If the do_action_on subroutine fails to create a reservation, the error count should be incremented not set to zero.

Resolves: rhbz#809481

ACK

-- Lon