Skip to contentSkip to conversation

ARM: SAMSUNG: support sdhci controller

PATCH Superseded Jaehoon Chung 4 participants 5 messages Apr 12, 2012 – Apr 13, 2012

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Jaehoon Chung

author
#0 lore raw

PATCH v5 4/4 ARM: SAMSUNG: support sdhci controller

To support sdhci controller, remove the CONFIG_S5P_MMC.. Instead, use the CONFIG_S5P_SDHCI/CONFIG_SDHCI.

Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Acked-by Lei Wen<[email protected]>
---
 include/configs/origen.h            |    3 ++-
 include/configs/s5p_goni.h          |    3 ++-
 include/configs/s5pc210_universal.h |    3 ++-
 include/configs/smdk5250.h          |    3 ++-
 include/configs/smdkv310.h          |    3 ++-
 include/configs/trats.h             |    3 ++-
 6 files changed, 12 insertions(+), 6 deletions(-)
include/configs/origen.h +2 -1
index 8ede825..ea8066f 100644
@@ -71,7 +71,8 @@
 /* SD/MMC configuration */
 #define CONFIG_GENERIC_MMC		1
 #define CONFIG_MMC			1
-#define CONFIG_S5P_MMC			1
+#define CONFIG_SDHCI			1
+#define CONFIG_S5P_SDHCI		1
 
 /* PWM */
 #define CONFIG_PWM			1
include/configs/s5p_goni.h +2 -1
index 56b5547..f659699 100644
@@ -65,7 +65,8 @@
 /* MMC */
 #define CONFIG_GENERIC_MMC		1
 #define CONFIG_MMC			1
-#define CONFIG_S5P_MMC			1
+#define CONFIG_SDHCI			1
+#define CONFIG_S5P_SDHCI		1
 
 /* PWM */
 #define CONFIG_PWM			1
include/configs/s5pc210_universal.h +2 -1
index 1301275..241d209 100644
@@ -68,7 +68,8 @@
 /* MMC */
 #define CONFIG_GENERIC_MMC	1
 #define CONFIG_MMC		1
-#define CONFIG_S5P_MMC		1
+#define CONFIG_SDHCI		1
+#define CONFIG_S5P_SDHCI	1
 
 /* PWM */
 #define CONFIG_PWM			1
include/configs/smdk5250.h +2 -1
index 9659f9e..0f63040 100644
@@ -78,7 +78,8 @@
 /* SD/MMC configuration */
 #define CONFIG_GENERIC_MMC
 #define CONFIG_MMC
-#define CONFIG_S5P_MMC
+#define CONFIG_SDHCI
+#define CONFIG_S5P_SDHCI
 
 #define CONFIG_BOARD_EARLY_INIT_F
include/configs/smdkv310.h +2 -1
index 93c25da..077f0e0 100644
@@ -70,7 +70,8 @@
 /* SD/MMC configuration */
 #define CONFIG_GENERIC_MMC		1
 #define CONFIG_MMC			1
-#define CONFIG_S5P_MMC			1
+#define CONFIG_SDHCI			1
+#define CONFIG_S5P_SDHCI		1
 
 /* PWM */
 #define CONFIG_PWM			1
include/configs/trats.h +2 -1
index 10f11d9..71b9393 100644
@@ -74,7 +74,8 @@
 /* MMC */
 #define CONFIG_GENERIC_MMC
 #define CONFIG_MMC
-#define CONFIG_S5P_MMC
+#define CONFIG_S5P_SDHCI
+#define CONFIG_SDHCI
 
 /* PWM */
 #define CONFIG_PWM
#1 lore raw

PATCH v5 4/4 ARM: SAMSUNG: support sdhci controller

Quoted 6 lines · Jaehoon Chung

To support sdhci controller, remove the CONFIG_S5P_MMC.. Instead, use the CONFIG_S5P_SDHCI/CONFIG_SDHCI.

Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Acked-by Lei Wen<[email protected]>
Quoted 9 lines

---

?include/configs/origen.h ? ? ? ? ? ?| ? ?3 ++-
?include/configs/s5p_goni.h ? ? ? ? ?| ? ?3 ++-
?include/configs/s5pc210_universal.h | ? ?3 ++-
?include/configs/smdk5250.h ? ? ? ? ?| ? ?3 ++-
?include/configs/smdkv310.h ? ? ? ? ?| ? ?3 ++-
?include/configs/trats.h ? ? ? ? ? ? | ? ?3 ++-

?6 files changed, 12 insertions(+), 6 deletions(-)

Acked-by Minkyu Kang <[email protected]>
Signature · 2 lines
from. prom.
www.promsoft.net
#2 lore raw

PATCH v5 4/4 ARM: SAMSUNG: support sdhci controller

In reply to Jaehoon Chung

Hi Jaehoon,

Quoted 65 lines · Jaehoon Chung

To support sdhci controller, remove the CONFIG_S5P_MMC.. Instead, use the CONFIG_S5P_SDHCI/CONFIG_SDHCI.

Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Acked-by Lei Wen<[email protected]>

---

?include/configs/origen.h ? ? ? ? ? ?| ? ?3 ++-
?include/configs/s5p_goni.h ? ? ? ? ?| ? ?3 ++-
?include/configs/s5pc210_universal.h | ? ?3 ++-
?include/configs/smdk5250.h ? ? ? ? ?| ? ?3 ++-
?include/configs/smdkv310.h ? ? ? ? ?| ? ?3 ++-
?include/configs/trats.h ? ? ? ? ? ? | ? ?3 ++-

?6 files changed, 12 insertions(+), 6 deletions(-)

include/configs/origen.h +0 -0
index 8ede825..ea8066f 100644
@@ -71,7 +71,8 @@

?/* SD/MMC configuration */
?#define CONFIG_GENERIC_MMC ? ? ? ? ? ? 1
?#define CONFIG_MMC ? ? ? ? ? ? ? ? ? ? 1

include/configs/origen.h +2 -1
-#define CONFIG_S5P_MMC ? ? ? ? ? ? ? ? 1
+#define CONFIG_SDHCI ? ? ? ? ? ? ? ? ? 1
+#define CONFIG_S5P_SDHCI ? ? ? ? ? ? ? 1

?/* PWM */
?#define CONFIG_PWM ? ? ? ? ? ? ? ? ? ? 1

include/configs/s5p_goni.h +0 -0
index 56b5547..f659699 100644
@@ -65,7 +65,8 @@

?/* MMC */
?#define CONFIG_GENERIC_MMC ? ? ? ? ? ? 1
?#define CONFIG_MMC ? ? ? ? ? ? ? ? ? ? 1

include/configs/s5p_goni.h +2 -1
-#define CONFIG_S5P_MMC ? ? ? ? ? ? ? ? 1
+#define CONFIG_SDHCI ? ? ? ? ? ? ? ? ? 1
+#define CONFIG_S5P_SDHCI ? ? ? ? ? ? ? 1

?/* PWM */
?#define CONFIG_PWM ? ? ? ? ? ? ? ? ? ? 1

include/configs/s5pc210_universal.h +0 -0
index 1301275..241d209 100644
@@ -68,7 +68,8 @@

?/* MMC */
?#define CONFIG_GENERIC_MMC ? ? 1
?#define CONFIG_MMC ? ? ? ? ? ? 1

include/configs/s5pc210_universal.h +2 -1
-#define CONFIG_S5P_MMC ? ? ? ? 1
+#define CONFIG_SDHCI ? ? ? ? ? 1
+#define CONFIG_S5P_SDHCI ? ? ? 1

?/* PWM */
?#define CONFIG_PWM ? ? ? ? ? ? ? ? ? ? 1

include/configs/smdk5250.h +0 -0
index 9659f9e..0f63040 100644
@@ -78,7 +78,8 @@

?/* SD/MMC configuration */
?#define CONFIG_GENERIC_MMC
?#define CONFIG_MMC

include/configs/smdk5250.h line 82

Quoted 3 lines
include/configs/smdk5250.h +2 -1
-#define CONFIG_S5P_MMC
+#define CONFIG_SDHCI
+#define CONFIG_S5P_SDHCI

There is no consistency for the #define CONFIG_S5P_SDHCI, few have been assigned to value 1, And looking at the patchset the value of it is not used if I am not wrong, depending or defined or not some file is built. Best way could be not to assign any value for such cases, just #define CONFIG_S5P_SDHCI would make sense. It would be good If you also do the same for other CONFIG'S defined.

Thx,
--Prabhakar Lad

Quoted 35 lines

?#define CONFIG_BOARD_EARLY_INIT_F

include/configs/smdkv310.h +0 -0
index 93c25da..077f0e0 100644
@@ -70,7 +70,8 @@

?/* SD/MMC configuration */
?#define CONFIG_GENERIC_MMC ? ? ? ? ? ? 1
?#define CONFIG_MMC ? ? ? ? ? ? ? ? ? ? 1

include/configs/smdkv310.h +2 -1
-#define CONFIG_S5P_MMC ? ? ? ? ? ? ? ? 1
+#define CONFIG_SDHCI ? ? ? ? ? ? ? ? ? 1
+#define CONFIG_S5P_SDHCI ? ? ? ? ? ? ? 1

?/* PWM */
?#define CONFIG_PWM ? ? ? ? ? ? ? ? ? ? 1

include/configs/trats.h +0 -0
index 10f11d9..71b9393 100644
@@ -74,7 +74,8 @@

?/* MMC */
?#define CONFIG_GENERIC_MMC
?#define CONFIG_MMC

include/configs/trats.h +2 -1
-#define CONFIG_S5P_MMC
+#define CONFIG_S5P_SDHCI
+#define CONFIG_SDHCI

?/* PWM */
?#define CONFIG_PWM
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#3 lore raw

PATCH v5 4/4 ARM: SAMSUNG: support sdhci controller

Hi Prabhakar,

Quoted 2 lines · Prabhakar Lad

Hi Jaehoon,

[snip]

Quoted 7 lines

? ?There is no consistency for the #define ?CONFIG_S5P_SDHCI, ? ?few have been assigned to value 1, And looking at the patchset ? ?the value of it is not used if I am not wrong, depending or defined ? ?or not some file is built. Best way could be not to assign any value ? ?for such cases, just ?#define CONFIG_S5P_SDHCI would make ? ?sense. It would be good If you also do the same for other CONFIG'S ? ?defined.

All boolean defines should be #define'd with no value

Patches should be submitted to cleanup any that are currently defined with a value. Such patches should be marked 'cosmetic' and be distinctly seperate from any patches that are adding new code, prefferable prior to the patches addding new defines so each file always has a consistent style

Regards,

Graeme

#4 lore raw

PATCH v5 4/4 ARM: SAMSUNG: support sdhci controller

Quoted 17 lines · Graeme Russ

Hi Prabhakar,

Quoted 2 lines · Prabhakar Lad

Hi Jaehoon,

[snip]

Quoted 7 lines

? ?There is no consistency for the #define ?CONFIG_S5P_SDHCI, ? ?few have been assigned to value 1, And looking at the patchset ? ?the value of it is not used if I am not wrong, depending or defined ? ?or not some file is built. Best way could be not to assign any value ? ?for such cases, just ?#define CONFIG_S5P_SDHCI would make ? ?sense. It would be good If you also do the same for other CONFIG'S ? ?defined.

Quoted 8 lines

All boolean defines should be #define'd with no value

Patches should be submitted to cleanup any that are currently defined with a value. Such patches should be marked 'cosmetic' and be distinctly seperate from any patches that are adding new code, prefferable prior to the patches addding new defines so each file always has a consistent style

Regards,

Yes, right.
Need patch for cleanup.

Jaehoon,
Please update this patch.

I'll post cleanup patch for other defines.

Thanks.
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net