Skip to contentSkip to conversation

ARM: dts: remove blank interrupt-parent properties

PATCH New Rob Herring 3 participants 3 messages Apr 12, 2012 – Apr 15, 2012

Subsystems (2)
Device tree bindings Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 ARM: dts: remove blank interrupt-parent properties

From: Rob Herring <[email protected]>

These were incorrectly introduced and can cause problems for of_irq_init.

The correct way to define a root controller is no interrupt-parent set at all or the interrupt-parent is set to the root controller itself when inherited from a parent node.

Signed-off-by Rob Herring <[email protected]>

---
Arnd, Olof,

Please apply for 3.4.

Rob

 arch/arm/boot/dts/at91sam9g20.dtsi |    1 -
 arch/arm/boot/dts/at91sam9g45.dtsi |    1 -
 arch/arm/boot/dts/at91sam9x5.dtsi  |    1 -
 arch/arm/boot/dts/db8500.dtsi      |    1 -
 arch/arm/boot/dts/highbank.dts     |    1 -
 5 files changed, 5 deletions(-)
arch/arm/boot/dts/at91sam9g20.dtsi +0 -1
index 92f3662..6c33256 100644
@@ -55,7 +55,6 @@
 				#interrupt-cells = <2>;
 				compatible = "atmel,at91rm9200-aic";
 				interrupt-controller;
-				interrupt-parent;
 				reg = <0xfffff000 0x200>;
 			};
arch/arm/boot/dts/at91sam9g45.dtsi +0 -1
index 3d0c32f..2815be1 100644
@@ -56,7 +56,6 @@
 				#interrupt-cells = <2>;
 				compatible = "atmel,at91rm9200-aic";
 				interrupt-controller;
-				interrupt-parent;
 				reg = <0xfffff000 0x200>;
 			};
arch/arm/boot/dts/at91sam9x5.dtsi +0 -1
index c111001..1995c44 100644
@@ -54,7 +54,6 @@
 				#interrupt-cells = <2>;
 				compatible = "atmel,at91rm9200-aic";
 				interrupt-controller;
-				interrupt-parent;
 				reg = <0xfffff000 0x200>;
 			};
arch/arm/boot/dts/db8500.dtsi +0 -1
index d73dce6..14bc307 100644
@@ -24,7 +24,6 @@
 			#interrupt-cells = <3>;
 			#address-cells = <1>;
 			interrupt-controller;
-			interrupt-parent;
 			reg = <0xa0411000 0x1000>,
 			      <0xa0410100 0x100>;
 		};
arch/arm/boot/dts/highbank.dts +0 -1
index 357e780..4121b06 100644
@@ -100,7 +100,6 @@
 			#size-cells = <0>;
 			#address-cells = <1>;
 			interrupt-controller;
-			interrupt-parent;
 			reg = <0xfff11000 0x1000>,
 			      <0xfff10100 0x100>;
 		};
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: dts: remove blank interrupt-parent properties

Quoted 9 lines · Rob Herring

From: Rob Herring<[email protected]>

These were incorrectly introduced and can cause problems for of_irq_init.

The correct way to define a root controller is no interrupt-parent set at all or the interrupt-parent is set to the root controller itself when inherited from a parent node.

Signed-off-by Rob Herring<[email protected]>
Tested-by Lee Jones <[email protected]>

Works for me. Now I can use my GPIO chained IRQs correctly.

Quoted 74 lines

---
Arnd, Olof,

Please apply for 3.4.

Rob

  arch/arm/boot/dts/at91sam9g20.dtsi |    1 -
  arch/arm/boot/dts/at91sam9g45.dtsi |    1 -
  arch/arm/boot/dts/at91sam9x5.dtsi  |    1 -
  arch/arm/boot/dts/db8500.dtsi      |    1 -
  arch/arm/boot/dts/highbank.dts     |    1 -
  5 files changed, 5 deletions(-)
arch/arm/boot/dts/at91sam9g20.dtsi +0 -1
index 92f3662..6c33256 100644
@@ -55,7 +55,6 @@
  				#interrupt-cells =<2>;
  				compatible = "atmel,at91rm9200-aic";
  				interrupt-controller;
-				interrupt-parent;
  				reg =<0xfffff000 0x200>;
  			};
arch/arm/boot/dts/at91sam9g45.dtsi +0 -1
index 3d0c32f..2815be1 100644
@@ -56,7 +56,6 @@
  				#interrupt-cells =<2>;
  				compatible = "atmel,at91rm9200-aic";
  				interrupt-controller;
-				interrupt-parent;
  				reg =<0xfffff000 0x200>;
  			};
arch/arm/boot/dts/at91sam9x5.dtsi +0 -1
index c111001..1995c44 100644
@@ -54,7 +54,6 @@
  				#interrupt-cells =<2>;
  				compatible = "atmel,at91rm9200-aic";
  				interrupt-controller;
-				interrupt-parent;
  				reg =<0xfffff000 0x200>;
  			};
arch/arm/boot/dts/db8500.dtsi +0 -1
index d73dce6..14bc307 100644
@@ -24,7 +24,6 @@
  			#interrupt-cells =<3>;
  			#address-cells =<1>;
  			interrupt-controller;
-			interrupt-parent;
  			reg =<0xa0411000 0x1000>,
  			<0xa0410100 0x100>;
  		};
arch/arm/boot/dts/highbank.dts +0 -1
index 357e780..4121b06 100644
@@ -100,7 +100,6 @@
  			#size-cells =<0>;
  			#address-cells =<1>;
  			interrupt-controller;
-			interrupt-parent;
  			reg =<0xfff11000 0x1000>,
  			<0xfff10100 0x100>;
  		};
Signature · 5 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Applied
#2 lore raw

PATCH 1/1 ARM: dts: remove blank interrupt-parent properties

In reply to Rob Herring
Quoted 8 lines · Rob Herring

From: Rob Herring <[email protected]>

These were incorrectly introduced and can cause problems for of_irq_init.

The correct way to define a root controller is no interrupt-parent set at all or the interrupt-parent is set to the root controller itself when inherited from a parent node.

Quoted 5 lines
Signed-off-by Rob Herring <[email protected]>

---
Arnd, Olof,

Please apply for 3.4.

Thanks, applied.

-Olof