i.MX28: Shut down the LCD controller to avoid bootrom sampling bug
Subsystems (2)
PATCH 1/1 i.MX28: Shut down the LCD controller to avoid bootrom sampling bug
From: Marek Vasut <[email protected]>
--- drivers/video/mxsfb.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
drivers/video/mxsfb.c +13 -0
@@ -880,6 +880,18 @@ static int __devexit mxsfb_remove(struct platform_device *pdev)return 0 ; } +void mxsfb_shutdown (struct platform_device *pdev) +{ +struct fb_info *fb_info =platform_get_drvdata (pdev); +struct mxsfb_info *host =to_imxfb_host (fb_info); + +/* +* Force stop the LCD controller as keeping it running during reboot +* might interfere with the BootROM's boot mode pads sampling. +*/ +writel (CTRL_RUN , host->base +LCDC_CTRL +REG_CLR ); +} +static struct platform_device_id mxsfb_devtype[] = { { .name ="imx23-fb" ,
@@ -896,6 +908,7 @@ MODULE_DEVICE_TABLE(platform, mxsfb_devtype);static struct platform_driver mxsfb_driver = { .probe = mxsfb_probe, .remove =__devexit_p (mxsfb_remove), + .shutdown = mxsfb_shutdown, .id_table = mxsfb_devtype, .driver = { .name =DRIVER_NAME ,
Signature · 1 line
1.7.9.5
PATCH 1/1 i.MX28: Shut down the LCD controller to avoid bootrom sampling bug
Hello.
Quoted 16 lines · Marek Vasut
From: Marek Vasut<[email protected]>
Signed-off-by Marek Vasut<[email protected]>Cc Chen Peter-B29397<[email protected]>Cc Detlev Zundel<[email protected]>Cc Fabio Estevam<[email protected]>Cc Li Frank-B20596<[email protected]>Cc Lin Tony-B19295<[email protected]>Cc Linux USB<[email protected]>Cc Sascha Hauer<[email protected]>Cc Shawn Guo<[email protected]>Cc Shawn Guo<[email protected]>Cc Stefano Babic<[email protected]>Cc Subodh Nijsure<[email protected]>Cc Tony Lin<[email protected]>Cc Wolfgang Denk<[email protected]>
Quoted 3 lines
--- drivers/video/mxsfb.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
Why post this to linux-usb?
WBR, Sergei
PATCH 1/1 i.MX28: Shut down the LCD controller to avoid bootrom sampling bug
Dear Sergei Shtylyov,
Quoted 21 lines
Hello.
Quoted 18 lines · Marek Vasut
From: Marek Vasut<[email protected]>
Signed-off-by Marek Vasut<[email protected]>Cc Chen Peter-B29397<[email protected]>Cc Detlev Zundel<[email protected]>Cc Fabio Estevam<[email protected]>Cc Li Frank-B20596<[email protected]>Cc Lin Tony-B19295<[email protected]>Cc Linux USB<[email protected]>Cc Sascha Hauer<[email protected]>Cc Shawn Guo<[email protected]>Cc Shawn Guo<[email protected]>Cc Stefano Babic<[email protected]>Cc Subodh Nijsure<[email protected]>Cc Tony Lin<[email protected]>Cc Wolfgang Denk<[email protected]>---
Quoted 4 lines
Quoted 2 lines
drivers/video/mxsfb.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)Why post this to linux-usb?
Copy-paste mistake
Quoted 2 lines
WBR, Sergei
Best regards,
Marek Vasut
PATCH 1/1 i.MX28: Shut down the LCD controller to avoid bootrom sampling bug
In reply to Marek VasutQuoted 16 lines · Marek Vasut
From: Marek Vasut <[email protected]>
Signed-off-by Marek Vasut <[email protected]>Cc Chen Peter-B29397 <[email protected]>Cc Detlev Zundel <[email protected]>Cc Fabio Estevam <[email protected]>Cc Li Frank-B20596 <[email protected]>Cc Lin Tony-B19295 <[email protected]>Cc Linux USB <[email protected]>Cc Sascha Hauer <[email protected]>Cc Shawn Guo <[email protected]>Cc Shawn Guo <[email protected]>Cc Stefano Babic <[email protected]>Cc Subodh Nijsure <[email protected]>Cc Tony Lin <[email protected]>Cc Wolfgang Denk <[email protected]>
Quite a CC list, but you forgot the main ones:
FRAMEBUFFER LAYER
M: Florian Tobias Schandinat <[email protected]> L: linux-fbdev at vger.kernel.org
Patch itself looks good
Signature · 9 lines
Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120417/db1c2211/attachment.sig>
PATCH 1/1 i.MX28: Shut down the LCD controller to avoid bootrom sampling bug
Dear Wolfram Sang,
Quoted 18 lines · Marek Vasut
Quoted 16 lines
From: Marek Vasut <[email protected]>
Signed-off-by Marek Vasut <[email protected]>Cc Chen Peter-B29397 <[email protected]>Cc Detlev Zundel <[email protected]>Cc Fabio Estevam <[email protected]>Cc Li Frank-B20596 <[email protected]>Cc Lin Tony-B19295 <[email protected]>Cc Linux USB <[email protected]>Cc Sascha Hauer <[email protected]>Cc Shawn Guo <[email protected]>Cc Shawn Guo <[email protected]>Cc Stefano Babic <[email protected]>Cc Subodh Nijsure <[email protected]>Cc Tony Lin <[email protected]>Cc Wolfgang Denk <[email protected]>
Quoted 1 line
Quite a CC list, but you forgot the main ones:
Do you have a trimmed-down version of the list of mxs-related people possibly?
Quoted 6 lines
FRAMEBUFFER LAYER
M: Florian Tobias Schandinat <[email protected]> L: linux-fbdev at vger.kernel.orgPatch itself looks good
Who's applying this? The fbdev people or imx tree?
Quoted 2 lines
Acked-by Wolfram Sang <[email protected]>
Best regards,
Marek Vasut
PATCH 1/1 i.MX28: Shut down the LCD controller to avoid bootrom sampling bug
Quoted 4 lines
Quoted 2 lines
Quite a CC list, but you forgot the main ones:
Do you have a trimmed-down version of the list of mxs-related people possibly?
I usually CC Shawn, alkml and the driver authors and lists. There is nothing wrong with having more, you just happen to miss the crucial ones here. 'scripts/get_maintainers.pl' may also be helpful.
Quoted 8 lines
Quoted 6 lines
FRAMEBUFFER LAYER
M: Florian Tobias Schandinat <[email protected]> L: linux-fbdev at vger.kernel.orgPatch itself looks good
Who's applying this? The fbdev people or imx tree?
It is in drivers/video, so it should go via fbdev.
Signature · 9 lines
Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120417/2b21ad48/attachment.sig>
PATCH 1/1 i.MX28: Shut down the LCD controller to avoid bootrom sampling bug
Dear Wolfram Sang,
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Quite a CC list, but you forgot the main ones:
Do you have a trimmed-down version of the list of mxs-related people possibly?
I usually CC Shawn, alkml and the driver authors and lists. There is nothing wrong with having more, you just happen to miss the crucial ones here. '
scripts/get_maintainers.pl' may also be helpful.
A'ight, time for a resend.
Quoted 10 lines
Quoted 8 lines
Quoted 6 lines
FRAMEBUFFER LAYER
M: Florian Tobias Schandinat <[email protected]> L: linux-fbdev at vger.kernel.orgPatch itself looks good
Who's applying this? The fbdev people or imx tree?
It is in
drivers/video, so it should go via fbdev.
Right, thanks!
Best regards,
Marek Vasut