Skip to contentSkip to conversation

Make the unifont FONT_SOURCE configurable as --with-unifont=FILE

PATCH In review Mads Kiilerich 2 participants 3 messages Apr 6, 2012 – Apr 18, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Make the unifont FONT_SOURCE configurable as --with-unifont=FILE

Fonts might be located in different locations, and the default fonts (Unifont and DejaVu Sans) are not available on all systems or other fonts might be preferred.

2012-04-06 Mads Kiilerich <[email protected]>

* configure.ac: Make the unifont FONT_SOURCE configurable as
--with-unifont=FILE

=== modified file 'configure.ac'

configure.ac +16 -9
@@ -238,16 +238,23 @@
   AC_MSG_ERROR([bison is not found])
 fi
 
-FONT_SOURCE=
+AC_ARG_WITH([unifont],
+            AS_HELP_STRING([--with-unifont=FILE],
+                           [set the unifont source [[guessed]]]))
 
-for ext in pcf pcf.gz bdf bdf.gz ttf ttf.gz; do
-  for dir in . /usr/src /usr/share/fonts/X11/misc /usr/share/fonts/unifont; do
-    if test -f "$dir/unifont.$ext"; then
-      FONT_SOURCE="$dir/unifont.$ext"
-      break 2
-    fi
+if test "x$with_unifont" = x; then
+  FONT_SOURCE=
+  for ext in pcf pcf.gz bdf bdf.gz ttf ttf.gz; do
+    for dir in . /usr/src /usr/share/fonts/X11/misc /usr/share/fonts/unifont; do
+      if test -f "$dir/unifont.$ext"; then
+        FONT_SOURCE="$dir/unifont.$ext"
+        break 2
+      fi
+    done
   done
-done
+else
+  FONT_SOURCE="$with_unifont"
+fi
 
 if test "x$FONT_SOURCE" = x && ( test "x$platform" = xqemu || test "x$platform" = xloongson || test "x$platform" = xqemu_mips); then
    AC_MSG_ERROR([qemu and loongson ports need unifont])
@@ -930,7 +937,7 @@
 AC_SUBST([freetype_cflags])
 AC_SUBST([freetype_libs])
 
-DJVU_FONT_SOURCE=
+DJVU_FONT_SOURCE="$FONT_SOURCE"
 
 starfield_excuse=
 
#1 lore raw
Quoted 1 line · Mads Kiilerich

Fonts might be located in different locations,

If so, please supply the relevant locations. It's usually a bad idea to make user to think about where a file X is located on his system.

Quoted 3 lines

and the default fonts (Unifont and DejaVu Sans)
are not available on all systems or other fonts might be preferred.

There are reasons why exactly these fonts are chosen and their use in GRUB differs.
Unifont is chosen for comprehensive BMP coverage, while DejaVu Sans was chosen as a part of starfield theme design.

Signature · 2 lines
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
#2 lore raw
Quoted 10 lines · Vladimir 'φ-coder/phcoder' Serbinenko
Quoted 1 line · Mads Kiilerich

Fonts might be located in different locations,

If so, please supply the relevant locations. It's usually a bad idea to make user to think about where a file X is located on his system.

Quoted 3 lines

and the default fonts (Unifont and DejaVu Sans)
are not available on all systems or other fonts might be preferred.

There are reasons why exactly these fonts are chosen and their use in GRUB differs.
Unifont is chosen for comprehensive BMP coverage,

And also it's a monospace font used for terminal, you can't replace it with a proportional font.

Quoted 3 lines

while DejaVu Sans was
chosen as a part of starfield theme design.

Signature · 2 lines
Regards
Vladimir 'φ-coder/phcoder' Serbinenko