Skip to contentSkip to conversation

arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT

PATCH New Nobuhiro Iwamatsu 3 participants 5 messages Apr 18, 2012 – May 7, 2012

lore
Share & tools
lore

Nobuhiro Iwamatsu

author
#0 lore raw

PATCH 1/1 arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT

With almost all the architecture and board BOARD_LATE_INIT does not use. CONFIG_BOARD_LATE_INIT is used instead.
This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.

Signed-off-by Nobuhiro Iwamatsu <[email protected]>
CC Stefano Babic <[email protected]>
---
 board/davinci/ea20/ea20.c |    4 ++--
 include/configs/ea20.h    |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
board/davinci/ea20/ea20.c +2 -2
index 43632c2..7e00040 100644
@@ -272,7 +272,7 @@ int board_init(void)
 	return 0;
 }
 
-#ifdef BOARD_LATE_INIT
+#ifdef CONFIG_BOARD_LATE_INIT
 
 int board_late_init(void)
 {

@@ -287,7 +287,7 @@ int board_late_init(void)
 
 	return 0;
 }
-#endif /* BOARD_LATE_INIT */
+#endif /* CONFIG_BOARD_LATE_INIT */
 
 #ifdef CONFIG_DRIVER_TI_EMAC
include/configs/ea20.h +1 -1
index e059b30..2c44ddb 100644
@@ -31,7 +31,7 @@
 #define	CONFIG_SYS_USE_NAND
 #define CONFIG_DRIVER_TI_EMAC_USE_RMII
 #define CONFIG_BOARD_EARLY_INIT_F
-#define BOARD_LATE_INIT
+#define CONFIG_BOARD_LATE_INIT
 #define CONFIG_VIDEO
 #define CONFIG_PREBOOT
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT

Quoted 38 lines · Nobuhiro Iwamatsu

With almost all the architecture and board BOARD_LATE_INIT does not use. CONFIG_BOARD_LATE_INIT is used instead.
This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.

Signed-off-by Nobuhiro Iwamatsu <[email protected]>
CC Stefano Babic <[email protected]>
---
 board/davinci/ea20/ea20.c |    4 ++--
 include/configs/ea20.h    |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
board/davinci/ea20/ea20.c +2 -2
index 43632c2..7e00040 100644
@@ -272,7 +272,7 @@ int board_init(void)
 	return 0;
 }
 
-#ifdef BOARD_LATE_INIT
+#ifdef CONFIG_BOARD_LATE_INIT
 
 int board_late_init(void)
 {

@@ -287,7 +287,7 @@ int board_late_init(void)
 
 	return 0;
 }
-#endif /* BOARD_LATE_INIT */
+#endif /* CONFIG_BOARD_LATE_INIT */
 
 #ifdef CONFIG_DRIVER_TI_EMAC
include/configs/ea20.h +0 -0
index e059b30..2c44ddb 100644

include/configs/ea20.h line 37

Quoted 8 lines
include/configs/ea20.h +1 -1
@@ -31,7 +31,7 @@
 #define	CONFIG_SYS_USE_NAND
 #define CONFIG_DRIVER_TI_EMAC_USE_RMII
 #define CONFIG_BOARD_EARLY_INIT_F
-#define BOARD_LATE_INIT
+#define CONFIG_BOARD_LATE_INIT
 #define CONFIG_VIDEO
 #define CONFIG_PREBOOT
Acked-by Stefano Babic <[email protected]>

Thanks,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#2 lore raw

PATCH 1/1 arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT

In reply to Nobuhiro Iwamatsu

Hi Nobuhiro Iwamatsu,

Le 18/04/2012 04:41, Nobuhiro Iwamatsu a ?crit :

Quoted 3 lines

With almost all the architecture and board BOARD_LATE_INIT does not use. CONFIG_BOARD_LATE_INIT is used instead.
This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.

I think the commit message above is redundant with the commit summary, especially for a trivial one-line change. Can you just post a V2 patch with the same code change and commit summary, but without the commit message?

Amicalement,

Signature · 1 line
Albert.
#3 lore raw

PATCH 1/1 arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT

Le 19/04/2012 08:44, Albert ARIBAUD a ?crit :

Quoted 11 lines

Hi Nobuhiro Iwamatsu,

Le 18/04/2012 04:41, Nobuhiro Iwamatsu a ?crit :

Quoted 3 lines

With almost all the architecture and board BOARD_LATE_INIT does not use. CONFIG_BOARD_LATE_INIT is used instead.
This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.

I think the commit message above is redundant with the commit summary, especially for a trivial one-line change. Can you just post a V2 patch with the same code change and commit summary, but without the commit message?

... actually, you could apply this to all your elementary patches re BOARD_LATE_INIT, and then submit them in a single patch set.

Amicalement,

Signature · 1 line
Albert.
author
#4 lore raw

PATCH 1/1 arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT

Hi,

Sorry, reply is late.

2012/4/19 Albert ARIBAUD <[email protected]>:

Quoted 11 lines

Le 19/04/2012 08:44, Albert ARIBAUD a ?crit :

Quoted 9 lines

Hi Nobuhiro Iwamatsu,

Le 18/04/2012 04:41, Nobuhiro Iwamatsu a ?crit :

Quoted 4 lines

With almost all the architecture and board BOARD_LATE_INIT does not use. CONFIG_BOARD_LATE_INIT is used instead.
This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.

Quoted 9 lines
Quoted 4 lines

I think the commit message above is redundant with the commit summary, especially for a trivial one-line change. Can you just post a V2 patch with the same code change and commit summary, but without the commit message?

... actually, you could apply this to all your elementary patches re BOARD_LATE_INIT, and then submit them in a single patch set.

I thought that I would resend to one patch collectively. However, these were already taken into your repository. Thank you.

Best regards,
Nobuhiro

Signature · 1 line
Nobuhiro Iwamatsu