fdt: fix out of tree builds with DT support
PATCH 1/1 fdt: fix out of tree builds with DT support
Fix: FATAL ERROR: Couldn't open "../arch/arm/dts/tegra20.dtsi": No such file or directory
--- dts/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
dts/Makefile +1 -1
@@ -36,7 +36,7 @@ $(error Your architecture does not have device tree support enabled. \ Please define CONFIG_ARCH_DEVICE_TREE)) # We preprocess the device tree file provide a useful define -DTS_CPPFLAGS := -DARCH_CPU_DTS=\"../arch/$(ARCH)/dts/$(CONFIG_ARCH_DEVICE_TREE).dtsi\" +DTS_CPPFLAGS := -DARCH_CPU_DTS=\"$(SRCTREE)/arch/$(ARCH)/dts/$(CONFIG_ARCH_DEVICE_TREE).dtsi\" all: $(obj).depend $(LIB)
Signature · 1 line
1.7.7.6
PATCH 1/1 fdt: fix out of tree builds with DT support
Hi Wolfgang,
Quoted 2 lines · Wolfgang Denk
Fix: FATAL ERROR: Couldn't open "
../arch/arm/dts/tegra20.dtsi": No such file or directory
With this problem I have been pursuing include paths in dtc, since then we don't need CPP. This feature is now in dtc:
de6b762 dtc: Add -i option to support search paths
I have a patch to use that feature, so I will send it to the list.
Quoted 18 lines
Signed-off-by Wolfgang Denk <[email protected]>Cc Simon Glass <[email protected]>---
?dts/Makefile | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)dts/Makefile +0
-0@@ -36,7 +36,7 @@ $(error Your architecture does not have device tree support enabled. \ ?Please define CONFIG_ARCH_DEVICE_TREE))?# We preprocess the device tree file provide a useful define
dts/Makefile +1
-1-DTS_CPPFLAGS := -DARCH_CPU_DTS=\"../arch/$(ARCH)/dts/$(CONFIG_ARCH_DEVICE_TREE).dtsi\" +DTS_CPPFLAGS := -DARCH_CPU_DTS=\"$(SRCTREE)/arch/$(ARCH)/dts/$(CONFIG_ARCH_DEVICE_TREE).dtsi\"
Quoted 5 lines
?all: ? $(obj).depend $(LIB)
--
1.7.7.6
Regards,
Simon
PATCH 1/1 fdt: fix out of tree builds with DT support
Dear Simon,
Quoted 7 lines · In message <CAPnjgZ2eTmxeeFunjY=3tdwHjb9vjExJ7eWCim5LQEU+O3552w@mail.gmail.com>…
With this problem I have been pursuing include paths in dtc, since then we don't need CPP. This feature is now in dtc:
de6b762 dtc: Add -i option to support search paths
I have a patch to use that feature, so I will send it to the list.
Again, I would like to apply this patch, to fix this problem for the DTV versions that are currently in use in all the major distributions.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Nobody will ever need more than 640k RAM!" -- Bill Gates, 1981 "Windows 95 needs at least 8 MB RAM." -- Bill Gates, 1996 "Nobody will ever need Windows 95." -- logical conclusion
PATCH 1/1 fdt: fix out of tree builds with DT support
Hi Wolfgang,
Quoted 7 lines · Wolfgang Denk
Dear Simon,
Quoted 4 lines · In message <CAPnjgZ2eTmxeeFunjY=3tdwHjb9vjExJ7eWCim5LQEU+O3552w@mail.gmail.com>…
With this problem I have been pursuing include paths in dtc, since then we don't need CPP. This feature is now in dtc:
Quoted 6 lines
Quoted 3 lines
de6b762 dtc: Add -i option to support search paths
I have a patch to use that feature, so I will send it to the list.
Again, I would like to apply this patch, to fix this problem for the DTV versions that are currently in use in all the major distributions.
Fair enough. I hope that doesn't preclude us from using new features for too long.
Quoted 5 lines
Best regards,
Wolfgang Denk
Quoted 7 lines
--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Nobody will ever need more than 640k RAM!" ? ? ? -- Bill Gates, 1981 "Windows 95 needs at least 8 MB RAM." ? ? ? ? ? ? -- Bill Gates, 1996 "Nobody will ever need Windows 95." ? ? ? ? ? ? -- logical conclusion
Regards,
Simon
PATCH 1/1 fdt: fix out of tree builds with DT support
Dear Simon Glass,
Quoted 3 lines · In message <CAPnjgZ2-kzLW2-WdBk2qmezurJBPzT1vAHnxrf7RHZ_Xfw6YbA@mail.gmail.com>…
Fair enough. I hope that doesn't preclude us from using new features for too long.
Thanks.
Most distributions appear to pick up such changes not too fast, so we may run into issues here and there. I think we should decide this on a case by case base - here it was a trivial change to the existing code that fixed the problem.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de What the gods would destroy they first submit to an IEEE standards committee.
PATCH 1/1 fdt: fix out of tree builds with DT support
Quoted 7 lines · Wolfgang Denk
Dear Simon Glass,
Quoted 3 lines · In message <CAPnjgZ2-kzLW2-WdBk2qmezurJBPzT1vAHnxrf7RHZ_Xfw6YbA@mail.gmail.com>…
Fair enough. I hope that doesn't preclude us from using new features for too long.
Quoted 6 lines
Thanks.
Most distributions appear to pick up such changes not too fast, so we may run into issues here and there. I think we should decide this on a case by case base - here it was a trivial change to the existing code that fixed the problem.
The kernel deals with this by packaging a copy of dtc (the source) as part of the kernel source tree. Then, it can upgrade to new features as soon as they're needed without any distro dependency.
PATCH 1/1 fdt: fix out of tree builds with DT support
Hi Stephen,
Quoted 10 lines · Stephen Warren
Quoted 9 lines · Wolfgang Denk
Dear Simon Glass,
Quoted 3 lines · In message <CAPnjgZ2-kzLW2-WdBk2qmezurJBPzT1vAHnxrf7RHZ_Xfw6YbA@mail.gmail.com>…
Fair enough. I hope that doesn't preclude us from using new features for too long.
Thanks.
Quoted 8 lines
Quoted 4 lines
Most distributions appear to pick up such changes not too fast, so we may run into issues here and there. ?I think we should decide this on a case by case base - here it was a trivial change to the existing code that fixed the problem.
The kernel deals with this by packaging a copy of dtc (the source) as part of the kernel source tree. Then, it can upgrade to new features as soon as they're needed without any distro dependency.
Yes, I noticed that.
Another argument is that U-Boot / Linux shouldn't have anything to do with building device tree files, and therefore the tools are Someone Else's Problem - the flashing / packaging tools should do it.
I don't really have an opinion on this yet. Given the speed that dtc moves at, perhaps this is a problem we can live with for now.
Regards,
Simon
Wolfgang Denk
AppliedPATCH 1/1 fdt: fix out of tree builds with DT support
In reply to Wolfgang DenkDear Wolfgang Denk,
Quoted 8 lines · In message <[email protected]> you wrote:
Fix: FATAL ERROR: Couldn't open "
../arch/arm/dts/tegra20.dtsi": No such file or directorySigned-off-by Wolfgang Denk <[email protected]>Cc Simon Glass <[email protected]>--- dts/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de There are two ways of constructing a software design. One way is to make it so simple that there are obviously no deficiencies and the other is to make it so complicated that there are no obvious defi- ciencies. - Charles Anthony Richard Hoare