watchdog: mpcore: Add DT bindings for ARM mpcore watchdog

PATCH Superseded Viresh Kumar 4 participants 16 messages Apr 20, 2012 – Apr 24, 2012

Subsystems (3)

Device tree bindings Arm (32-bit) Watchdog device drivers

lore

Share & tools

lore

Viresh Kumar

author

2012-04-20 14:42 UTC #0 lore raw

PATCH 1/1 watchdog: mpcore: Add DT bindings for ARM mpcore watchdog

This patch adds Device tree bindings for ARM Mpcore watchdog. It also updates documentation for bindings.

Signed-off-by Viresh Kumar <[email protected]>

---
 .../bindings/watchdog/arm-mpcore-wdt.txt           |   19 +++++++++++++++++++
 drivers/watchdog/mpcore_wdt.c                      |   10 ++++++++++
 2 files changed, 29 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/watchdog/arm-mpcore-wdt.txt

Documentation/devicetree/bindings/watchdog/arm-mpcore-wdt.txt new file +19 -0

new file mode 100644
index 0000000..27a71aa
@@ -0,0 +1,19 @@
+* ARM MPCORE WATCHDOG
+
+Required properties:
+- compatible : "arm,mpcore-wdt"
+- reg : Address range of the wdt registers
+
+Optional Properties:
+- interrupt-parent: Should be the phandle for the interrupt controller
+  that services interrupts for this device
+- interrupt: Should contain the wdt interrupt number
+
+Example:
+
+	wdt at ec800620 {
+		compatible = "arm,mpcore-wdt";
+		reg = <0xec800620 0x1000>;
+		interrupt-parent = <&gic>;
+		interrupts = <1 14 0x301>;
+	};

drivers/watchdog/mpcore_wdt.c +10 -0

index 7c00455..f82625f 100644
@@ -27,6 +27,7 @@
 #include <linux/io.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/pm.h>
 #include <linux/reboot.h>

@@ -402,6 +403,14 @@ static SIMPLE_DEV_PM_OPS(mpcore_wdt_dev_pm_ops, mpcore_wdt_suspend,
 /* work with hotplug and coldplug */
 MODULE_ALIAS("platform:mpcore_wdt");
 
+#ifdef CONFIG_OF
+static const struct of_device_id mpcore_wdt_id_table[] = {
+	{ .compatible = "arm,mpcore-wdt" },
+	{}
+};
+MODULE_DEVICE_TABLE(of, mpcore_wdt_id_table);
+#endif
+
 static struct platform_driver mpcore_wdt_driver = {
 	.probe		= mpcore_wdt_probe,
 	.remove		= __devexit_p(mpcore_wdt_remove),

@@ -410,6 +419,7 @@ static struct platform_driver mpcore_wdt_driver = {
 		.owner	= THIS_MODULE,
 		.name	= "mpcore_wdt",
 		.pm	= &mpcore_wdt_dev_pm_ops,
+		.of_match_table = of_match_ptr(mpcore_wdt_id_table),
 	},
 };

Signature · 1 line

1.7.9

Pawel Moll

2012-04-21 08:32 UTC #1 lore raw

PATCH 1/1 watchdog: mpcore: Add DT bindings for ARM mpcore watchdog

Morning,

Dnia 2012-04-20, pi? o godzinie 20:12 +0530, Viresh Kumar pisze:

Quoted 7 lines

This patch adds Device tree bindings for ARM Mpcore watchdog. It also updates documentation for bindings.
Signed-off-by Viresh Kumar <[email protected]>
---
 .../bindings/watchdog/arm-mpcore-wdt.txt           |   19 +++++++++++++++++++
 drivers/watchdog/mpcore_wdt.c                      |   10 ++++++++++

Bindings for the MPCore TWD already exist in the tree:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=d8e0364364d333feb4564bb7d7d983182b34427e

I've Cc-ed Marc Zyngier, who is the author of the patch.

Regards

Pawel

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Viresh Kumar

author

2012-04-21 11:41 UTC #2 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

In reply to Viresh Kumar

This patch adds Device tree probing support for ARM Mpcore watchdog. Its binding were already documented in Documentation/devicetree/bindings/arm/twd.txt.

Signed-off-by Viresh Kumar <[email protected]>

---
V1->V2:
- Reuse earlier bindings defined in twd.txt

 drivers/watchdog/mpcore_wdt.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

drivers/watchdog/mpcore_wdt.c +12 -0

index 7c00455..98df379 100644
@@ -27,6 +27,7 @@
 #include <linux/io.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/pm.h>
 #include <linux/reboot.h>

@@ -402,6 +403,16 @@ static SIMPLE_DEV_PM_OPS(mpcore_wdt_dev_pm_ops, mpcore_wdt_suspend,
 /* work with hotplug and coldplug */
 MODULE_ALIAS("platform:mpcore_wdt");
 
+#ifdef CONFIG_OF
+static const struct of_device_id mpcore_wdt_id_table[] = {
+	{ .compatible = "arm,cortex-a9-twd-wdt" },
+	{ .compatible = "arm,cortex-a5-twd-wdt" },
+	{ .compatible = "arm,arm11mp-twd-wdt" },
+	{}
+};
+MODULE_DEVICE_TABLE(of, mpcore_wdt_id_table);
+#endif
+
 static struct platform_driver mpcore_wdt_driver = {
 	.probe		= mpcore_wdt_probe,
 	.remove		= __devexit_p(mpcore_wdt_remove),

@@ -410,6 +421,7 @@ static struct platform_driver mpcore_wdt_driver = {
 		.owner	= THIS_MODULE,
 		.name	= "mpcore_wdt",
 		.pm	= &mpcore_wdt_dev_pm_ops,
+		.of_match_table = of_match_ptr(mpcore_wdt_id_table),
 	},
 };

Signature · 1 line

1.7.9

Marc Zyngier

2012-04-23 08:36 UTC #3 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

Quoted 41 lines · Viresh Kumar

This patch adds Device tree probing support for ARM Mpcore watchdog. Its binding were already documented in Documentation/devicetree/bindings/arm/twd.txt.

Signed-off-by Viresh Kumar <[email protected]>

---
V1->V2:
- Reuse earlier bindings defined in twd.txt

 drivers/watchdog/mpcore_wdt.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

drivers/watchdog/mpcore_wdt.c +11 -0

index 7c00455..98df379 100644
@@ -27,6 +27,7 @@
 #include <linux/io.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/pm.h>
 #include <linux/reboot.h>

@@ -402,6 +403,16 @@ static SIMPLE_DEV_PM_OPS(mpcore_wdt_dev_pm_ops, mpcore_wdt_suspend,
 /* work with hotplug and coldplug */
 MODULE_ALIAS("platform:mpcore_wdt");
 
+#ifdef CONFIG_OF
+static const struct of_device_id mpcore_wdt_id_table[] = {
+	{ .compatible = "arm,cortex-a9-twd-wdt" },
+	{ .compatible = "arm,cortex-a5-twd-wdt" },
+	{ .compatible = "arm,arm11mp-twd-wdt" },
+	{}
+};
+MODULE_DEVICE_TABLE(of, mpcore_wdt_id_table);
+#endif
+
 static struct platform_driver mpcore_wdt_driver = {
 	.probe		= mpcore_wdt_probe,
 	.remove		= __devexit_p(mpcore_wdt_remove),

drivers/watchdog/mpcore_wdt.c static struct platform_driver mpcore_wdt_driver = { · line 427

Quoted 7 lines

drivers/watchdog/mpcore_wdt.c +1 -0

@@ -410,6 +421,7 @@ static struct platform_driver mpcore_wdt_driver = {
 		.owner	= THIS_MODULE,
 		.name	= "mpcore_wdt",
 		.pm	= &mpcore_wdt_dev_pm_ops,
+		.of_match_table = of_match_ptr(mpcore_wdt_id_table),
 	},
 };

Irk! Have you actually tested this?

The DT binding indicates:
- reg : Specify the base address and the size of the TWD watchdog register window.

while all the offsets in smp_twd.h are expressed in bytes from the TWD *timer* base. So you have to either fix these offsets (which breaks potential users of the non-DT version of the driver), or correct the base when using DT.

M.

Signature · 1 line

Jazz is not dead. It just smells funny...

viresh kumar

author

2012-04-23 11:35 UTC #4 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

Quoted 1 line · Marc Zyngier

Irk! Have you actually tested this?

Yes. But with incorrect base address. I passed timers address by mistake.

Quoted 8 lines

The DT binding indicates:
- reg : Specify the base address and the size of the TWD watchdog ? ? ? ?register window.
while all the offsets in smp_twd.h are expressed in bytes from the TWD *timer* base. So you have to either fix these offsets (which breaks potential users of the non-DT version of the driver), or correct the base when using DT.

You are correct. Which one do you prefer:
- Change bindings to pass timers base address
- subtract 0x20 from base address for DT case
- something else.

--
viresh

Marc Zyngier

2012-04-23 12:15 UTC #5 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

Quoted 4 lines · viresh kumar

Quoted 1 line · Marc Zyngier
Irk! Have you actually tested this?
Yes. But with incorrect base address. I passed timers address by mistake.

Ah, that explains why it worked. I suppose you do have additional patches that fix the IRQ request bit?

Quoted 11 lines

Quoted 8 lines
The DT binding indicates:
- reg : Specify the base address and the size of the TWD watchdog register window.
while all the offsets in smp_twd.h are expressed in bytes from the TWD *timer* base. So you have to either fix these offsets (which breaks potential users of the non-DT version of the driver), or correct the base when using DT.
You are correct. Which one do you prefer:
- Change bindings to pass timers base address

No. We already discussed this on LAK, and the outcome was the current binding, so let's not change that again.

Quoted 1 line

- subtract 0x20 from base address for DT case

That's a possibility.

Quoted 1 line

- something else.

Given that no in-tree platform seem to be using this watchdog (at least a quick grep didn't reveal anything), I'd be inclined to simply change the offset in smp_twd.h and let them break.

M.

Signature · 1 line

Jazz is not dead. It just smells funny...

viresh kumar

author

2012-04-23 12:21 UTC #6 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

Quoted 10 lines · Marc Zyngier

Quoted 1 line · viresh kumar
- subtract 0x20 from base address for DT case
That's a possibility.
Quoted 1 line
- something else.
Given that no in-tree platform seem to be using this watchdog (at least a quick grep didn't reveal anything), I'd be inclined to simply change the offset in smp_twd.h and let them break.

I believe atlest ST Ericsson's Ux500 series is using it, Linus??

Obviously the best solution is to fix these offsets and pass watchdog base address from DT or machine/board files.

I will see what i can do best.

--
viresh

viresh kumar

author

2012-04-23 14:21 UTC #7 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

In reply to Marc Zyngier

Quoted 2 lines · Marc Zyngier

Ah, that explains why it worked. I suppose you do have additional patches that fix the IRQ request bit?

Missed this earlier. That patchset is in review currently and have already fixed that. :)

Quoted 3 lines

Given that no in-tree platform seem to be using this watchdog (at least a quick grep didn't reveal anything), I'd be inclined to simply change the offset in smp_twd.h and let them break.

Even i can't find any users of it. :)

@Wim: Please apply following patch before this one. Here we go:

From: Viresh Kumar <[email protected]>
Date: Mon, 23 Apr 2012 19:39:47 +0530
Subject: [PATCH] ARM: SMP_TWD: WDOG: Start registers from 0x00 instead of
0x20

TWD_WDOG is at offset 0x20 from TWD base address. Current register offsets contain this extra 0x20 offset, i.e. users were required to pass base address of TWD instead of WDOG to WDOG driver.

Change this, so that users can pass base address of WDOG to WDOG driver instead of TWD module. For this, subtract 0x20 from offsets of WDOG registers.

This could break any current users of TWD_WDOG, but i couldn't find any users of this driver in current Linux tree. So, haven't fixed any platform code. If some platforms are broken please report to me, so that we can get them fixed in this patch only.

Signed-off-by Viresh Kumar <[email protected]>

---
 arch/arm/include/asm/smp_twd.h |   17 +++++++++++------
 1 files changed, 11 insertions(+), 6 deletions(-)

arch/arm/include/asm/smp_twd.h +3 -6

index 57857d1..ff3f67e 100644
@@ -6,12 +6,17 @@
 #define TWD_TIMER_CONTROL		0x08
 #define TWD_TIMER_INTSTAT		0x0C
 
-#define TWD_WDOG_LOAD			0x20
-#define TWD_WDOG_COUNTER		0x24
-#define TWD_WDOG_CONTROL		0x28
-#define TWD_WDOG_INTSTAT		0x2C
-#define TWD_WDOG_RESETSTAT		0x30
-#define TWD_WDOG_DISABLE		0x34
+/*
+ * TWD_WDOG is at offset 0x20 from TWD base address. Following register offsets
+ * doesn't contain this extra 0x20 offset, i.e. users of TWD_WDOG

must pass base
+ * address of WDOG to WDOG driver instead of TWD module.
+ */
+#define TWD_WDOG_LOAD 0x00
+#define TWD_WDOG_COUNTER 0x04
+#define TWD_WDOG_CONTROL 0x08
+#define TWD_WDOG_INTSTAT 0x0C
+#define TWD_WDOG_RESETSTAT 0x10
+#define TWD_WDOG_DISABLE 0x14

#define TWD_WDOG_LOAD_MIN 0x00000000
#define TWD_WDOG_LOAD_MAX 0xFFFFFFFF

Marc Zyngier

2012-04-23 15:22 UTC #8 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

Quoted 6 lines · viresh kumar

Quoted 2 lines · Marc Zyngier
Ah, that explains why it worked. I suppose you do have additional patches that fix the IRQ request bit?
Missed this earlier. That patchset is in review currently and have already fixed that. :)

Right. Please post that patch as a prerequisite for any other change.

Quoted 7 lines

Quoted 3 lines
Given that no in-tree platform seem to be using this watchdog (at least a quick grep didn't reveal anything), I'd be inclined to simply change the offset in smp_twd.h and let them break.
Even i can't find any users of it. :)
@Wim: Please apply following patch before this one.

Probably it would be better to keep everything in a single series, including the above IRQ fixes. It would surely make things easier for the maintainer and other people who are reviewing the changes you're making to the driver.

Quoted 45 lines

Here we go:
From: Viresh Kumar <[email protected]>
Date: Mon, 23 Apr 2012 19:39:47 +0530
Subject: [PATCH] ARM: SMP_TWD: WDOG: Start registers from 0x00 instead of
0x20
TWD_WDOG is at offset 0x20 from TWD base address. Current register offsets contain this extra 0x20 offset, i.e. users were required to pass base address of TWD instead of WDOG to WDOG driver.
Change this, so that users can pass base address of WDOG to WDOG driver instead of TWD module. For this, subtract 0x20 from offsets of WDOG registers.
This could break any current users of TWD_WDOG, but i couldn't find any users of this driver in current Linux tree. So, haven't fixed any platform code. If some platforms are broken please report to me, so that we can get them fixed in this patch only.
Signed-off-by Viresh Kumar <[email protected]>
---
 arch/arm/include/asm/smp_twd.h |   17 +++++++++++------
 1 files changed, 11 insertions(+), 6 deletions(-)
arch/arm/include/asm/smp_twd.h +3 -6
index 57857d1..ff3f67e 100644
@@ -6,12 +6,17 @@
 #define TWD_TIMER_CONTROL		0x08
 #define TWD_TIMER_INTSTAT		0x0C
 
-#define TWD_WDOG_LOAD			0x20
-#define TWD_WDOG_COUNTER		0x24
-#define TWD_WDOG_CONTROL		0x28
-#define TWD_WDOG_INTSTAT		0x2C
-#define TWD_WDOG_RESETSTAT		0x30
-#define TWD_WDOG_DISABLE		0x34
+/*
+ * TWD_WDOG is at offset 0x20 from TWD base address. Following register offsets
+ * doesn't contain this extra 0x20 offset, i.e. users of TWD_WDOG
must pass base
+ * address of WDOG to WDOG driver instead of TWD module.
+ */

arch/arm/include/asm/smp_twd.h

Quoted 9 lines

arch/arm/include/asm/smp_twd.h +6 -0

+#define TWD_WDOG_LOAD			0x00
+#define TWD_WDOG_COUNTER		0x04
+#define TWD_WDOG_CONTROL		0x08
+#define TWD_WDOG_INTSTAT		0x0C
+#define TWD_WDOG_RESETSTAT		0x10
+#define TWD_WDOG_DISABLE		0x14
 
 #define TWD_WDOG_LOAD_MIN		0x00000000
 #define TWD_WDOG_LOAD_MAX		0xFFFFFFFF

Now that we made it that far, why not moving the TWD_WDOG_* #defines to the driver itself? Nobody else should care about it anyway...

M.

Signature · 1 line

Jazz is not dead. It just smells funny...

viresh kumar

author

2012-04-23 15:33 UTC #9 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

Quoted 9 lines · Marc Zyngier

Quoted 6 lines · viresh kumar
Quoted 2 lines · Marc Zyngier
Ah, that explains why it worked. I suppose you do have additional patches that fix the IRQ request bit?
Missed this earlier. That patchset is in review currently and have already fixed that. :)
Right. Please post that patch as a prerequisite for any other change.

Haah!! I misread your question. I don't know how, but i thought you are asking me to fix this address for SPEAr (My SoC). And that patch set is currently in review.

I didn't get this IRQ request bit thing? Can you please explain.

Quoted 4 lines

Quoted 4 lines
Quoted 3 lines
Given that no in-tree platform seem to be using this watchdog (at least a quick grep didn't reveal anything), I'd be inclined to simply change the offset in smp_twd.h and let them break.

Quoted 8 lines

Quoted 3 lines
Even i can't find any users of it. :)
@Wim: Please apply following patch before this one.
Probably it would be better to keep everything in a single series, including the above IRQ fixes. It would surely make things easier for the maintainer and other people who are reviewing the changes you're making to the driver.

Even i would like to keep related patches in a single set. But i am doubtful about this IRQ thing.

Quoted 59 lines

Quoted 59 lines
Here we go:
From: Viresh Kumar <[email protected]>
Date: Mon, 23 Apr 2012 19:39:47 +0530
Subject: [PATCH] ARM: SMP_TWD: WDOG: Start registers from 0x00 instead of
0x20
TWD_WDOG is at offset 0x20 from TWD base address. Current register offsets
contain this extra 0x20 offset, i.e. users were required to pass base address of
TWD instead of WDOG to WDOG driver.
Change this, so that users can pass base address of WDOG to WDOG driver instead
of TWD module. For this, subtract 0x20 from offsets of WDOG registers.
This could break any current users of TWD_WDOG, but i couldn't find any users of
this driver in current Linux tree. So, haven't fixed any platform code. If some
platforms are broken please report to me, so that we can get them fixed in this
patch only.
Signed-off-by Viresh Kumar <[email protected]>
---
 arch/arm/include/asm/smp_twd.h |   17 +++++++++++------
 1 files changed, 11 insertions(+), 6 deletions(-)
arch/arm/include/asm/smp_twd.h +2 -6
index 57857d1..ff3f67e 100644
@@ -6,12 +6,17 @@
 #define TWD_TIMER_CONTROL		0x08
 #define TWD_TIMER_INTSTAT		0x0C
 
-#define TWD_WDOG_LOAD			0x20
-#define TWD_WDOG_COUNTER		0x24
-#define TWD_WDOG_CONTROL		0x28
-#define TWD_WDOG_INTSTAT		0x2C
-#define TWD_WDOG_RESETSTAT		0x30
-#define TWD_WDOG_DISABLE		0x34
+/*
+ * TWD_WDOG is at offset 0x20 from TWD base address. Following register
offsets
+ * doesn't contain this extra 0x20 offset, i.e. users of TWD_WDOG must pass base
+ * address of WDOG to WDOG driver instead of TWD module.
+ */
arch/arm/include/asm/smp_twd.h +6 -0
+#define TWD_WDOG_LOAD			0x00
+#define TWD_WDOG_COUNTER		0x04
+#define TWD_WDOG_CONTROL		0x08
+#define TWD_WDOG_INTSTAT		0x0C
+#define TWD_WDOG_RESETSTAT		0x10
+#define TWD_WDOG_DISABLE		0x14

Quoted 6 lines

Quoted 3 lines
#define TWD_WDOG_LOAD_MIN 0x00000000
#define TWD_WDOG_LOAD_MAX 0xFFFFFFFF
Now that we made it that far, why not moving the TWD_WDOG_* #defines to the driver itself? Nobody else should care about it anyway...

I thought of it too, but then left it. I thought this is done purposefully. Will move it once i get your concern on IRQ stuff.

--
viresh

Marc Zyngier

2012-04-23 15:49 UTC #10 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

Quoted 9 lines · viresh kumar

Quoted 8 lines · Marc Zyngier
Quoted 6 lines · viresh kumar
Quoted 2 lines · Marc Zyngier
Ah, that explains why it worked. I suppose you do have additional patches that fix the IRQ request bit?
Missed this earlier. That patchset is in review currently and have already fixed that. :)

Quoted 7 lines

Quoted 1 line
Right. Please post that patch as a prerequisite for any other change.
Haah!! I misread your question. I don't know how, but i thought you are asking me to fix this address for SPEAr (My SoC). And that patch set is currently in review.
I didn't get this IRQ request bit thing? Can you please explain.

The TWD watchdog uses a per-cpu interrupt (usually interrupt #30), and the GIC configuration should flag it as such. With this setup, request_irq() should fail, and the right API is request_percpu_irq(), together with enable_percpu_irq()/disable_percpu_irq().

So how it works in your environment is a bit puzzling. Unless you're not using GIC?

M.

Signature · 1 line

Jazz is not dead. It just smells funny...

viresh kumar

author

2012-04-23 16:01 UTC #11 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

Quoted 4 lines · Marc Zyngier

The TWD watchdog uses a per-cpu interrupt (usually interrupt #30), and the GIC configuration should flag it as such. With this setup, request_irq() should fail, and the right API is request_percpu_irq(), together with enable_percpu_irq()/disable_percpu_irq().

request_irq() doesn't fail for me even if i pass it.

Quoted 2 lines

So how it works in your environment is a bit puzzling. Unless you're not using GIC?

We use GIC and are running SMP. But we don't use wdt interrupt :) We only test it for system reset/reboot.

I don't have a patch for this. Can you please add that?

--
Viresh

Marc Zyngier

2012-04-23 16:12 UTC #12 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

Quoted 7 lines · viresh kumar

Quoted 4 lines · Marc Zyngier
The TWD watchdog uses a per-cpu interrupt (usually interrupt #30), and the GIC configuration should flag it as such. With this setup, request_irq() should fail, and the right API is request_percpu_irq(), together with enable_percpu_irq()/disable_percpu_irq().
request_irq() doesn't fail for me even if i pass it.

Well, it definitely should. Can you share the relevant part of your DT?

M.

Signature · 1 line

Jazz is not dead. It just smells funny...

viresh kumar

author

2012-04-23 16:16 UTC #13 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

Quoted 1 line · Marc Zyngier

Well, it definitely should. Can you share the relevant part of your DT?

I Just tested it once, and will do it tomorrow again.

			wdt at ec800620 {
				compatible = "arm,cortex-a9-twd-wdt";
				reg = <0xec800620 0x20>;
				interrupts = <1 14 0x301>;
				status = "disabled";
			};

Looking at your confidence, i am starting to feel, i am wrong here ;)

--
viresh

Marc Zyngier

2012-04-23 16:26 UTC #14 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

Quoted 5 lines · viresh kumar

Quoted 1 line · Marc Zyngier
Well, it definitely should. Can you share the relevant part of your DT?
I Just tested it once, and will do it tomorrow again.

Quoted 8 lines

			wdt at ec800620 {
				compatible = "arm,cortex-a9-twd-wdt";
				reg = <0xec800620 0x20>;
				interrupts = <1 14 0x301>;
				status = "disabled";
			};
Looking at your confidence, i am starting to feel, i am wrong here ;)

Well, having written the code that ensures request_irq() fails when passed a PPI, I'd be very worried if the above started to be working... ;-)

M.

Signature · 1 line

Jazz is not dead. It just smells funny...

Viresh Kumar

2012-04-24 10:25 UTC #15 lore raw

PATCH v2 1/1 watchdog: mpcore: Add DT probing support for ARM mpcore watchdog

Quoted 3 lines · Marc Zyngier

Quoted 1 line
Quoted 1 line
Looking at your confidence, i am starting to feel, i am wrong here ;)
Well, having written the code that ensures request_irq() fails when passed a PPI, I'd be very worried if the above started to be working...

And yes. I was wrong.

WARNING: at /home/vireshk/work/spear/kernel/linux-2.6/kernel/irq/manage.c:1368 request_threaded_irq+0x128/0x148()
Modules linked in:
Backtrace: 
[<c000c200>] (dump_backtrace+0x0/0x10c) from [<c0249814>] (dump_stack+0x18/0x1c)
 r6:00000558 r5:c005cb34 r4:00000000
[<c02497fc>] (dump_stack+0x0/0x1c) from [<c00157d4>] (warn_slowpath_common+0x54/0x6c)
[<c0015780>] (warn_slowpath_common+0x0/0x6c) from [<c0015810>] (warn_slowpath_null+0x24/0x28)
 r8:0000001e r7:c01f69c4 r6:00000000 r5:c033b840 r4:ee21770c
[<c00157ec>] (warn_slowpath_null+0x0/0x28) from [<c005cb34>] (request_threaded_irq+0x128/0x148)
[<c005ca0c>] (request_threaded_irq+0x0/0x148) from [<c005e95c>] (devm_request_threaded_irq+0x5c/0x94)
[<c005e900>] (devm_request_threaded_irq+0x0/0x94) from [<c02460b8>] (mpcore_wdt_probe+0x88/0x2d4)
[<c0246030>] (mpcore_wdt_probe+0x0/0x2d4) from [<c0180548>] (platform_drv_probe+0x20/0x24)
 r7:00000000 r6:ee101c08 r5:c03601e4 r4:c038abf4

Signature · 1 line

viresh