Skip to contentSkip to conversation

Makefile: Some updates to uninstall

PATCH In review Fabio Fantoni 2 participants 2 messages Apr 23, 2012 – Apr 24, 2012 Kbuild

lore
Share & tools
lore

Fabio Fantoni

author
#0 lore raw

PATCH v2 1/1 Makefile: Some updates to uninstall

# HG changeset patch
# User Fabio Fantoni
# Date 1335169615 -7200
# Node ID b3375cbe809eb8398b75cd2b1590b957134e01f8 # Parent 274e5accd62db09a7f703400c8720f7fdd95551a
Makefile: Some updates to uninstall

Signed-off-by Fabio Fantoni <[email protected]>
Makefile lun apr 23 10:26:55 2012 +0200 renamed from Makefile ven apr 20 09:49:06 2012 +0100 +0 -0
diff -r 274e5accd62d -r b3375cbe809e Makefile
@@ -220,13 +220,13 @@
 uninstall: D=$(DESTDIR)
 uninstall:
     [ -d $(D)$(XEN_CONFIG_DIR) ] && mv -f $(D)$(XEN_CONFIG_DIR)

$(D)$(XEN_CONFIG_DIR).old-date +%s || true

-    rm -rf $(D)$(CONFIG_DIR)/init.d/xend*
+    rm -rf $(D)$(CONFIG_DIR)/init.d/xendomains $(D)$(CONFIG_DIR)/init.d/xend
+    rm -rf $(D)$(CONFIG_DIR)/init.d/xencommons $(D)$(CONFIG_DIR)/init.d/xen-watchdog
     rm -rf $(D)$(CONFIG_DIR)/hotplug/xen-backend.agent
     rm -f  $(D)$(CONFIG_DIR)/udev/rules.d/xen-backend.rules
-    rm -f  $(D)$(CONFIG_DIR)/udev/xen-backend.rules
     rm -f  $(D)$(CONFIG_DIR)/udev/rules.d/xend.rules
-    rm -f  $(D)$(CONFIG_DIR)/udev/xend.rules
     rm -f  $(D)$(SYSCONFIG_DIR)/xendomains
+    rm -f  $(D)$(SYSCONFIG_DIR)/xencommons
     rm -rf $(D)/var/run/xen* $(D)/var/lib/xen*
     rm -rf $(D)/boot/*xen*
     rm -rf $(D)/lib/modules/*xen*
@@ -236,11 +236,16 @@
     rm -rf $(D)$(BINDIR)/pygrub
     rm -rf $(D)$(BINDIR)/setsize $(D)$(BINDIR)/tbctl
     rm -rf $(D)$(BINDIR)/xsls
-    rm -rf $(D)$(INCLUDEDIR)/xenctrl.h $(D)$(INCLUDEDIR)/xenguest.h
+    rm -rf $(D)$(BINDIR)/xenstore* $(D)$(BINDIR)/xentrace*
+    rm -rf $(D)$(BINDIR)/xen-detect $(D)$(BINDIR)/xencons
+    rm -rf $(D)$(BINDIR)/xenpvnetboot $(D)$(BINDIR)/qemu-*-xen
+    rm -rf $(D)$(INCLUDEDIR)/xenctrl* $(D)$(INCLUDEDIR)/xenguest.h
     rm -rf $(D)$(INCLUDEDIR)/xs_lib.h $(D)$(INCLUDEDIR)/xs.h
     rm -rf $(D)$(INCLUDEDIR)/xen
+    rm -rf $(D)$(INCLUDEDIR)/_libxl* $(D)$(INCLUDEDIR)/libxl*
+    rm -rf $(D)$(INCLUDEDIR)/xenstat.h $(D)$(INCLUDEDIR)/xentoollog.h
     rm -rf $(D)$(LIBDIR)/libxenctrl* $(D)$(LIBDIR)/libxenguest*
-    rm -rf $(D)$(LIBDIR)/libxenstore*
+    rm -rf $(D)$(LIBDIR)/libxenstore* $(D)$(LIBDIR)/libxlutil*
     rm -rf $(D)$(LIBDIR)/python/xen $(D)$(LIBDIR)/python/grub
     rm -rf $(D)$(LIBDIR)/xen/
     rm -rf $(D)$(LIBEXEC)/xen*
@@ -248,6 +253,7 @@
     rm -rf $(D)$(SBINDIR)/xen* $(D)$(SBINDIR)/netfix $(D)$(SBINDIR)/xm
     rm -rf $(D)$(SHAREDIR)/doc/xen
     rm -rf $(D)$(SHAREDIR)/xen
+    rm -rf $(D)$(SHAREDIR)/qemu-xen
     rm -rf $(D)$(MAN1DIR)/xen*
     rm -rf $(D)$(MAN8DIR)/xen*
     rm -rf $(D)/boot/tboot*

# HG changeset patch
# User Fabio Fantoni
# Date 1335169615 -7200
# Node ID b3375cbe809eb8398b75cd2b1590b957134e01f8 # Parent 274e5accd62db09a7f703400c8720f7fdd95551a
Makefile: Some updates to uninstall

Signed-off-by Fabio Fantoni <[email protected]>
Makefile +11 -5
diff -r 274e5accd62d -r b3375cbe809e Makefile
@@ -220,13 +220,13 @@
 uninstall: D=$(DESTDIR)
 uninstall:
 	[ -d $(D)$(XEN_CONFIG_DIR) ] && mv -f $(D)$(XEN_CONFIG_DIR) $(D)$(XEN_CONFIG_DIR).old-`date +%s` || true
-	rm -rf $(D)$(CONFIG_DIR)/init.d/xend*
+	rm -rf $(D)$(CONFIG_DIR)/init.d/xendomains $(D)$(CONFIG_DIR)/init.d/xend
+	rm -rf $(D)$(CONFIG_DIR)/init.d/xencommons $(D)$(CONFIG_DIR)/init.d/xen-watchdog
 	rm -rf $(D)$(CONFIG_DIR)/hotplug/xen-backend.agent
 	rm -f  $(D)$(CONFIG_DIR)/udev/rules.d/xen-backend.rules
-	rm -f  $(D)$(CONFIG_DIR)/udev/xen-backend.rules
 	rm -f  $(D)$(CONFIG_DIR)/udev/rules.d/xend.rules
-	rm -f  $(D)$(CONFIG_DIR)/udev/xend.rules
 	rm -f  $(D)$(SYSCONFIG_DIR)/xendomains
+	rm -f  $(D)$(SYSCONFIG_DIR)/xencommons
 	rm -rf $(D)/var/run/xen* $(D)/var/lib/xen*
 	rm -rf $(D)/boot/*xen*
 	rm -rf $(D)/lib/modules/*xen*

@@ -236,11 +236,16 @@
 	rm -rf $(D)$(BINDIR)/pygrub
 	rm -rf $(D)$(BINDIR)/setsize $(D)$(BINDIR)/tbctl
 	rm -rf $(D)$(BINDIR)/xsls
-	rm -rf $(D)$(INCLUDEDIR)/xenctrl.h $(D)$(INCLUDEDIR)/xenguest.h
+	rm -rf $(D)$(BINDIR)/xenstore* $(D)$(BINDIR)/xentrace*
+	rm -rf $(D)$(BINDIR)/xen-detect $(D)$(BINDIR)/xencons
+	rm -rf $(D)$(BINDIR)/xenpvnetboot $(D)$(BINDIR)/qemu-*-xen
+	rm -rf $(D)$(INCLUDEDIR)/xenctrl* $(D)$(INCLUDEDIR)/xenguest.h
 	rm -rf $(D)$(INCLUDEDIR)/xs_lib.h $(D)$(INCLUDEDIR)/xs.h
 	rm -rf $(D)$(INCLUDEDIR)/xen
+	rm -rf $(D)$(INCLUDEDIR)/_libxl* $(D)$(INCLUDEDIR)/libxl*
+	rm -rf $(D)$(INCLUDEDIR)/xenstat.h $(D)$(INCLUDEDIR)/xentoollog.h
 	rm -rf $(D)$(LIBDIR)/libxenctrl* $(D)$(LIBDIR)/libxenguest*
-	rm -rf $(D)$(LIBDIR)/libxenstore*
+	rm -rf $(D)$(LIBDIR)/libxenstore* $(D)$(LIBDIR)/libxlutil*
 	rm -rf $(D)$(LIBDIR)/python/xen $(D)$(LIBDIR)/python/grub
 	rm -rf $(D)$(LIBDIR)/xen/
 	rm -rf $(D)$(LIBEXEC)/xen*

@@ -248,6 +253,7 @@
 	rm -rf $(D)$(SBINDIR)/xen* $(D)$(SBINDIR)/netfix $(D)$(SBINDIR)/xm
 	rm -rf $(D)$(SHAREDIR)/doc/xen
 	rm -rf $(D)$(SHAREDIR)/xen
+	rm -rf $(D)$(SHAREDIR)/qemu-xen
 	rm -rf $(D)$(MAN1DIR)/xen*
 	rm -rf $(D)$(MAN8DIR)/xen*
 	rm -rf $(D)/boot/tboot*

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#1 lore raw

Fabio Fantoni writes ("[Xen-devel] [PATCH v2] Makefile: Some updates to uninstall"):

Quoted 3 lines

Makefile: Some updates to uninstall

Signed-off-by Fabio Fantoni <[email protected]>

I have applied this, TBH without more inspection than needed to convince myself it won't rm -rf /.

But I think this uninstall target is never tested and I would be surprised if any of the developers use it. So I think that it's unlikely to ever be reliable. Perhaps it would be better to remove it entirely.

Ian.