Skip to contentSkip to conversation

mx6qsabrelite: No need to set the direction for GPIO3_23 again

PATCH New Fabio Estevam 3 participants 3 messages Apr 11, 2012 – Apr 23, 2012

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 mx6qsabrelite: No need to set the direction for GPIO3_23 again

There is a 'gpio_direction_output(87, 0);' call previously, so the GPIO direction is already established.

Use gpio_set_value() for changing the GPIO output then.

Signed-off-by Fabio Estevam <[email protected]>
---
 board/freescale/mx6qsabrelite/mx6qsabrelite.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/freescale/mx6qsabrelite/mx6qsabrelite.c +1 -1
index 1d09a72..2155d87 100644
@@ -135,7 +135,7 @@ static void setup_iomux_enet(void)
 
 	/* Need delay 10ms according to KSZ9021 spec */
 	udelay(1000 * 10);
-	gpio_direction_output(87, 1);  /* GPIO 3-23 */
+	gpio_set_value(87, 1);  /* GPIO 3-23 */
 
 	imx_iomux_v3_setup_multiple_pads(enet_pads2, ARRAY_SIZE(enet_pads2));
 }
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 mx6qsabrelite: No need to set the direction for GPIO3_23 again

Quoted 15 lines · Fabio Estevam

There is a 'gpio_direction_output(87, 0);' call previously, so the GPIO direction is already established.

Use gpio_set_value() for changing the GPIO output then.

Signed-off-by Fabio Estevam<[email protected]>
---
  board/freescale/mx6qsabrelite/mx6qsabrelite.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
board/freescale/mx6qsabrelite/mx6qsabrelite.c +0 -0
index 1d09a72..2155d87 100644

board/freescale/mx6qsabrelite/mx6qsabrelite.c static void setup_iomux_enet(void) · line 141

Quoted 8 lines
board/freescale/mx6qsabrelite/mx6qsabrelite.c +1 -1
@@ -135,7 +135,7 @@ static void setup_iomux_enet(void)
 
  	/* Need delay 10ms according to KSZ9021 spec */
  	udelay(1000 * 10);
-	gpio_direction_output(87, 1);  /* GPIO 3-23 */
+	gpio_set_value(87, 1);  /* GPIO 3-23 */
 
  	imx_iomux_v3_setup_multiple_pads(enet_pads2, ARRAY_SIZE(enet_pads2));
  }
Acked-by Dirk Behme <[email protected]>

Thanks

Dirk

#2 lore raw

PATCH 1/1 mx6qsabrelite: No need to set the direction for GPIO3_23 again

In reply to Fabio Estevam
Quoted 7 lines · Fabio Estevam

There is a 'gpio_direction_output(87, 0);' call previously, so the GPIO direction is already established.

Use gpio_set_value() for changing the GPIO output then.

Signed-off-by Fabio Estevam <[email protected]>

---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================