Skip to contentSkip to conversation

TRATS: initialize panel_info data structure in board file

PATCH New Donghwa Lee 3 participants 3 messages Apr 25, 2012 – May 2, 2012

Subsystems (2)
Framebuffer layer Arm Samsung Exynos
lore
Share & tools
lore

Donghwa Lee

author
#0 lore raw

PATCH v2 1/1 TRATS: initialize panel_info data structure in board file

panel_info data structure is gloable variable, so, I have initialized it in board file. If it is initialized in init_panel_info() like existing, it can't be used in drv_lcd_init() in common/lcd.c because init_panel_info() is called after drv_lcd_init().

change of v1:
- I had made a mistake that must do not included variables of vidinfo_t
data structure was included in the file. So, I removed it.

Signed-off-by Donghwa Lee <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 board/samsung/trats/trats.c |   71 ++++++++++++++++++++++---------------------
 drivers/video/exynos_fb.c   |    3 --
 2 files changed, 36 insertions(+), 38 deletions(-)
board/samsung/trats/trats.c +36 -35
index 3085de1..084b67a 100644
@@ -455,43 +455,44 @@ static int mipi_power(void)
 	return 0;
 }
 
+vidinfo_t panel_info = {
+	.vl_freq	= 60,
+	.vl_col		= 720,
+	.vl_row		= 1280,
+	.vl_width	= 720,
+	.vl_height	= 1280,
+	.vl_clkp	= CONFIG_SYS_HIGH,
+	.vl_hsp		= CONFIG_SYS_LOW,
+	.vl_vsp		= CONFIG_SYS_LOW,
+	.vl_dp		= CONFIG_SYS_LOW,
+	.vl_bpix	= 5,	/* Bits per pixel, 2^5 = 32 */
+
+	/* s6e8ax0 Panel infomation */
+	.vl_hspw	= 5,
+	.vl_hbpd	= 10,
+	.vl_hfpd	= 10,
+
+	.vl_vspw	= 2,
+	.vl_vbpd	= 1,
+	.vl_vfpd	= 13,
+	.vl_cmd_allow_len = 0xf,
+
+	.win_id		= 3,
+	.cfg_gpio	= NULL,
+	.backlight_on	= NULL,
+	.lcd_power_on	= NULL,	/* lcd_power_on in mipi dsi driver */
+	.reset_lcd	= lcd_reset,
+	.dual_lcd_enabled = 0,
+
+	.init_delay	= 0,
+	.power_on_delay = 0,
+	.reset_delay	= 0,
+	.interface_mode = FIMD_RGB_INTERFACE,
+	.mipi_enabled	= 1,
+};
+
 void init_panel_info(vidinfo_t *vid)
 {
-	vid->vl_freq	= 60;
-	vid->vl_col	= 720;
-	vid->vl_row	= 1280;
-	vid->vl_width	= 720;
-	vid->vl_height	= 1280;
-	vid->vl_clkp	= CONFIG_SYS_HIGH;
-	vid->vl_hsp	= CONFIG_SYS_LOW;
-	vid->vl_vsp	= CONFIG_SYS_LOW;
-	vid->vl_dp	= CONFIG_SYS_LOW;
-
-	vid->vl_bpix	= 5;
-	vid->dual_lcd_enabled = 0;
-
-	/* s6e8ax0 Panel */
-	vid->vl_hspw	= 5;
-	vid->vl_hbpd	= 10;
-	vid->vl_hfpd	= 10;
-
-	vid->vl_vspw	= 2;
-	vid->vl_vbpd	= 1;
-	vid->vl_vfpd	= 13;
-	vid->vl_cmd_allow_len = 0xf;
-
-	vid->win_id = 3;
-	vid->cfg_gpio = NULL;
-	vid->backlight_on = NULL;
-	vid->lcd_power_on = NULL;	/* lcd_power_on in mipi dsi driver */
-	vid->reset_lcd = lcd_reset;
-
-	vid->init_delay = 0;
-	vid->power_on_delay = 0;
-	vid->reset_delay = 0;
-	vid->interface_mode = FIMD_RGB_INTERFACE;
-	vid->mipi_enabled = 1;
-
 	strcpy(s6e8ax0_platform_data.lcd_panel_name, mipi_lcd_device.name);
 	s6e8ax0_platform_data.lcd_power = lcd_power;
 	s6e8ax0_platform_data.mipi_power = mipi_power;
drivers/video/exynos_fb.c +0 -3
index a1cf449..96a8ec1 100644
@@ -44,9 +44,6 @@ short console_row;
 
 static unsigned int panel_width, panel_height;
 
-/* LCD Panel data */
-vidinfo_t panel_info;
-
 static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid)
 {
 	unsigned long palette_size;
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH v2 1/1 TRATS: initialize panel_info data structure in board file

Hi,

Quoted 9 lines · On Thu, 26 Apr 2012 08:29:39 +0900 Donghwa Lee <[email protected]> wrote:

panel_info data structure is gloable variable, so, I have initialized it in board file. If it is initialized in init_panel_info() like existing, it can't be used in drv_lcd_init() in common/lcd.c because init_panel_info() is called after drv_lcd_init().

change of v1:
- I had made a mistake that must do not included variables of vidinfo_t
data structure was included in the file. So, I removed it.

Quoted 6 lines
Signed-off-by Donghwa Lee <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 board/samsung/trats/trats.c |   71 ++++++++++++++++++++++---------------------
 drivers/video/exynos_fb.c   |    3 --
 2 files changed, 36 insertions(+), 38 deletions(-)
Acked-by Anatolij Gustschin <[email protected]>

This patch should also go through u-boot-samsung tree.

Thanks,
Anatolij

#2 lore raw

PATCH v2 1/1 TRATS: initialize panel_info data structure in board file

Quoted 14 lines · Anatolij Gustschin

Hi,

Quoted 9 lines · On Thu, 26 Apr 2012 08:29:39 +0900 Donghwa Lee <[email protected]> wrote:

panel_info data structure is gloable variable, so, I have initialized it in board file. If it is initialized in init_panel_info() like existing, it can't be used in drv_lcd_init() in common/lcd.c because init_panel_info() is called after drv_lcd_init().

change of v1:
?- I had made a mistake that must do not included variables of vidinfo_t data structure was included in the file. So, I removed it.

Quoted 9 lines
Quoted 6 lines
Signed-off-by Donghwa Lee <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

---
?board/samsung/trats/trats.c | ? 71 ++++++++++++++++++++++--------------------- ?drivers/video/exynos_fb.c ? | ? ?3 --
?2 files changed, 36 insertions(+), 38 deletions(-)

Acked-by Anatolij Gustschin <[email protected]>

applied to u-boot-samsung.

Thanks.
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net