Skip to contentSkip to conversation

ARM: davinci/da850-evm: fix section mismatch

PATCH New Uwe Kleine-König 2 participants 2 messages Mar 30, 2012 – Apr 26, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: davinci/da850-evm: fix section mismatch

This fixes:
WARNING: arch/arm/mach-davinci/built-in.o(.text+0x2d84): Section mismatch in reference from the function da850_evm_ui_expander_setup() to the (unknown reference) .init.data:(unknown) The function da850_evm_ui_expander_setup() references
the (unknown reference) __initdata (unknown).
This is often because da850_evm_ui_expander_setup lacks a __initdata
annotation or the annotation of (unknown) is wrong.

Note this is a real issue because if the tca6416 driver only binds when the init sections are already discarded da850_evm_ui_expander_setup is called when da850_evm_devices might already be overwritten.

---
 arch/arm/mach-davinci/board-da850-evm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-davinci/board-da850-evm.c +1 -1
index a70de24..09f6107 100644
@@ -284,7 +284,7 @@ static struct platform_device da850_evm_nandflash_device = {
 	.resource	= da850_evm_nandflash_resource,
 };
 
-static struct platform_device *da850_evm_devices[] __initdata = {
+static struct platform_device *da850_evm_devices[] = {
 	&da850_evm_nandflash_device,
 	&da850_evm_norflash_device,
 };
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: davinci/da850-evm: fix section mismatch

Hi Uwe,

Quoted 7 lines · Uwe Kleine-K?nig

This fixes:
WARNING: arch/arm/mach-davinci/built-in.o(.text+0x2d84): Section mismatch in reference from the function da850_evm_ui_expander_setup() to the (unknown reference) .init.data:(unknown) The function da850_evm_ui_expander_setup() references
the (unknown reference) __initdata (unknown).
This is often because da850_evm_ui_expander_setup lacks a __initdata
annotation or the annotation of (unknown) is wrong.

Quoted 5 lines

Note this is a real issue because if the tca6416 driver only binds when the init sections are already discarded da850_evm_ui_expander_setup is called when da850_evm_devices might already be overwritten.

Thanks for the patch. I am queuing this for v3.5 since the tca6416 driver is set to Y by default when DA850 EVM is selected. So I suspect users will mostly remain unaffected by the bug.

Thanks,
Sekhar