usb midi keyboard broken [3.3.3 regression]

PATCH New Jiri Slaby 5 participants 9 messages Apr 27, 2012 – Apr 30, 2012 4 messages not in the archive USB

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jiri Slaby

author

2012-04-27 07:46 UTC #4 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 6 lines · Steffen Müller

Quoted 6 lines
[  224.418062] usb 1-1.3: USB disconnect, device number 6 [
227.662396] usb 1-1.3: new full-speed USB device number 7 using ehci_hcd [ 227.749541] usb 1-1.3: New USB device found, idVendor=0763, idProduct=0192 [ 227.749550] usb 1-1.3: New USB device strings: Mfr=1, Product=2, SerialNumber=0 [ 227.749556] usb 1-1.3: Product: USB Keystation 88es [ 227.749560] usb 1-1.3:

Quoted 8 lines

Quoted 8 lines
Manufacturer: M-Audio [ 229.750236] ALSA midi.c:214 urb status -32 [ 229.750700] ALSA midi.c:214 urb status -32 [ 229.750911] ALSA midi.c:214 urb status -32 [ 229.751175] ALSA midi.c:214 urb status -32 [ 229.751413] ALSA midi.c:214 urb status -32 [ 229.751659] ALSA midi.c:214 urb status -32 [ 229.751910] ALSA midi.c:214 urb status -32 [ 229.752210] ALSA midi.c:214 urb status -32 [ 229.752459] ALSA midi.c:214 urb status -32 [ 229.752662] ALSA midi.c:214 urb status -32

Hmm... I suspect some USB patches added in 3.3.3... Alan, Greg, any ideas?

3.3.2 is reported to work.

thanks,
- --
js
suse labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPmk7tAAoJEL0lsQQGtHBJRjMQAISHi8yIkLvpJDZjKM/uY5px II9wXE8D4rhgjXaeOADFS92lPyaLES1IJYRudh5QRRsOfguU7y0iZSbqukpaaJse EOcQSRvtKjzQOn0qmvAuYDORYLWELJG+TDeMas+4ecBFygEmzIAkmgULJsw1dkQR L7H7B+pVL9lKdBQg0annMxxqPkxbrRL8kYu4ZkNOLhKdk6SNcMw4KBq7xVQc1Jfa GwDdHdpE6/2D9UE4fiEU4q7FTCeF+on1GYnpw8+P6CJT2ovNcp0GF1TeW4q5yAMx YgkOjyUXzYnbz5j9jHVkZgOgCXKudj/AdexuehMnC+YXqPFG40cc0KHWHhBh5LbG 7TJ6zJ0bby7yazk3mV1P099eR6YinB7zsHWHhW6COwh4t6ZeWOAQVUbL2mAFoOZy Dq9S8wVnQKj+/M5ewWjTnX6yVbySJ/wDfVRx+HRiyEvARqFyHC9EdAsQG+aHHlU1 RDu+56CprOnkvsNXaZUabRUZVfOyVfpYeWBXEkcd8nSDmqUnnOUpgy4035YjTsAf MU8ph+r3PqepDyjW1uaE+CTApGjD38Dxrt070yxtqOhBntBZp/WXYUkDq5BQEcnr o35xfluDIiUQzhYzbO92Qr+MA03moVcQXG72s+2cnAWdTw5+zo3VCHfEgZtdpmFN 2mRV1ljPbjt9314rGTXv
=vE/l
-----END PGP SIGNATURE-----

Alan Stern

2012-04-27 15:26 UTC #5 lore raw

Quoted 16 lines · Jiri Slaby

Quoted 6 lines · Steffen M�ller
Quoted 6 lines
[  224.418062] usb 1-1.3: USB disconnect, device number 6 [
227.662396] usb 1-1.3: new full-speed USB device number 7 using ehci_hcd [ 227.749541] usb 1-1.3: New USB device found, idVendor=0763, idProduct=0192 [ 227.749550] usb 1-1.3: New USB device strings: Mfr=1, Product=2, SerialNumber=0 [ 227.749556] usb 1-1.3: Product: USB Keystation 88es [ 227.749560] usb 1-1.3:
Quoted 8 lines
Quoted 8 lines
Manufacturer: M-Audio [ 229.750236] ALSA midi.c:214 urb status -32 [ 229.750700] ALSA midi.c:214 urb status -32 [ 229.750911] ALSA midi.c:214 urb status -32 [ 229.751175] ALSA midi.c:214 urb status -32 [ 229.751413] ALSA midi.c:214 urb status -32 [ 229.751659] ALSA midi.c:214 urb status -32 [ 229.751910] ALSA midi.c:214 urb status -32 [ 229.752210] ALSA midi.c:214 urb status -32 [ 229.752459] ALSA midi.c:214 urb status -32 [ 229.752662] ALSA midi.c:214 urb status -32

Quoted 3 lines

Hmm... I suspect some USB patches added in 3.3.3... Alan, Greg, any ideas?
3.3.2 is reported to work.

No ideas. It would be good to see a usbmon trace, with as many other USB devices unplugged as possible. Even better would be to see also a second usbmon trace from a working kernel.

Alan Stern

Steffen Müller

2012-04-28 11:46 UTC #6 lore raw

Re: [opensuse-factory] Re: usb midi keyboard broken [3.3.3 regression] [SOLUTION]

Oh man! After look and try many usr relevant settings I found the malfactor:
tlp usb autosuspend settings.

I use tlp (energy-saving tools for thinkpad laptops) and they autosuspend usb devices by default. Now I have blacklisted my midi keyboard an all is good. I can reproduce the problem this way. Seems so that the midi keyboard doesn't wake up if it once sleeping.

For all with similar problems:
edit /etc/default/tlp and set USB_BLACKLIST="<device id from usbls>" or disable usb autosuspend entirely with USB_AUTOSUSPEND=0

thanks and sorry for the bother.
steffen

Am Freitag, 27. April 2012, 11:26:12 schrieb Alan Stern:

Quoted 26 lines · Jiri Slaby

Quoted 16 lines · Steffen M�ller
Quoted 6 lines
Quoted 6 lines
[  224.418062] usb 1-1.3: USB disconnect, device number 6 [
227.662396] usb 1-1.3: new full-speed USB device number 7 using ehci_hcd [ 227.749541] usb 1-1.3: New USB device found, idVendor=0763, idProduct=0192 [ 227.749550] usb 1-1.3: New USB device strings: Mfr=1, Product=2, SerialNumber=0 [ 227.749556] usb 1-1.3: Product: USB Keystation 88es [ 227.749560] usb 1-1.3:
Quoted 8 lines
Quoted 8 lines
Manufacturer: M-Audio [ 229.750236] ALSA midi.c:214 urb status -32 [ 229.750700] ALSA midi.c:214 urb status -32 [ 229.750911] ALSA midi.c:214 urb status -32 [ 229.751175] ALSA midi.c:214 urb status -32 [ 229.751413] ALSA midi.c:214 urb status -32 [ 229.751659] ALSA midi.c:214 urb status -32 [ 229.751910] ALSA midi.c:214 urb status -32 [ 229.752210] ALSA midi.c:214 urb status -32 [ 229.752459] ALSA midi.c:214 urb status -32 [ 229.752662] ALSA midi.c:214 urb status -32
Quoted 3 lines
Hmm... I suspect some USB patches added in 3.3.3... Alan, Greg, any ideas?
3.3.2 is reported to work.
No ideas. It would be good to see a usbmon trace, with as many other USB devices unplugged as possible. Even better would be to see also a second usbmon trace from a working kernel.
Alan Stern

Oliver Neukum

2012-04-28 15:34 UTC #7 lore raw

Re: [opensuse-factory] Re: usb midi keyboard broken [3.3.3 regression] [SOLUTION]

Am Samstag, 28. April 2012, 13:45:56 schrieb Steffen Müller:

Quoted 8 lines

Oh man! After look and try many usr relevant settings I found the malfactor:
tlp usb autosuspend settings.
I use tlp (energy-saving tools for thinkpad laptops) and they autosuspend usb devices by default. Now I have blacklisted my midi keyboard an all is good. I can reproduce the problem this way. Seems so that the midi keyboard doesn't wake up if it once sleeping.

Quoted 5 lines

For all with similar problems:
edit /etc/default/tlp and set USB_BLACKLIST="<device id from usbls>" or disable usb autosuspend entirely with USB_AUTOSUSPEND=0
thanks and sorry for the bother.

No problem, but we ought to test whether we can make it work with a kernel quirk. Can you please test whether it works with USB_QUIRK_RESET_RESUME in drivers/usb/core/quirks.c ?

Regards
Oliver

Steffen Müller

2012-04-28 21:28 UTC #8 lore raw

Re: [opensuse-factory] Re: usb midi keyboard broken [3.3.3 regression] [SOLUTION]

Am Samstag, 28. April 2012, 17:30:04 schrieb Oliver Neukum:

Quoted 13 lines

Am Samstag, 28. April 2012, 13:45:56 schrieb Steffen Müller:
Quoted 12 lines
Oh man! After look and try many usr relevant settings I found the
malfactor: tlp usb autosuspend settings.
I use tlp (energy-saving tools for thinkpad laptops) and they autosuspend usb devices by default. Now I have blacklisted my midi keyboard an all is good. I can reproduce the problem this way. Seems so that the midi keyboard doesn't wake up if it once sleeping.
For all with similar problems:
edit /etc/default/tlp and set USB_BLACKLIST="<device id from usbls>" or disable usb autosuspend entirely with USB_AUTOSUSPEND=0

Quoted 6 lines

Quoted 1 line
thanks and sorry for the bother.
No problem, but we ought to test whether we can make it work with a kernel quirk. Can you please test whether it works with USB_QUIRK_RESET_RESUME in drivers/usb/core/quirks.c ?

yes, it works now without blacklisting for autosuspend after build patched kernel with this in drivers/usb/core/quirks.c

rf@ThinkpadSM:~/tmp> diff -uNr quirks-org.c quirks.c

quirks.c 2012-04-28 20:38:50.000000000 +0200 renamed from quirks-org.c 2012-04-28 23:19:45.440959001 +0200 +3 -0

@@ -123,6 +123,9 @@
        /* Guillemot Webcam Hercules Dualpix Exchange*/
        { USB_DEVICE(0x06f8, 0x3005), .driver_info = USB_QUIRK_RESET_RESUME },
 
+       /* Midiman M-Audio Keystation 88es */
+       { USB_DEVICE(0x0763, 0x0192), .driver_info = USB_QUIRK_RESET_RESUME },
+
        /* M-Systems Flash Disk Pioneers */
        { USB_DEVICE(0x08ec, 0x1000), .driver_info = USB_QUIRK_RESET_RESUME },

rf@ThinkpadSM:~/tmp>

regards
steffen

Quoted 2 lines

Regards
Oliver

Oliver Neukum

2012-04-30 08:52 UTC #9 lore raw

Re: [opensuse-factory] Re: usb midi keyboard broken [3.3.3 regression] [SOLUTION]

Am Samstag, 28. April 2012, 23:26:58 schrieb Steffen Müller:

Quoted 16 lines

yes, it works now without blacklisting for autosuspend after build patched kernel with this in drivers/usb/core/quirks.c
rf@ThinkpadSM:~/tmp> diff -uNr quirks-org.c quirks.c
quirks.c 2012-04-28 20:38:50.000000000 +0200 renamed from quirks-org.c 2012-04-28 23:19:45.440959001 +0200 +3 -0
@@ -123,6 +123,9 @@
        /* Guillemot Webcam Hercules Dualpix Exchange*/
        { USB_DEVICE(0x06f8, 0x3005), .driver_info = USB_QUIRK_RESET_RESUME },
 
+       /* Midiman M-Audio Keystation 88es */
+       { USB_DEVICE(0x0763, 0x0192), .driver_info = USB_QUIRK_RESET_RESUME },
+
        /* M-Systems Flash Disk Pioneers */
        { USB_DEVICE(0x08ec, 0x1000), .driver_info = USB_QUIRK_RESET_RESUME },
 

Quoted 1 line

rf@ThinkpadSM:~/tmp>

Could you please send a formal patch with "Signed-off-by" and stuff upstream?

Regards
Oliver

Steffen Müller

2012-04-30 09:00 UTC #10 lore raw

Re: [opensuse-factory] Re: usb midi keyboard broken [3.3.3 regression] [SOLUTION]

Am Montag, 30. April 2012, 10:48:21 schrieb Oliver Neukum:

Quoted 17 lines

Am Samstag, 28. April 2012, 23:26:58 schrieb Steffen Müller:
Quoted 16 lines
yes, it works now without blacklisting for autosuspend after build patched kernel with this in drivers/usb/core/quirks.c
rf@ThinkpadSM:~/tmp> diff -uNr quirks-org.c quirks.c
quirks.c 2012-04-28 20:38:50.000000000 +0200 renamed from quirks-org.c 2012-04-28 23:19:45.440959001 +0200 +2 -0
@@ -123,6 +123,9 @@
 
        /* Guillemot Webcam Hercules Dualpix Exchange*/
        { USB_DEVICE(0x06f8, 0x3005), .driver_info =
        USB_QUIRK_RESET_RESUME },
 
+       /* Midiman M-Audio Keystation 88es */
+       { USB_DEVICE(0x0763, 0x0192), .driver_info =
USB_QUIRK_RESET_RESUME }, +

Quoted 9 lines

Quoted 5 lines
        /* M-Systems Flash Disk Pioneers */
        { USB_DEVICE(0x08ec, 0x1000), .driver_info =
        USB_QUIRK_RESET_RESUME },
rf@ThinkpadSM:~/tmp>
Could you please send a formal patch with "Signed-off-by" and stuff upstream?

hmm... I would but I've never done this before. No idea how to do this.

Quoted 2 lines

Regards
Oliver

Felipe Balbi

2012-04-30 09:02 UTC #11 lore raw

Re: [opensuse-factory] Re: usb midi keyboard broken [3.3.3 regression] [SOLUTION]

Quoted 22 lines · Steffen Müller

Am Montag, 30. April 2012, 10:48:21 schrieb Oliver Neukum:
Quoted 21 lines
Am Samstag, 28. April 2012, 23:26:58 schrieb Steffen Müller:
Quoted 20 lines
yes, it works now without blacklisting for autosuspend after build patched kernel with this in drivers/usb/core/quirks.c
rf@ThinkpadSM:~/tmp> diff -uNr quirks-org.c quirks.c
quirks.c 2012-04-28 20:38:50.000000000 +0200 renamed from quirks-org.c 2012-04-28 23:19:45.440959001 +0200 +2 -0
@@ -123,6 +123,9 @@
 
        /* Guillemot Webcam Hercules Dualpix Exchange*/
        { USB_DEVICE(0x06f8, 0x3005), .driver_info =
        USB_QUIRK_RESET_RESUME },
 
+       /* Midiman M-Audio Keystation 88es */
+       { USB_DEVICE(0x0763, 0x0192), .driver_info =
USB_QUIRK_RESET_RESUME }, +
        /* M-Systems Flash Disk Pioneers */
        { USB_DEVICE(0x08ec, 0x1000), .driver_info =
        USB_QUIRK_RESET_RESUME },

Quoted 7 lines

Quoted 5 lines
Quoted 1 line
rf@ThinkpadSM:~/tmp>
Could you please send a formal patch with "Signed-off-by" and stuff upstream?
hmm... I would but I've never done this before. No idea how to do this.

Take a look at Documentation/SubmittingPatches, it has all the information you need ;-)

Signature · 1 line

balbi

Steffen Müller

2012-04-30 11:05 UTC #12 lore raw

PATCH 1/1 usb: add USB_QUIRK_RESET_RESUME for M-Audio 88es

In reply to Oliver Neukum

Tested-by Steffen Müller <[email protected]>

Signed-off-by Steffen Müller <[email protected]>

Signed-off-by Stefan Seyfried <[email protected]>

---
 drivers/usb/core/quirks.c |    3 +++
 1 file changed, 3 insertions(+)

drivers/usb/core/quirks.c +3 -0

index 4c65eb6..32d3adc 100644
@@ -123,6 +123,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* Guillemot Webcam Hercules Dualpix Exchange*/
 	{ USB_DEVICE(0x06f8, 0x3005), .driver_info = USB_QUIRK_RESET_RESUME },
 
+	/* Midiman M-Audio Keystation 88es */
+	{ USB_DEVICE(0x0763, 0x0192), .driver_info = USB_QUIRK_RESET_RESUME },
+
 	/* M-Systems Flash Disk Pioneers */
 	{ USB_DEVICE(0x08ec, 0x1000), .driver_info = USB_QUIRK_RESET_RESUME },