Skip to contentSkip to conversation

on master /packet_id.c::packet_id_debug_print

Openvpn-devel In review Alon Bar-Lev 2 participants 3 messages Feb 20, 2012 – Apr 27, 2012

lore
Share & tools
lore

Alon Bar-Lev

author
#0 lore raw

Hi,

Master with verb 255 I get the following after a few packets... Can someone else try out to see if it reproduced?

tls-client
tls-cipher DHE-RSA-AES256-SHA
cipher AES-256-CBC
Server DH 4096bit
Server certificate 2048bit
Client certificate 2048bit

Mon Feb 20 14:53:58 2012 us=139424 TCPv4_CLIENT read returned 149 Mon Feb 20 14:53:58 2012 us=139473 TCPv4_CLIENT READ [149] from [AF_INET]95.35.21.149:443: P_DATA_V1 kid=0 DATA b008ba2f 08bde634 fce22834 7b91d496 4c8db39b 32fc6c52 cf5ccf81 7b63584[more...] Mon Feb 20 14:53:58 2012 us=139486 TLS: tls_pre_decrypt, key_id=0, IP=[AF_INET]95.35.21.149:443
Mon Feb 20 14:53:58 2012 us=139502 DECRYPT IV: 32fc6c52 cf5ccf81 7b635843 681dbd25
Mon Feb 20 14:53:58 2012 us=139536 DECRYPT TO: 00000001 fa450000 610c5c00 007f1136 6d0a0a32 02c0a8fc 0e0035b5 55004d0[more...]

Program received signal SIGSEGV, Segmentation fault. packet_id_debug_print (msglevel=1174405255, p=0x555555833858, pin=0x7fffffffc8b0,

    message=0x5555555e5f80 "PID_TEST", value=0) at ../packet_id.c:498

498 for (i = 0; i < sl->x_size; ++i)

#0 packet_id_debug_print (msglevel=1174405255, p=0x555555833858, pin=0x7fffffffc8b0,

    message=0x5555555e5f80 "PID_TEST", value=0) at ../packet_id.c:498
#1  0x00005555555a6bcc in packet_id_debug (value=0,
message=0x5555555e5f80 "PID_TEST",
    pin=0x7fffffffc8b0, p=0x555555833858, msglevel=1174405255) at

../packet_id.c:68
#2 packet_id_test (p=0x555555833858, pin=0x7fffffffc8b0) at ../packet_id.c:191 #3 0x0000555555560185 in openvpn_decrypt (buf=0x7fffffffd678, work=..., opt=0x7fffffffd598,

    frame=<optimized out>) at ../crypto.c:340

#4 0x0000555555569ce1 in process_incoming_link (c=0x7fffffffca00) at ../forward.c:826
#5 0x00005555555929fa in tunnel_point_to_point (c=0x7fffffffca00) at ../openvpn.c:89
#6 main (argc=7, argv=0x7fffffffd978) at ../openvpn.c:242

author
#1 lore raw

PATCH 1/1 crash: packet_id_debug_print: sl may be null

Program received signal SIGSEGV, Segmentation fault. packet_id_debug_print (msglevel=1174405255, p=0xa36bd0718, pin=0x3de5feec1b0,
message=0xa330dde80 "PID_TEST", value=0) at ../../../src/openvpn/packet_id.c:504
504 for (i = 0; i < sl->x_size; ++i)

(gdb) print sl
$2 = (const struct seq_list *) 0x0

Reported in the past[1].

[1] http://thread.gmane.org/gmane.network.openvpn.devel/5466

Signed-off-by Alon Bar-Lev <[email protected]...>
---
 src/openvpn/packet_id.c |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)
src/openvpn/packet_id.c +10 -6
index 0102129..baa4966 100644
@@ -501,7 +501,7 @@ packet_id_debug_print (int msglevel,
 
   buf_printf (&out, "%s [%d]", message, value);
   buf_printf (&out, " [%s-%d] [", p->name, p->unit);
-  for (i = 0; i < sl->x_size; ++i)
+  for (i = 0; sl != NULL && i < sl->x_size; ++i)
     {
       char c;
       time_t v;

@@ -538,11 +538,15 @@ packet_id_debug_print (int msglevel,
 	      p->time_backtrack,
 	      p->max_backtrack_stat,
 	      (int)p->initialized);
-  buf_printf (&out, " sl=[%d,%d,%d,%d]",
-	      sl->x_head,
-	      sl->x_size,
-	      sl->x_cap,
-	      sl->x_sizeof);
+  if (sl != NULL)
+    {
+	  buf_printf (&out, " sl=[%d,%d,%d,%d]",
+		      sl->x_head,
+		      sl->x_size,
+		      sl->x_cap,
+		      sl->x_sizeof);
+    }
+
 
   msg (msglevel, "%s", BSTR(&out));
   gc_free (&gc);
Signature · 1 line
1.7.3.4
#2 lore raw

Re: [Openvpn-devel] [PATCH] crash: packet_id_debug_print: sl may be null

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 8 lines · Alon Bar-Lev

Program received signal SIGSEGV, Segmentation fault. packet_id_debug_print (msglevel=1174405255, p=0xa36bd0718, pin=0x3de5feec1b0, message=0xa330dde80 "PID_TEST", value=0) at
../../../src/openvpn/packet_id.c:504 504 for (i = 0; i <
sl->x_size; ++i)

(gdb) print sl $2 = (const struct seq_list *) 0x0

Quoted 7 lines

Reported in the past[1].

[1] http://thread.gmane.org/gmane.network.openvpn.devel/5466

Signed-off-by Alon Bar-Lev <[email protected]...> ---

src/openvpn/packet_id.c | 16 ++++++++++------ 1 files changed, 10
insertions(+), 6 deletions(-)

Applied to master branch on -testing and -stable trees.

commit 4e846b39a35b5f9501e4283be0af620d7c9c8b5c

Author: Alon Bar-Lev <[email protected]...>
Date:   Sun Apr 8 13:04:45 2012 +0300
    crash: packet_id_debug_print: sl may be null

    Signed-off-by: Alon Bar-Lev <[email protected]...>
    Acked-by: James Yonan <[email protected]...>

kind regards,

David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk+agOMACgkQDC186MBRfroQyQCfTE02eg99CsUB3Ced4A+iKZGW 7sUAn19wsDC5soQ1n6krB8slxztICHxM
=beGW
-----END PGP SIGNATURE-----