omap-usb-host.c compile error

DISCUSSION John Stultz 4 participants 5 messages May 1, 2012 – May 2, 2012

Subsystems (2)

Multifunction devices (MFD) OMAP2+ support

lore

Share & tools

lore

John Stultz

author

2012-05-01 21:35 UTC #0 lore raw

I've been seeing the following compile issue for a few -rcs now:
drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function 'cpu_is_omap3430' drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function 'omap_rev' drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1' undeclared (first use in this function) drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier is reported only once drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)

Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.

This still isn't fixed in Linus' HEAD. Any plans here?

thanks
-john

Nicolas Dechesne

2012-05-01 23:29 UTC #1 lore raw

Quoted 12 lines · John Stultz

I've been seeing the following compile issue for a few -rcs now:
drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function 'cpu_is_omap3430'
drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function 'omap_rev'
drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1' undeclared (first use in this function)
drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier is reported only once
drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)

Quoted 3 lines

Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.
This still isn't fixed in Linus' HEAD. Any plans here?

in fact the problem is related to this part of 1fcb57d0f6

drivers/mfd/omap-usb-host.c +0 -1

index 95a2e54..c8aae66 100644
@@ -25,7 +25,6 @@
 #include <linux/clk.h>
 #include <linux/dma-mapping.h>
 #include <linux/spinlock.h>
-#include <linux/gpio.h>
 #include <plat/usb.h>
 #include <linux/pm_runtime.h>

by removing linux/gpio.h, we remove the inclusion of plat/cpu.h which has the definition of cpu_is_omap3430()

NeilBrown

2012-05-01 23:30 UTC #2 lore raw

In reply to John Stultz

Quoted 13 lines · On Tue, 01 May 2012 14:33:21 -0700 John Stultz <[email protected]> wrote:

I've been seeing the following compile issue for a few -rcs now:
drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function 'cpu_is_omap3430'
drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function 'omap_rev'
drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1' undeclared (first use in this function)
drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier is reported only once
drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)

Quoted 6 lines

Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.
This still isn't fixed in Linus' HEAD. Any plans here?
thanks
-john

Following fixes it for me.

NeilBrown

Author: NeilBrown <[email protected]>
Date:   Wed Apr 25 10:52:05 2012 +1000

omap-usb-host: add include plat/cpu.h

Need this for a version comparison.

Signed-off-by NeilBrown <[email protected]>

drivers/mfd/omap-usb-host.c +1 -0

index c8aae66..7da9496 100644
@@ -26,6 +26,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/spinlock.h>
 #include <plat/usb.h>
+#include <plat/cpu.h>
 #include <linux/pm_runtime.h>
 
 #define USBHS_DRIVER_NAME      "usbhs_omap"

Samuel Ortiz

2012-05-02 07:46 UTC #3 lore raw

In reply to John Stultz

Hi John,

Quoted 13 lines · John Stultz

I've been seeing the following compile issue for a few -rcs now:
drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function 'cpu_is_omap3430'
drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function 'omap_rev'
drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1' undeclared (first use in this function) drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier is reported only once
drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)

Quoted 3 lines

Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.
This still isn't fixed in Linus' HEAD. Any plans here?

I pushed the fixed to my for-linus branch yesterday. I'll send a pull request to Linus in time for rc6.

Cheers,
Samuel.

Signature · 2 lines

Intel Open Source Technology Centre
http://oss.intel.com/

John Stultz

author

2012-05-02 17:46 UTC #4 lore raw

Quoted 15 lines · Samuel Ortiz

Hi John,
Quoted 12 lines · John Stultz
I've been seeing the following compile issue for a few -rcs now:
drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init':
drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function 'cpu_is_omap3430'
drivers/mfd/omap-usb-host.c:524: error: implicit declaration of function 'omap_rev'
drivers/mfd/omap-usb-host.c:524: error: 'OMAP3430_REV_ES2_1' undeclared (first use in this function) drivers/mfd/omap-usb-host.c:524: error: (Each undeclared identifier is reported only once
drivers/mfd/omap-usb-host.c:524: error: for each function it appears in.)

Quoted 6 lines

Quoted 3 lines
Reverting 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 seems to resolve it.
This still isn't fixed in Linus' HEAD. Any plans here?
I pushed the fixed to my for-linus branch yesterday. I'll send a pull request to Linus in time for rc6.

Thanks!
-john