Skip to contentSkip to conversation

omap-usb-host: include <plat/cpu.h>

PATCH In review Jeff Mahoney 3 participants 3 messages May 2, 2012 – May 7, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omap-usb-host: include <plat/cpu.h>

omap-usb-host calls cpu_is_omap3430, which is defined in plat/cpu.h.

---
 drivers/mfd/omap-usb-host.c |    1 +
 1 file changed, 1 insertion(+)
drivers/mfd/omap-usb-host.c +1 -0
@@ -26,6 +26,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/spinlock.h>
 #include <plat/usb.h>
+#include <plat/cpu.h>
 #include <linux/pm_runtime.h>
 
 #define USBHS_DRIVER_NAME	"usbhs_omap"
Signature · 2 lines
Jeff Mahoney
SUSE Labs
#2 lore raw

Hi,

Quoted 12 lines · Felipe Balbi

Hi,

Quoted 4 lines · Jeff Mahoney

omap-usb-host calls cpu_is_omap3430, which is defined in plat/cpu.h.

this looks right to me, though a driver shouldn't be using cpu_is_*** macros. Still, that patch can come later, this is needed now.

It seems it have been added in mainline:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=13176a89e1c4a0011bd9f576730b0338ecb619ff

Guillaume

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html