Skip to contentSkip to conversation

power_supply: update Charger-Manager

PATCH Superseded Chanwoo Choi 2 participants 5 messages Mar 28, 2012 – May 7, 2012

lore
Share & tools
lore
#0 lore raw

v2 cover power_supply: update Charger-Manager

Initially, the main role of Charger-Manager is to monitor battery health while
the system is in suspend-to-RAM.

This patchset updates the initial Charger-Manager to poll the battery state in normal state and provide function for in-kernel use.

As Mr. Kim Donggeun leaved the company as personal reason, I follow up of this patchset. So I replied about your comment based on following link last week.
- https://lkml.org/lkml/2012/2/29/506
- https://lkml.org/lkml/2012/2/29/524
- https://lkml.org/lkml/2012/3/4/137

The following patch url are replies which was posted on last week.
Re: power_supply: Charger-Manager: poll battery health in normal state
- https://lkml.org/lkml/2012/3/19/733
Re: power_supply: Charger-Manager: provide function for in-kernel use
- http://comments.gmane.org/gmane.linux.kernel/1270020

v2
- Code clean according to comment of Rafael J. Wysocki
- Use Power management wakeup interface for waking up the system from sleep when event is happended
- Cancle work/delayed_work in remove function

Donggeun Kim (2):
power_supply: Charger-Manager: poll battery health in normal state
power_supply: Charger-Manager: provide function for in-kernel use

 Documentation/power/charger-manager.txt |   41 +++-
 drivers/power/charger-manager.c         |  391
+++++++++++++++++++++++++++++++
 include/linux/power/charger-manager.h   |   49 ++++-
 3 files changed, 471 insertions(+), 10 deletions(-)
#1 lore raw

v2 cover power_supply: update Charger-Manager

Initially, the main role of Charger-Manager is to monitor battery health while the system is in suspend-to-RAM.

This patchset updates the initial Charger-Manager to poll the battery state in normal state and provide function for in-kernel use.

As Mr. Kim Donggeun leaved the company as personal reason, I follow up of this patchset. So I replied about your comment based on following link last week.
- https://lkml.org/lkml/2012/2/29/506
- https://lkml.org/lkml/2012/2/29/524
- https://lkml.org/lkml/2012/3/4/137

The following patch url are replies which was posted on last week.
Re: power_supply: Charger-Manager: poll battery health in normal state
- https://lkml.org/lkml/2012/3/19/733
Re: power_supply: Charger-Manager: provide function for in-kernel use
- http://comments.gmane.org/gmane.linux.kernel/1270020

v2
- Code clean according to comment of Rafael J. Wysocki
- Use Power management wakeup interface for waking up the system from sleep when event is happended
- Cancle work/delayed_work in remove function

Donggeun Kim (2):
power_supply: Charger-Manager: poll battery health in normal state
power_supply: Charger-Manager: provide function for in-kernel use

 Documentation/power/charger-manager.txt |   41 +++-
 drivers/power/charger-manager.c         |  391
+++++++++++++++++++++++++++++++
 include/linux/power/charger-manager.h   |   49 ++++-
 3 files changed, 471 insertions(+), 10 deletions(-)
#2 lore raw

v2 cover power_supply: update Charger-Manager

Initially, the main role of Charger-Manager is to monitor battery health while the system is in suspend-to-RAM.

This patchset updates the initial Charger-Manager to poll the battery state in normal state and provide function for in-kernel use.

As Mr. Kim Donggeun leaved the company as personal reason, I follow up of this patchset. So I replied about your comment based on following link last week.
- https://lkml.org/lkml/2012/2/29/506
- https://lkml.org/lkml/2012/2/29/524
- https://lkml.org/lkml/2012/3/4/137

The following patch url are replies which was posted on last week.
Re: power_supply: Charger-Manager: poll battery health in normal state
- https://lkml.org/lkml/2012/3/19/733
Re: power_supply: Charger-Manager: provide function for in-kernel use
- http://comments.gmane.org/gmane.linux.kernel/1270020

v2
- Code clean according to comment of Rafael J. Wysocki
- Use Power management wakeup interface for waking up the system from sleep when event is happended
- Cancle work/delayed_work in remove function

Donggeun Kim (2):
power_supply: Charger-Manager: poll battery health in normal state
power_supply: Charger-Manager: provide function for in-kernel use

 Documentation/power/charger-manager.txt |   41 +++-
 drivers/power/charger-manager.c         |  391
+++++++++++++++++++++++++++++++
 include/linux/power/charger-manager.h   |   49 ++++-
 3 files changed, 471 insertions(+), 10 deletions(-)
#3 lore raw

On Tue, Apr 24, 2012 at 07:47:24PM +0900, Chanwoo Choi wrote:
[...]

Quoted 5 lines
 Documentation/power/charger-manager.txt |   41 +++-
 drivers/power/charger-manager.c         |  391
+++++++++++++++++++++++++++++++
 include/linux/power/charger-manager.h   |   49 ++++-
 3 files changed, 471 insertions(+), 10 deletions(-)

Applied, thanks!

Note that the patches were word-wrap damaged, I had to fix them by hand. The file 'linux/Documentation/email-clients.txt' contains some useful tips for setting up commonly used mail clients. You might also try using 'git send-email'.

While looking through the CM code, I noticed that cm uevents are not friendly wrt several chargers (the code has static variables in the uevent_notify() func).

Also, what's the rationale behind implementing own uevent handling, and not using power_supply uevents (see power_supply_sysfs.c and power_supply_changed() thing)? Also, you don't seem to report variables in the uevent, but just messages. That's unusual.

Thanks,

Signature · 2 lines
Anton Vorontsov
Email: [email protected]
#4 lore raw

Hi Anton,

Firstly, thank for your reply and applied.

Quoted 8 lines · Anton Vorontsov

On Tue, Apr 24, 2012 at 07:47:24PM +0900, Chanwoo Choi wrote:
[...]

Quoted 5 lines
 Documentation/power/charger-manager.txt |   41 +++-
 drivers/power/charger-manager.c         |  391
+++++++++++++++++++++++++++++++
 include/linux/power/charger-manager.h   |   49 ++++-
 3 files changed, 471 insertions(+), 10 deletions(-)
Quoted 6 lines

Applied, thanks!

Note that the patches were word-wrap damaged, I had to fix them by hand. The file 'linux/Documentation/email-clients.txt' contains some useful tips for setting up commonly used mail clients. You might also try using 'git send-email'.

I'm so sorry. I will not do a same mistake.

Quoted 5 lines

While looking through the CM code, I noticed that cm uevents are not friendly wrt several chargers (the code has static variables in the uevent_notify() func).

I will modify obscure code about your comment in the next patch.

Quoted 5 lines

Also, what's the rationale behind implementing own uevent handling, and not using power_supply uevents (see power_supply_sysfs.c and power_supply_changed() thing)? Also, you don't seem to report variables in the uevent, but just messages. That's unusual.

OK, I will implement uevent feature in charger-manager by using power_supply uevents
instead of own uevent handling and post new patchset.

Best Regards,
Chanwoo Choi