mx53loco: Remove unneeded gpio_set_value()
PATCH 1/1 mx53loco: Remove unneeded gpio_set_value()
From: Fabio Estevam <[email protected]>
There is no need to set the VBUS power enable to 0 first and then to 1.
Set it to 1 in the gpio_direction_output() function.
While at it, use the standard naming convention for the GPIO comment.
Signed-off-by Fabio Estevam <[email protected]>
--- board/freescale/mx53loco/mx53loco.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
board/freescale/mx53loco/mx53loco.c +2 -3
@@ -92,10 +92,9 @@ static void setup_iomux_uart(void)#ifdef CONFIG_USB_EHCI_MX5 int board_ehci_hcd_init (int port) { -/* request VBUS power enable pin, GPIO[8}, gpio7 */ +/* request VBUS power enable pin, GPIO7_8 */ mxc_request_iomux (MX53_PIN_ATA_DA_2 ,IOMUX_CONFIG_ALT1 ); -gpio_direction_output (IOMUX_TO_GPIO (MX53_PIN_ATA_DA_2 ),0 ); -gpio_set_value (IOMUX_TO_GPIO (MX53_PIN_ATA_DA_2 ),1 ); +gpio_direction_output (IOMUX_TO_GPIO (MX53_PIN_ATA_DA_2 ),1 );return 0 ; }#endif
Signature · 1 line
1.7.1
PATCH 1/1 mx53loco: Remove unneeded gpio_set_value()
Quoted 10 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There is no need to set the VBUS power enable to 0 first and then to 1.
Set it to 1 in the
gpio_direction_output()function.While at it, use the standard naming convention for the GPIO comment.
Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================