Skip to contentSkip to conversation

move_pages09: move_pages returns 0 if nothing got migrated

PATCH In review Jan Stancek 3 participants 3 messages May 9, 2012

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 move_pages09: move_pages returns 0 if nothing got migrated

Following commit changed the behavior to return 0 when no pages require migration.

commit e78bbfa8262424417a29349a8064a535053912b9

Author: Brice Goglin <[email protected]>
Date:   Sat Oct 18 20:27:15 2008 -0700

mm: stop returning -ENOENT from sys_move_pages() if nothing got
migrated

So testing for ENOENT in move_pages09, makes sense only for kernel < 2.6.28.

---
 .../kernel/syscalls/move_pages/move_pages09.c      |   27 ++++++++++++++-----
 1 files changed, 20 insertions(+), 7 deletions(-)
testcases/kernel/syscalls/move_pages/move_pages09.c +20 -7
index 4cedb6a..85e3547 100644
@@ -105,12 +105,25 @@ int main(int argc, char **argv)
 		ret = numa_move_pages(0, TEST_PAGES, pages, nodes,
 				      status, MPOL_MF_MOVE);
 		TEST_ERRNO = errno;
-		if (ret == -1 && errno == ENOENT)
-			tst_resm(TPASS, "move_pages failed with "
-				 "ENOENT as expected");
-		else
-			tst_resm(TFAIL, "move pages did not fail "
-				 "with ENOENT");
+
+		/*
+		 * commit e78bbfa8262424417a29349a8064a535053912b9
+		 * Author: Brice Goglin <[email protected]>
+		 * Date:   Sat Oct 18 20:27:15 2008 -0700
+		 *     mm: stop returning -ENOENT from sys_move_pages() if nothing got migrated
+		 */
+		if ((tst_kvercmp(2, 6, 28)) >= 0) {
+			if (ret == 0)
+				tst_resm(TPASS, "move_pages succeeded");
+			else
+				tst_resm(TFAIL|TERRNO, "move_pages");
+		} else {
+			if (ret == -1 && errno == ENOENT)
+				tst_resm(TPASS, "move_pages failed with "
+				    "ENOENT as expected");
+			else
+				tst_resm(TFAIL|TERRNO, "move_pages");
+		}
 
 		free_pages(pages, TEST_PAGES);
 	}
@@ -150,4 +163,4 @@ void cleanup(void)
 	 */
 	TEST_CLEANUP;
 
- }
\ No newline at end of file
+ }

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Acked-by on v2 1/1
#1 lore raw
Quoted 7 lines · Jan Stancek

Following commit changed the behavior to return 0 when no pages require migration.

commit e78bbfa8262424417a29349a8064a535053912b9

Author: Brice Goglin <[email protected]>
Date:   Sat Oct 18 20:27:15 2008 -0700
Quoted 8 lines

mm: stop returning -ENOENT from sys_move_pages() if nothing got
migrated

So testing for ENOENT in move_pages09, makes sense only for kernel < 2.6.28.

---

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw
In reply to Jan Stancek
Quoted 4 lines · Jan Stancek

Following commit changed the behavior to return 0 when no pages require migration.

Quoted 8 lines

commit e78bbfa8262424417a29349a8064a535053912b9

Author: Brice Goglin <[email protected]>
Date:   Sat Oct 18 20:27:15 2008 -0700

mm: stop returning -ENOENT from sys_move_pages() if nothing got
migrated

So testing for ENOENT in move_pages09, makes sense only for kernel < 2.6.28.

pushed, thanks all,

Wanlong Gao

Quoted 19 lines
---
 .../kernel/syscalls/move_pages/move_pages09.c      |   27 ++++++++++++++-----
 1 files changed, 20 insertions(+), 7 deletions(-)

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

Quoted 4 lines

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list