Samsung fixes for v3.4
Hi Arnd and Olof,
Sorry for late request for v3.4.
If there is a chance, please pull this for v3.4:git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v3.4-samsung-fixes-4
This is including fixes of hotplug for Cortext-A15(EXYNOS5) and build failure of S3C2412(smdk2412 test) and bit typo for clk_pdma1 of exynos5 and build failure of early version of exynos4210 on universalc210 board.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
The following changes since commit d48b97b403d23f6df0b990cee652bdf9a52337a3:
Linux 3.4-rc6 (2012-05-06 15:07:32 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
v3.4-samsung-fixes-4
Changhwan Youn (1):
ARM: EXYNOS: fix the hotplug for Cortex-A15
Jose Miguel Goncalves (1):
ARM: SAMSUNG: Fix for S3C2412 EBI memory mapping
Kukjin Kim (1):
ARM: EXYNOS: fix ctrlbit for exynos5_clk_pdma1
Marek Szyprowski (1):
ARM: EXYNOS: use s5p-timer for UniversalC210 board
arch/arm/mach-exynos/Kconfig | 3 ++ arch/arm/mach-exynos/clock-exynos5.c | 2 +- arch/arm/mach-exynos/hotplug.c | 39 ++++++++++++++++++++++++- arch/arm/mach-exynos/mach-universal_c210.c | 4 ++- arch/arm/plat-samsung/include/plat/map-s3c.h | 2 +- 5 files changed, 45 insertions(+), 5 deletions(-)
Hi,
Since we are _so_ close to release, I am going to be picky about what kind of patches we're going to accept for 3.4. See below.
Quoted 2 lines · Kukjin Kim
Changhwan Youn (1):
? ? ?ARM: EXYNOS: fix the hotplug for Cortex-A15
This is a feature, not a bug fix -- cpu hotplug has never worked for A15 based on the patch description. So per definition it's 3.5 material.
Also, I'll send out a comment on the patch itself, it shouldn't check for SoC version, it should check for core version. See separate email shortly.
Quoted 2 lines
Jose Miguel Goncalves (1):
? ? ?ARM: SAMSUNG: Fix for S3C2412 EBI memory mapping
This has been broken since 2.6.32. Please queue it up in a fixes branch for the 3.5 merge window instead, it doesn't qualify as a recent regression and thus we shouldn't try to squeeze it in before the merge window closes.
Quoted 5 lines
Kukjin Kim (1):
? ? ?ARM: EXYNOS: fix ctrlbit forexynos5_clk_pdma1Marek Szyprowski (1):
? ? ?ARM: EXYNOS: use s5p-timer for UniversalC210 board
Those two look appropriate. Please send a new pull request with those two.
-Olof
Hi Arnd, Olof,
Please pull Samsung fixes for v3.4:
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
v3.4-samsung-fixes-5
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
The following changes since commit d48b97b403d23f6df0b990cee652bdf9a52337a3:
Linux 3.4-rc6 (2012-05-06 15:07:32 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
v3.4-samsung-fixes-5
Kukjin Kim (1):
ARM: EXYNOS: fix ctrlbit for exynos5_clk_pdma1
Marek Szyprowski (1):
ARM: EXYNOS: use s5p-timer for UniversalC210 board
arch/arm/mach-exynos/Kconfig | 3 +++ arch/arm/mach-exynos/clock-exynos5.c | 2 +- arch/arm/mach-exynos/mach-universal_c210.c | 4 +++- 3 files changed, 7 insertions(+), 2 deletions(-)
Quoted 16 lines · Kukjin Kim
Hi Arnd, Olof,
Please pull Samsung fixes for v3.4:
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
v3.4-samsung-fixes-5Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
Quoted 7 lines
The following changes since commit
d48b97b403d23f6df0b990cee652bdf9a52337a3:?Linux 3.4-rc6 (2012-05-06 15:07:32 -0700)
are available in the git repository at:
?git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v3.4-samsung-fixes-5
Pulled, thanks!
-Olof
Quoted 9 lines · Olof Johansson
Hi,
Since we are _so_ close to release, I am going to be picky about what kind of patches we're going to accept for 3.4. See below.
On Sat, May 12, 2012 at 2:42 PM, Kukjin Kim<[email protected]> wrote:
Quoted 7 lines
Quoted 2 lines
Changhwan Youn (1):
ARM: EXYNOS: fix the hotplug for Cortex-A15This is a feature, not a bug fix -- cpu hotplug has never worked for A15 based on the patch description. So per definition it's 3.5 material.
Hmm, in this case, IMHO, it's hard to say whether it is not a bug fix because in current mach-exynos/ problem happens during cpu hotplug on exynos5250 without that...But, OK it will be queued for v3.5.
Quoted 4 lines
Also, I'll send out a comment on the patch itself, it shouldn't check for SoC version, it should check for core version. See separate email shortly.
OK, thanks for your comments and will update it even though checking SoC version is enough in mach-exynos/ :)
Quoted 8 lines
Quoted 2 lines
Jose Miguel Goncalves (1):
ARM: SAMSUNG: Fix for S3C2412 EBI memory mappingThis has been broken since 2.6.32. Please queue it up in a fixes branch for the 3.5 merge window instead, it doesn't qualify as a recent regression and thus we shouldn't try to squeeze it in before the merge window closes.
OK, I agree.
Quoted 8 lines
Quoted 5 lines
Kukjin Kim (1):
ARM: EXYNOS: fix ctrlbit forexynos5_clk_pdma1Marek Szyprowski (1):
ARM: EXYNOS: use s5p-timer for UniversalC210 boardThose two look appropriate. Please send a new pull request with those two.
I sent just now.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
Quoted 15 lines · Kukjin Kim
Quoted 14 lines · Olof Johansson
Hi,
Since we are _so_ close to release, I am going to be picky about what kind of patches we're going to accept for 3.4. See below.
Quoted 2 lines · On Sat, May 12, 2012 at 2:42 PM, Kukjin Kim<[email protected]> ?wrote:
Changhwan Youn (1):
? ? ?ARM: EXYNOS: fix the hotplug for Cortex-A15
Quoted 7 lines
Quoted 4 lines
This is a feature, not a bug fix -- cpu hotplug has never worked for A15 based on the patch description. So per definition it's 3.5 material.
Hmm, in this case, IMHO, it's hard to say whether it is not a bug fix because in current mach-exynos/ problem happens during cpu hotplug on exynos5250 without that...But, OK it will be queued for v3.5.
Agreed, it's a borderline case -- and earlier in the -rc cycle I would have included this one without complaints.
Quoted 6 lines
Quoted 4 lines
Also, I'll send out a comment on the patch itself, it shouldn't check for SoC version, it should check for core version. See separate email shortly.
OK, thanks for your comments and will update it even though checking SoC version is enough in mach-exynos/ :)
Well, sort of -- you will need to add new checks when you add another SoC with A15, and that's just messy. If you check for A15 instead, then you won't have to modify that piece of code for every new SoC (hopefully).
Quoted 15 lines
Quoted 9 lines
Quoted 2 lines
Jose Miguel Goncalves (1):
? ? ?ARM: SAMSUNG: Fix for S3C2412 EBI memory mappingThis has been broken since 2.6.32. Please queue it up in a fixes branch for the 3.5 merge window instead, it doesn't qualify as a recent regression and thus we shouldn't try to squeeze it in before the merge window closes.
OK, I agree.
Quoted 3 lines
Quoted 3 lines
Kukjin Kim (1):
? ? ?ARM: EXYNOS: fix ctrlbit forexynos5_clk_pdma1
Quoted 7 lines
Quoted 6 lines
Quoted 2 lines
Marek Szyprowski (1):
? ? ?ARM: EXYNOS: use s5p-timer for UniversalC210 boardThose two look appropriate. Please send a new pull request with those two.
I sent just now.
Thanks for the quick turnaround!
-Olof