Skip to contentSkip to conversation

ext2: cleanup the comment for ext2_export_ops

PATCH In review Wang Sheng-Hui 2 participants 4 messages May 14, 2012 – May 15, 2012 ext2 file system

lore
Share & tools
lore

Wang Sheng-Hui

author
#0 lore raw

PATCH 1/1 ext2: cleanup the comment for ext2_export_ops

ext2_export_ops gets more valued fields, not get_parent only. Clean up the comment.

Signed-off-by Wang Sheng-Hui <[email protected]>
---
 fs/ext2/super.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
fs/ext2/super.c +0 -1
index e1025c7..640b4c6 100644
@@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid,
 /* Yes, most of these are left as NULL!!
  * A NULL value implies the default, which works with ext2-like file
  * systems, but can be improved upon.
- * Currently only get_parent is required.
  */
 static const struct export_operations ext2_export_ops = {
 	.fh_to_dentry = ext2_fh_to_dentry,
Signature · 1 line
1.7.1
#1 lore raw
Quoted 2 lines · Wang Sheng-Hui

ext2_export_ops gets more valued fields, not get_parent only. Clean up the comment.

Um, I'd just remove the whole comment. It isn't particularly informative
anyway - NULL meaning the default behavior is very common in kernel. And we really set about half of entries anyway...

Honza

Quoted 20 lines
Signed-off-by Wang Sheng-Hui <[email protected]>
---
 fs/ext2/super.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
fs/ext2/super.c +0 -1
index e1025c7..640b4c6 100644
@@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid,
 /* Yes, most of these are left as NULL!!
  * A NULL value implies the default, which works with ext2-like file
  * systems, but can be improved upon.
- * Currently only get_parent is required.
  */
 static const struct export_operations ext2_export_ops = {
 	.fh_to_dentry = ext2_fh_to_dentry,
Signature · 1 line
1.7.1
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
author
#2 lore raw
Quoted 8 lines · Jan Kara
Quoted 2 lines · Wang Sheng-Hui

ext2_export_ops gets more valued fields, not get_parent only. Clean up the comment.

Um, I'd just remove the whole comment. It isn't particularly informative
anyway - NULL meaning the default behavior is very common in kernel. And we really set about half of entries anyway...

Honza

Thanks, Honza.

Patch regenerated. Please check it.

Quoted 6 lines
Quoted 6 lines
Signed-off-by Wang Sheng-Hui <[email protected]>
---
 fs/ext2/super.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Quoted 14 lines
Quoted 14 lines
fs/ext2/super.c +0 -1
index e1025c7..640b4c6 100644
@@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid,
 /* Yes, most of these are left as NULL!!
  * A NULL value implies the default, which works with ext2-like file
  * systems, but can be improved upon.
- * Currently only get_parent is required.
  */
 static const struct export_operations ext2_export_ops = {
 	.fh_to_dentry = ext2_fh_to_dentry,
Signature · 1 line
1.7.1

From 362925f80bdfb1c105e346f535c5e51c7359b550 Mon Sep 17 00:00:00 2001
From: Wang Sheng-Hui <[email protected]>
Date: Tue, 15 May 2012 07:53:46 +0800
Subject: [PATCH] ext2: remove the redundant comment for ext2_export_ops

Per Honza, It isn't particularly informative anyway - NULL meaning the default behavior is very common in kernel. And we really set about half of entries anyway.

Remove the whole comment for ext2_export_ops.

Signed-off-by Wang Sheng-Hui <[email protected]>
---
 fs/ext2/super.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
fs/ext2/super.c +0 -5
index e1025c7..f9b0f41 100644
@@ -356,11 +356,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid,
 				    ext2_nfs_get_inode);
 }
 
-/* Yes, most of these are left as NULL!!
- * A NULL value implies the default, which works with ext2-like file
- * systems, but can be improved upon.
- * Currently only get_parent is required.
- */
 static const struct export_operations ext2_export_ops = {
 	.fh_to_dentry = ext2_fh_to_dentry,
 	.fh_to_parent = ext2_fh_to_parent,
Signature · 6 lines
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw
Quoted 8 lines · Wang Sheng-Hui
Quoted 7 lines · Jan Kara
Quoted 2 lines · Wang Sheng-Hui

ext2_export_ops gets more valued fields, not get_parent only. Clean up the comment.

Um, I'd just remove the whole comment. It isn't particularly informative
anyway - NULL meaning the default behavior is very common in kernel. And we really set about half of entries anyway...

Quoted 5 lines
Quoted 1 line

Honza

Thanks, Honza.

Patch regenerated. Please check it.

OK, thanks for the patch.

Honza

Quoted 55 lines
Quoted 5 lines
Quoted 5 lines
Signed-off-by Wang Sheng-Hui <[email protected]>
---
 fs/ext2/super.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Quoted 14 lines
Quoted 14 lines
fs/ext2/super.c +0 -1
index e1025c7..640b4c6 100644
@@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid,
 /* Yes, most of these are left as NULL!!
  * A NULL value implies the default, which works with ext2-like file
  * systems, but can be improved upon.
- * Currently only get_parent is required.
  */
 static const struct export_operations ext2_export_ops = {
 	.fh_to_dentry = ext2_fh_to_dentry,
Signature · 1 line
1.7.1

From 362925f80bdfb1c105e346f535c5e51c7359b550 Mon Sep 17 00:00:00 2001
From: Wang Sheng-Hui <[email protected]>
Date: Tue, 15 May 2012 07:53:46 +0800
Subject: [PATCH] ext2: remove the redundant comment for ext2_export_ops

Per Honza, It isn't particularly informative anyway - NULL meaning the default behavior is very common in kernel. And we really set about half of entries anyway.

Remove the whole comment for ext2_export_ops.

Signed-off-by Wang Sheng-Hui <[email protected]>
---
 fs/ext2/super.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
fs/ext2/super.c +0 -5
index e1025c7..f9b0f41 100644
@@ -356,11 +356,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid,
 				    ext2_nfs_get_inode);
 }
 
-/* Yes, most of these are left as NULL!!
- * A NULL value implies the default, which works with ext2-like file
- * systems, but can be improved upon.
- * Currently only get_parent is required.
- */
 static const struct export_operations ext2_export_ops = {
 	.fh_to_dentry = ext2_fh_to_dentry,
 	.fh_to_parent = ext2_fh_to_parent,
Signature · 1 line
1.7.1
Signature · 6 lines
Jan Kara <[email protected]>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html